Attention is currently required from: Martin L Roth, Paul Menzel.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69819 )
Change subject: Makefile.inc: fix multiple jobs build issue
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69819/comment/51dbc048_43b8abb6
PS2, Line 12: Workaround
> Work around
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69819
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a70beedf2eb1c018c5ff98163904253f9a87a61
Gerrit-Change-Number: 69819
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 05 Dec 2022 10:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Martin L Roth.
Hello build bot (Jenkins), Nico Huber, Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69819
to look at the new patch set (#3).
Change subject: Makefile.inc: fix multiple jobs build issue
......................................................................
Makefile.inc: fix multiple jobs build issue
Certain C source files for coreboot stages require fmap_config.h to
be present. When building coreboot using multiple jobs the dependency
is not always satisfied due to race condition and results in make
error. Work around it by adding fmap_config.h to stage C deps.
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Change-Id: I3a70beedf2eb1c018c5ff98163904253f9a87a61
---
M Makefile.inc
1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/69819/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/69819
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a70beedf2eb1c018c5ff98163904253f9a87a61
Gerrit-Change-Number: 69819
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bao Zheng, Jason Glenesk, Marshall Dawson, Matt DeVillier, Zheng Bao, Felix Held.
ritul guru has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69046 )
Change subject: amdfwtool: Add new family morgana & glinda
......................................................................
Patch Set 10: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/69046
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82f6c03b93d277f3f7f27ce57c1a41fdc103575
Gerrit-Change-Number: 69046
Gerrit-PatchSet: 10
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 09:36:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28017 )
Change subject: arm64: mmu: Spot check security state for TTB mapping
......................................................................
Patch Set 2:
(1 comment)
File src/arch/arm64/armv8/mmu.c:
https://review.coreboot.org/c/coreboot/+/28017/comment/b170db55_606c3b32
PS2, Line 324: assert_correct_ttb_mapping(_ettb - 1);
> that gives me using gcc-12.2: […]
Well, this should be a false alert. Although I'm not sure how what's the best way to fix it - changing to `_ttb + REGION_SIZE(ttb) - 1` ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/28017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70cda4f76f201b03d69a9ece063a3830b15ac04b
Gerrit-Change-Number: 28017
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Mon, 05 Dec 2022 09:25:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68585 )
Change subject: Documentation/mb/starlabs: De-duplicate the building instructions
......................................................................
Patch Set 13: Verified+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/68585
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20301b3041a62eb416ed61a84544ec4e5cc66c1e
Gerrit-Change-Number: 68585
Gerrit-PatchSet: 13
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Mon, 05 Dec 2022 09:15:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69492 )
Change subject: mb/starlabs/starbook/adl: Set thermal trip based on power profile
......................................................................
Patch Set 6: Verified+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/69492
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07be0aa2144b7718e28f1f675978b4b4b92752ae
Gerrit-Change-Number: 69492
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 05 Dec 2022 09:14:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons, Ben McMillen, Elyes Haouas.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65785 )
Change subject: mb/starlabs/starbook: Add Alder Lake StarBook Mk VI variant
......................................................................
Patch Set 28:
(1 comment)
File src/mainboard/starlabs/starbook/variants/adl/gpio.c:
https://review.coreboot.org/c/coreboot/+/65785/comment/37add51e_3a166b08
PS14, Line 226: PAD_CFG_GPO(GPP_D13, 1, PLTRST),
> Maybe done?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/65785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc0c265a88b19cf9e89cc8ab3e8db9abd8cf8409
Gerrit-Change-Number: 65785
Gerrit-PatchSet: 28
Gerrit-Owner: Ben McMillen <ben(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Ben McMillen <ben(a)starlabs.systems>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 05 Dec 2022 09:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-MessageType: comment