Attention is currently required from: Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70106 )
Change subject: commonlib/helpers.h: use unsigned literals in definitions
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/70106/comment/14a4484e_d0a0da6c
PS1, Line 21: so if result of
: multiplication is negative
If result of multiplying two positive integers is negative, further integer promotions don't matter […]
Overflow reporting sounds nice, but negative frequency doesn't make sense, so I've changed it to `ULL`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie60a6ee82db80328e44639175272cc8097f36c3b
Gerrit-Change-Number: 70106
Gerrit-PatchSet: 3
Gerrit-Owner: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Mon, 05 Dec 2022 12:25:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment