coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7283 discussions

[M] Change in coreboot[master]: mb/google/brya: Create marasov variant
by build bot (Jenkins) (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69052 ) Change subject: mb/google/brya: Create marasov variant ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brya/variants/marasov/memory/mem_parts_used.txt: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161827): https://review.coreboot.org/c/coreboot/+/69052/comment/55336fc1_3d49bc09 PS2, Line 9: # See util/spd_tools/README.md for more details and instructions. 'README' may be misspelled - perhaps 'README'? -- To view, visit https://review.coreboot.org/c/coreboot/+/69052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d Gerrit-Change-Number: 69052 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 05:55:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya: Create marasov variant
by Frank Chu (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli. Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69052 ) Change subject: mb/google/brya: Create marasov variant ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/69052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d Gerrit-Change-Number: 69052 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 05:55:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/brya: Create marasov variant
by Frank Chu (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli. Hello build bot (Jenkins), Tarun Tuli, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69052 to look at the new patch set (#2). Change subject: mb/google/brya: Create marasov variant ...................................................................... mb/google/brya: Create marasov variant Create the marasov variant of the brya0 reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:254365935 BRANCH=None TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_MARASOV Signed-off-by: Frank Chu <Frank_Chu(a)pegatron.corp-partner.google.com> Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/marasov/include/variant/ec.h A src/mainboard/google/brya/variants/marasov/include/variant/gpio.h A src/mainboard/google/brya/variants/marasov/memory/Makefile.inc A src/mainboard/google/brya/variants/marasov/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/marasov/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/marasov/overridetree.cb 8 files changed, 65 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/69052/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe2dc442480f6a73877b40625e228cdb2038aa4d Gerrit-Change-Number: 69052 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/corsola: Add new board 'voltorb'
by Mars Chen (Code Review) 01 Nov '22

01 Nov '22

Mars Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69085 ) Change subject: mb/google/corsola: Add new board 'voltorb' ...................................................................... mb/google/corsola: Add new board 'voltorb' Add a new kingler follower 'voltorb'. BUG=b:256737049 TEST=emerge-corsola coreboot Change-Id: Ie90917dade0ae80da237a7749cbb7b449278206b --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/69085/1 diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index 65d26ef..e53ae82 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -53,6 +53,7 @@ default "Steelix" if BOARD_GOOGLE_STEELIX default "Tentacruel" if BOARD_GOOGLE_TENTACRUEL default "Magikarp" if BOARD_GOOGLE_MAGIKARP + default "Voltorb" if BOARD_GOOGLE_VOLTORB config BOOT_DEVICE_SPI_FLASH_BUS int diff --git a/src/mainboard/google/corsola/Kconfig.name b/src/mainboard/google/corsola/Kconfig.name index 176252f..93e049d 100644 --- a/src/mainboard/google/corsola/Kconfig.name +++ b/src/mainboard/google/corsola/Kconfig.name @@ -8,6 +8,10 @@ bool "-> Steelix" select BOARD_GOOGLE_KINGLER_COMMON +config BOARD_GOOGLE_VOLTORB + bool "-> Voltorb" + select BOARD_GOOGLE_KINGLER_COMMON + comment "Krabby" config BOARD_GOOGLE_KRABBY -- To view, visit https://review.coreboot.org/c/coreboot/+/69085 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie90917dade0ae80da237a7749cbb7b449278206b Gerrit-Change-Number: 69085 Gerrit-PatchSet: 1 Gerrit-Owner: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: [WA-DO-NOT-MERGE]common/pcie: Update snoop/no-snoop latency for MTL
by Ravishankar Sarawadi (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Subrata Banik, Ravishankar Sarawadi. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68308 ) Change subject: [WA-DO-NOT-MERGE]common/pcie: Update snoop/no-snoop latency for MTL ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Any update reg this CL? sorry, need to clean up and have override in SOC, will do that asap. -- To view, visit https://review.coreboot.org/c/coreboot/+/68308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dfb9edbac95d28d50653777466ea172be64f612 Gerrit-Change-Number: 68308 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 05:46:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [WIP]src/soc/intel/mtl: Add new Meteor Lake device ID
by Ravishankar Sarawadi (Code Review) 01 Nov '22

01 Nov '22

Ravishankar Sarawadi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68306 ) Change subject: [WIP]src/soc/intel/mtl: Add new Meteor Lake device ID ...................................................................... Abandoned Merged into #68305 -- To view, visit https://review.coreboot.org/c/coreboot/+/68306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I684149810a7e17a44f603c640ec662631ad3490c Gerrit-Change-Number: 68306 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: [WIP]src/soc/intel/mtl: Add new Meteor Lake device ID
by Ravishankar Sarawadi (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Angel Pons, Ravishankar Sarawadi. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68306 ) Change subject: [WIP]src/soc/intel/mtl: Add new Meteor Lake device ID ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > Ping! […] Done File src/soc/intel/meteorlake/bootblock/report_platform.c: https://review.coreboot.org/c/coreboot/+/68306/comment/feaf62ca_6fa902ec PS1, Line 55: { PCI_DID_INTEL_MTL_P_GT2_4 > It's done in CB:68305 already. It would be a good idea to squash the two changes. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/68306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I684149810a7e17a44f603c640ec662631ad3490c Gerrit-Change-Number: 68306 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 05:44:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [WIP]src/soc/intel/mtl: Add new Meteor Lake device ID
by Ravishankar Sarawadi (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Kapil Porwal, Ravishankar Sarawadi. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68306 ) Change subject: [WIP]src/soc/intel/mtl: Add new Meteor Lake device ID ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Done, merged into previous. -- To view, visit https://review.coreboot.org/c/coreboot/+/68306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I684149810a7e17a44f603c640ec662631ad3490c Gerrit-Change-Number: 68306 Gerrit-PatchSet: 1 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 05:43:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/soc/intel/{common,meteorlake}: Add new Meteor Lake device ID
by Ravishankar Sarawadi (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal. Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68305 ) Change subject: src/soc/intel/{common,meteorlake}: Add new Meteor Lake device ID ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > please combine next CL into this alone Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad69f547a981390ef3749256e9fd9bcfc106fe3c Gerrit-Change-Number: 68305 Gerrit-PatchSet: 2 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 05:43:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: src/soc/intel/{common,meteorlake}: Add new Meteor Lake device ID
by Ravishankar Sarawadi (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Ravishankar Sarawadi. Hello build bot (Jenkins), Ravishankar Sarawadi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68305 to look at the new patch set (#2). Change subject: src/soc/intel/{common,meteorlake}: Add new Meteor Lake device ID ...................................................................... src/soc/intel/{common,meteorlake}: Add new Meteor Lake device ID Add new IGD Id. Reference: EDS Vol 1 (640228) Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Change-Id: Iad69f547a981390ef3749256e9fd9bcfc106fe3c --- M src/include/device/pci_ids.h M src/soc/intel/common/block/graphics/graphics.c M src/soc/intel/meteorlake/bootblock/report_platform.c 3 files changed, 20 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/68305/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iad69f547a981390ef3749256e9fd9bcfc106fe3c Gerrit-Change-Number: 68305 Gerrit-PatchSet: 2 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022