coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Enable SaGv
by Kevin Chiu (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Nick Vaccaro. Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69013 ) Change subject: mb/google/brya/var/lisbon: Enable SaGv ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/69013/comment/4654e777_91659e87 PS1, Line 12: TEST=FW_NAME=lisbon emerge-brask coreboot > Can we add any details on how we confirmed SaGv is operating as we expect (freq/volt change)? Hi Tarun, we could assure you that the RMT verification is passed after enabling SaGv, thank you! -- To view, visit https://review.coreboot.org/c/coreboot/+/69013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7d3203bfe06973b023a38d1aa3d69cce5c3a60c Gerrit-Change-Number: 69013 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 01:35:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/lisbon: Enable SaGv
by Kevin Chiu (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Kevin Chiu, Nick Vaccaro. Hello build bot (Jenkins), Tarun Tuli, Nick Vaccaro, Ricky Chang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/69013 to look at the new patch set (#2). Change subject: mb/google/brya/var/lisbon: Enable SaGv ...................................................................... mb/google/brya/var/lisbon: Enable SaGv Enable SaGv support for lisbon BUG=b:246657849 TEST=FW_NAME=lisbon emerge-brask coreboot pass RMT verification Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Change-Id: Ic7d3203bfe06973b023a38d1aa3d69cce5c3a60c --- M src/mainboard/google/brya/variants/lisbon/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/69013/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69013 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7d3203bfe06973b023a38d1aa3d69cce5c3a60c Gerrit-Change-Number: 69013 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset
by Tarun Tuli (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Eran Mitrani, Nick Vaccaro. Hello Shelley Chen, build bot (Jenkins), Eran Mitrani, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68819 to look at the new patch set (#20). Change subject: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset ...................................................................... mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset Leakage from the SPI CS line onto the FPMCU VDD rail was preventing the FPMCU from fully shutting down on AP reset. Instead of simply turning off the power rail, now ensure the CS line is not driven high until late in coreboot. This ensures it is completely off for the requisite minimum of 200ms (now measured at approx 1100ms). BUG=b:245953688 TEST=Confirmed FPMCU is still functional on Kohaku. Confirmed FpRebootPowerCycle unit test now passes BRANCH=Hatch Signed-off-by: Tarun Tuli <taruntuli(a)google.com> Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303 --- M src/mainboard/google/hatch/variants/kohaku/gpio.c M src/mainboard/google/hatch/variants/kohaku/ramstage.c 2 files changed, 50 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/68819/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/68819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303 Gerrit-Change-Number: 68819 Gerrit-PatchSet: 20 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Disable TBT PCIe rp1 and rp3 root ports
by Eric Lai (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: John Zhao, Kapil Porwal, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68854 ) Change subject: mb/google/rex: Disable TBT PCIe rp1 and rp3 root ports ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5c1d657c0ad0482619d739f8949bc9168eac25b Gerrit-Change-Number: 68854 Gerrit-PatchSet: 4 Gerrit-Owner: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:12:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Implement SOC Die lock down configuration
by Eric Lai (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Ravishankar Sarawadi, Kapil Porwal. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68430 ) Change subject: soc/intel/meteorlake: Implement SOC Die lock down configuration ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02e191336e99f97f4db58b27f4414001b642ad02 Gerrit-Change-Number: 68430 Gerrit-PatchSet: 2 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:10:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Use index 0 instead of 0x10 for P2SB
by Eric Lai (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69041 ) Change subject: soc/intel/meteorlake: Use index 0 instead of 0x10 for P2SB ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Any change by the index? What for? -- To view, visit https://review.coreboot.org/c/coreboot/+/69041 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44caac73e245f536f3a22baafa1a6a0370e1dd37 Gerrit-Change-Number: 69041 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset
by Shelley Chen (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Eran Mitrani, Nick Vaccaro. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68819 ) Change subject: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset ...................................................................... Patch Set 19: Code-Review+2 (1 comment) Patchset: PS16: > unresolving Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303 Gerrit-Change-Number: 68819 Gerrit-PatchSet: 19 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:06:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset
by Tarun Tuli (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Eran Mitrani, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68819 ) Change subject: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset ...................................................................... Patch Set 19: (1 comment) Patchset: PS16: > unresolving Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303 Gerrit-Change-Number: 68819 Gerrit-PatchSet: 19 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/hatch: Add variant finalize support for hatch devices
by Tarun Tuli (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Nick Vaccaro. Hello Shelley Chen, build bot (Jenkins), Eran Mitrani, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68821 to look at the new patch set (#13). Change subject: mb/google/hatch: Add variant finalize support for hatch devices ...................................................................... mb/google/hatch: Add variant finalize support for hatch devices Provide a variant_finalize() method and call to be invoked from mainboard_ops.final BUG=b:245953688 TEST=Hatch and variants build BRANCH=Hatch Signed-off-by: Tarun Tuli <taruntuli(a)google.com> Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7 --- M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/68821/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/68821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7 Gerrit-Change-Number: 68821 Gerrit-PatchSet: 13 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/hatch: Add variant finalize support for hatch devices
by Shelley Chen (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Nick Vaccaro. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68821 ) Change subject: mb/google/hatch: Add variant finalize support for hatch devices ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7 Gerrit-Change-Number: 68821 Gerrit-PatchSet: 12 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:03:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022