coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[M] Change in coreboot[master]: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset
by Shelley Chen (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Nick Vaccaro. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68819 ) Change subject: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset ...................................................................... Patch Set 18: (1 comment) Patchset: PS16: > Please add BRANCH=Hatch since this needs to be cherry-picked to hatch fw branch unresolving -- To view, visit https://review.coreboot.org/c/coreboot/+/68819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303 Gerrit-Change-Number: 68819 Gerrit-PatchSet: 18 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:03:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset
by Shelley Chen (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Nick Vaccaro. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68819 ) Change subject: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/68819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303 Gerrit-Change-Number: 68819 Gerrit-PatchSet: 18 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:02:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset
by Tarun Tuli (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Nick Vaccaro. Hello Shelley Chen, build bot (Jenkins), Eran Mitrani, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68819 to look at the new patch set (#17). Change subject: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset ...................................................................... mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset Leakage from the SPI CS line onto the FPMCU VDD rail was preventing the FPMCU from fully shutting down on AP reset. Instead of simply turning off the power rail, now ensure the CS line is not driven high until late in coreboot. This ensures it is completely off for the requisite minimum of 200ms (now measured at approx 1100ms). BUG=b:245953688 TEST=Confirmed FPMCU is still functional on Kohaku. Confirmed FpRebootPowerCycle unit test now passes BRANCH=Hatch Signed-off-by: Tarun Tuli <tarnutuli(a)google.com> Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303 --- M src/mainboard/google/hatch/variants/kohaku/gpio.c M src/mainboard/google/hatch/variants/kohaku/ramstage.c 2 files changed, 50 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/68819/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/68819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303 Gerrit-Change-Number: 68819 Gerrit-PatchSet: 17 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/hatch: Add variant finalize support for hatch devices
by Tarun Tuli (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Nick Vaccaro. Hello Shelley Chen, build bot (Jenkins), Eran Mitrani, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68821 to look at the new patch set (#12). Change subject: mb/google/hatch: Add variant finalize support for hatch devices ...................................................................... mb/google/hatch: Add variant finalize support for hatch devices Provide a variant_finalize() method and call to be invoked from mainboard_ops.final TEST=Hatch and variants build BRANCH=Hatch Signed-off-by: Tarun Tuli <taruntuli(a)google.com> Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7 --- M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/68821/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/68821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7 Gerrit-Change-Number: 68821 Gerrit-PatchSet: 12 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset
by Shelley Chen (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Nick Vaccaro. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68819 ) Change subject: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset ...................................................................... Patch Set 16: (1 comment) Patchset: PS16: Please add BRANCH=Hatch since this needs to be cherry-picked to hatch fw branch -- To view, visit https://review.coreboot.org/c/coreboot/+/68819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303 Gerrit-Change-Number: 68819 Gerrit-PatchSet: 16 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:00:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/hatch: Add variant finalize support for hatch devices
by Shelley Chen (Code Review) 01 Nov '22

01 Nov '22

Attention is currently required from: Tarun Tuli, Eran Mitrani, Nick Vaccaro. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68821 ) Change subject: mb/google/hatch: Add variant finalize support for hatch devices ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: Please add BRANCH=Hatch since this needs to be cherry-picked to hatch fw branch -- To view, visit https://review.coreboot.org/c/coreboot/+/68821 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7 Gerrit-Change-Number: 68821 Gerrit-PatchSet: 11 Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 01 Nov 2022 00:00:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022