Attention is currently required from: Zheng Bao.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69044 )
Change subject: amdfwtool: Add definition of instance for PSP entry
......................................................................
Patch Set 1:
(1 comment)
File util/amdfwtool/amdfwtool.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161816):
https://review.coreboot.org/c/coreboot/+/69044/comment/4fe33817_3c1f36f9
PS1, Line 166: } __attribute__((packed));
Prefer __packed over __attribute__((packed))
--
To view, visit https://review.coreboot.org/c/coreboot/+/69044
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f6250fd0e26cfae2cc2128ca9413a5621d2df0c
Gerrit-Change-Number: 69044
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 01 Nov 2022 01:43:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/coreboot/+/69043
to review the following change.
Change subject: amdfwtool: Add support for 32M image size
......................................................................
amdfwtool: Add support for 32M image size
Change-Id: Ica050dfecd258fdd6717c308907d7d4d2e85b926
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/69043/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index 389be9f..72f6852 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -2305,6 +2305,7 @@
case 0xFFC20000: /* Fall through */
case 0xFF820000: /* Fall through */
case 0xFF020000: /* Fall through */
+ case 0xFE020000: /* Fall through */
break;
default:
fprintf(stderr, "Error: Invalid Directory location.\n");
--
To view, visit https://review.coreboot.org/c/coreboot/+/69043
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica050dfecd258fdd6717c308907d7d4d2e85b926
Gerrit-Change-Number: 69043
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Attention: Zheng Bao
Gerrit-MessageType: newchange
Attention is currently required from: Bao Zheng, Zheng Bao.
Hello build bot (Jenkins), Julius Werner, Zheng Bao,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68389
to look at the new patch set (#2).
Change subject: WIP:cbfstool: Expand the max size of image to 32M
......................................................................
WIP:cbfstool: Expand the max size of image to 32M
This expanding doesn't affect any board. It just makes 32M image
possible.
Change-Id: I91e3488e6bf5748346c249ded723d3aa7b6f11b9
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/cbfstool/cbfstool.c
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/68389/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68389
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I91e3488e6bf5748346c249ded723d3aa7b6f11b9
Gerrit-Change-Number: 68389
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Nick Vaccaro.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69013 )
Change subject: mb/google/brya/var/lisbon: Enable SaGv
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69013/comment/cf35c28c_fd79b948
PS1, Line 12: TEST=FW_NAME=lisbon emerge-brask coreboot
> Hi Tarun, […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/69013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3203bfe06973b023a38d1aa3d69cce5c3a60c
Gerrit-Change-Number: 69013
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 01 Nov 2022 01:35:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Nick Vaccaro.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69013 )
Change subject: mb/google/brya/var/lisbon: Enable SaGv
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69013/comment/4654e777_91659e87
PS1, Line 12: TEST=FW_NAME=lisbon emerge-brask coreboot
> Can we add any details on how we confirmed SaGv is operating as we expect (freq/volt change)?
Hi Tarun,
we could assure you that the RMT verification is passed after enabling SaGv, thank you!
--
To view, visit https://review.coreboot.org/c/coreboot/+/69013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3203bfe06973b023a38d1aa3d69cce5c3a60c
Gerrit-Change-Number: 69013
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 01 Nov 2022 01:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Nick Vaccaro.
Hello build bot (Jenkins), Tarun Tuli, Nick Vaccaro, Ricky Chang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69013
to look at the new patch set (#2).
Change subject: mb/google/brya/var/lisbon: Enable SaGv
......................................................................
mb/google/brya/var/lisbon: Enable SaGv
Enable SaGv support for lisbon
BUG=b:246657849
TEST=FW_NAME=lisbon emerge-brask coreboot
pass RMT verification
Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Change-Id: Ic7d3203bfe06973b023a38d1aa3d69cce5c3a60c
---
M src/mainboard/google/brya/variants/lisbon/overridetree.cb
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/69013/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3203bfe06973b023a38d1aa3d69cce5c3a60c
Gerrit-Change-Number: 69013
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ricky Chang <rickytlchang(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eran Mitrani, Nick Vaccaro.
Hello Shelley Chen, build bot (Jenkins), Eran Mitrani, Nick Vaccaro,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68819
to look at the new patch set (#20).
Change subject: mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset
......................................................................
mb/google/hatch: Kohaku - ensure FPMCU is power cycled on reset
Leakage from the SPI CS line onto the FPMCU VDD rail was preventing
the FPMCU from fully shutting down on AP reset.
Instead of simply turning off the power rail, now ensure the CS
line is not driven high until late in coreboot.
This ensures it is completely off for the requisite minimum of 200ms
(now measured at approx 1100ms).
BUG=b:245953688
TEST=Confirmed FPMCU is still functional on Kohaku.
Confirmed FpRebootPowerCycle unit test now passes
BRANCH=Hatch
Signed-off-by: Tarun Tuli <taruntuli(a)google.com>
Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303
---
M src/mainboard/google/hatch/variants/kohaku/gpio.c
M src/mainboard/google/hatch/variants/kohaku/ramstage.c
2 files changed, 50 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/68819/20
--
To view, visit https://review.coreboot.org/c/coreboot/+/68819
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e7e32f61c3ac1b3154d42821cc1dd4c5d3de303
Gerrit-Change-Number: 68819
Gerrit-PatchSet: 20
Gerrit-Owner: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: newpatchset