coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: mb/adlrvp: Add new ADL P board variant for MCHP1727
by Tim Wawrzynczak (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Paul Menzel, Furquan Shaikh, Tim Wawrzynczak, Brandon Breitenstein. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56839 ) Change subject: mb/adlrvp: Add new ADL P board variant for MCHP1727 ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File src/mainboard/intel/adlrvp/variants/adlrvp_m_mchp/overridetree.cb: https://review.coreboot.org/c/coreboot/+/56839/comment/bd75b12e_936f58d6 PS6, Line 11: nit: extra blank line -- To view, visit https://review.coreboot.org/c/coreboot/+/56839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169 Gerrit-Change-Number: 56839 Gerrit-PatchSet: 6 Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 21:11:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] soc/amd/picasso: introduce AMD_SOC_SEPARATE_EFS_SECTION
by Felix Held (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Hello Jason Glenesk, Raul Rangel, Marshall Dawson, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57320 to look at the new patch set (#2). Change subject: [WIP] soc/amd/picasso: introduce AMD_SOC_SEPARATE_EFS_SECTION ...................................................................... [WIP] soc/amd/picasso: introduce AMD_SOC_SEPARATE_EFS_SECTION On systems that use the first 128kByte of the SPI flash for the EC firmware, it is not possible to place the EFS/amdfw part at the lowest location in flash where the on-chip PSP firmware will look for the EFS, since this is at an offset of 128kByte into the flash which is where the cbfs master header resides when the main CBFS is placed right after the EC firmware. This patch introduces the AMD_SOC_SEPARATE_EFS_SECTION option that allows putting the EFS in a separate FMAP section that can be located right after the EC firmware FMAP section. TODO: check if the EFS FMAP partition begins at the expected location TEST=Mandolin which only uses one CBFS still boots. The case with RO/A/B CBFS isn't tested. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I88824e4d0c1ead203f46f8cd64e1d1b4f1aa6cf7 --- M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/Makefile.inc 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/57320/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88824e4d0c1ead203f46f8cd64e1d1b4f1aa6cf7 Gerrit-Change-Number: 57320 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: wifi: Add support for DSM methods for intel wifi card
by Tim Wawrzynczak (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Paul Menzel, Rizwan Qureshi. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56751 ) Change subject: wifi: Add support for DSM methods for intel wifi card ...................................................................... Patch Set 21: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie154edf188531fe6c260274edaa694cf3b3605d3 Gerrit-Change-Number: 56751 Gerrit-PatchSet: 21 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com> Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com> Gerrit-CC: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sherry An <sherry.an(a)intel.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 21:05:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [TEST] mb/amd/mandolin: use AMD_SOC_SEPARATE_EFS_SECTION
by Felix Held (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Jason Glenesk, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57321 ) Change subject: [TEST] mb/amd/mandolin: use AMD_SOC_SEPARATE_EFS_SECTION ...................................................................... [TEST] mb/amd/mandolin: use AMD_SOC_SEPARATE_EFS_SECTION Move the EFS to the lowest possible position inside the flash by adding an EFS FMAP section right after the EC firmware FMAP section and selecting AMD_SOC_SEPARATE_EFS_SECTION. TEST=Mandolin still boots. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I372bcc60943a42b511cea1fdd451a15ad420a679 --- M src/mainboard/amd/mandolin/Kconfig M src/mainboard/amd/mandolin/variants/mandolin/board.fmd 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/57321/1 diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 50b3e5d..96f14ab 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -12,6 +12,7 @@ select HAVE_ACPI_RESUME select DRIVERS_UART_ACPI select AMD_SOC_CONSOLE_UART if !AMD_LPC_DEBUG_CARD + select AMD_SOC_SEPARATE_EFS_SECTION if BOARD_AMD_MANDOLIN config FMDFILE default "src/mainboard/amd/mandolin/variants/\$(CONFIG_VARIANT_DIR)/board.fmd" @@ -69,7 +70,6 @@ config AMD_FWM_POSITION_INDEX int - default 3 if BOARD_AMD_MANDOLIN default 4 if BOARD_AMD_CEREME help TODO: might need to be adapted for better placement of files in cbfs diff --git a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd index 33b281d..1296b85 100644 --- a/src/mainboard/amd/mandolin/variants/mandolin/board.fmd +++ b/src/mainboard/amd/mandolin/variants/mandolin/board.fmd @@ -1,6 +1,7 @@ FLASH@0xFF800000 8M { BIOS { EC 128K + EFS 3M RW_MRC_CACHE 64K FMAP 4K COREBOOT(CBFS) -- To view, visit https://review.coreboot.org/c/coreboot/+/57321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I372bcc60943a42b511cea1fdd451a15ad420a679 Gerrit-Change-Number: 57321 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: [WIP] soc/amd/picasso: introduce AMD_SOC_SEPARATE_EFS_SECTION
by Felix Held (Code Review) 01 Sep '21

01 Sep '21

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57320 ) Change subject: [WIP] soc/amd/picasso: introduce AMD_SOC_SEPARATE_EFS_SECTION ...................................................................... [WIP] soc/amd/picasso: introduce AMD_SOC_SEPARATE_EFS_SECTION On systems that use the first 128kByte of the SPI flash for the EC firmware, it is not possible to place the EFS/amdfw part at the lowest location in flash where the on-chip PSP firmware will look for the EFS, since this is at an offset of 128kByte into the flash which is where the cbfs master header resides when the main CBFS is placed right after the EC firmware. This patch introduces the AMD_SOC_SEPARATE_EFS_SECTION option that allows putting the EFS in a separate FMAP section that can be located right after the EC firmware FMAP section. TODO: check if the EFS FMAP partition begins at the expected location TEST=Mandolin which only uses one CBFS still boots. The case with RO/A/B CBFS isn't tested. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I88824e4d0c1ead203f46f8cd64e1d1b4f1aa6cf7 --- M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/Makefile.inc 2 files changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/57320/1 diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index addff5e..e079cd6 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -457,6 +457,14 @@ endmenu +config AMD_SOC_SEPARATE_EFS_SECTION + bool + help + Use separate EFS FMAP section instead of putting EFS into CBFS. The + FMAP section must begin exactly at the location the EFS needs to be + placed in the flash. This option can be used to place the EFS right + after the 128kByte EC firmware at the beginning of the flash. + config VBOOT select VBOOT_VBNV_CMOS select VBOOT_VBNV_CMOS_BACKUP_TO_FLASH diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc index d873079..b2d3071 100644 --- a/src/soc/amd/picasso/Makefile.inc +++ b/src/soc/amd/picasso/Makefile.inc @@ -268,10 +268,19 @@ --anywhere \ --output $@ +ifeq ($(CONFIG_AMD_SOC_SEPARATE_EFS_SECTION),y) +$(call add_intermediate, amdfw_fmap_section) +#FWM_POSITION_BASE=$(shell printf "%\#x" $(PICASSO_FWM_POSITION)) +#EFS_SECTION_BASE=$(shell awk '$$2 == "FMAP_SECTION_EFS_START" {print $$3}' $(obj)/fmap_config.h) +#TODO: error out if FWM_POSITION_BASE != EFS_SECTION_BASE; depends on $(obj)/fmap_config.h bing generated though +amdfw_fmap_section: $(obj)/coreboot.pre $(obj)/amdfw.rom $(obj)/fmap_config.h + $(CBFSTOOL) $(obj)/coreboot.pre write -r EFS -f $(obj)/amdfw.rom --fill-upward +else # CONFIG_AMD_SOC_SEPARATE_EFS_SECTION cbfs-files-y += apu/amdfw apu/amdfw-file := $(obj)/amdfw.rom apu/amdfw-position := $(PICASSO_FWM_POSITION) apu/amdfw-type := raw +endif # CONFIG_AMD_SOC_SEPARATE_EFS_SECTION ifeq ($(CONFIG_VBOOT_SLOTS_RW_AB)$(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),yy) cbfs-files-y += apu/amdfw_a -- To view, visit https://review.coreboot.org/c/coreboot/+/57320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88824e4d0c1ead203f46f8cd64e1d1b4f1aa6cf7 Gerrit-Change-Number: 57320 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: wifi: Add support for wifi time average SAR config
by Tim Wawrzynczak (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Sugnan Prabhu S. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57061 ) Change subject: wifi: Add support for wifi time average SAR config ...................................................................... Patch Set 9: (1 comment) File src/drivers/wifi/generic/acpi.c: https://review.coreboot.org/c/coreboot/+/57061/comment/1c19768a_29e1cd51 PS9, Line 315: MAX_DENYLIST_ENTRY can this be `wtas->tas_list_size` or do all 16 entries have to be there? (if so, why have a list size field 😕) -- To view, visit https://review.coreboot.org/c/coreboot/+/57061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42cf3cba7974e6db0e05de30846ef103a15fd584 Gerrit-Change-Number: 57061 Gerrit-PatchSet: 9 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 21:03:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: wifi: Add support for per-platform antenna gain
by Tim Wawrzynczak (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Sugnan Prabhu S. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57060 ) Change subject: wifi: Add support for per-platform antenna gain ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/57060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8d25113feeeb4a4242cfd7d72a5091d2d5fb389 Gerrit-Change-Number: 57060 Gerrit-PatchSet: 8 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 21:01:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: wifi: Add support for new revisions of SAR table entries
by Tim Wawrzynczak (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Paul Menzel. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 ) Change subject: wifi: Add support for new revisions of SAR table entries ...................................................................... Patch Set 25: Code-Review+1 (3 comments) File src/vendorcode/google/chromeos/sar.c: https://review.coreboot.org/c/coreboot/+/56750/comment/220b3f9b_dd2636b1 PS25, Line 59: (1 + sar->dsar_set_count) comment why the `1 + ` is required? https://review.coreboot.org/c/coreboot/+/56750/comment/2ba395c1_d52165bb PS25, Line 99: void * a `uint8_t *` should be able to cast to anything, this can be: `struct sar_header *` https://review.coreboot.org/c/coreboot/+/56750/comment/afbe0e3e_26ead37e PS25, Line 220: !strncmp(sar_str, SAR_STR_PREFIX, SAR_STR_PREFIX_SIZE) != 0 extra `!` at the beginning `if (strncmp(sar_str, SAR_STR_PREFIX, SAR_STR_PREFIX_SIZE) != 0)` ? -- To view, visit https://review.coreboot.org/c/coreboot/+/56750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08c3f321938eba04e8bcff4d87cb215422715bb2 Gerrit-Change-Number: 56750 Gerrit-PatchSet: 25 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com> Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com> Gerrit-CC: Matt Chen <matt.chen(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Sep 2021 21:00:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Skip returning default leaf value as `0`
by Tim Wawrzynczak (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Subrata Banik, Angel Pons, Kyösti Mälkki. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57305 ) Change subject: arch/x86: Skip returning default leaf value as `0` ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: No VIA support? 😜 -- To view, visit https://review.coreboot.org/c/coreboot/+/57305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b Gerrit-Change-Number: 57305 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 20:41:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: qualcomm/sc7180: Clean up drivers with common clock
by Shelley Chen (Code Review) 01 Sep '21

01 Sep '21

Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56587 ) Change subject: qualcomm/sc7180: Clean up drivers with common clock ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic334fd0d43e5b4b1e43a27d5db7665f0bc151d66 Gerrit-Change-Number: 56587 Gerrit-PatchSet: 8 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Taniya Das <tdas(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Sep 2021 20:35:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021