coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: soc/tigerlake: Make IO decode / enable register configurable
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Sean Rhodes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57140 ) Change subject: soc/tigerlake: Make IO decode / enable register configurable ...................................................................... Patch Set 14: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57140/comment/a0ea73bb_3d67285a PS14, Line 9: Would allow This allows https://review.coreboot.org/c/coreboot/+/57140/comment/c0d6b247_09a4a9b1 PS14, Line 10: the same way that Skylake can be i.e. register "lpc_ioe" Dot/period at the end. File src/soc/intel/tigerlake/bootblock/pch.c: https://review.coreboot.org/c/coreboot/+/57140/comment/74db2957_2e605bac PS14, Line 115: io_enables = config->lpc_ioe; Skylake has: if (config->lpc_ioe) { io_enables = config->lpc_ioe & 0x3f0f; lpc_set_fixed_io_ranges(config->lpc_iod, 0x1377); } else { /* IO Decode Range */ if (CONFIG(DRIVERS_UART_8250IO)) lpc_io_setup_comm_a_b(); } -- To view, visit https://review.coreboot.org/c/coreboot/+/57140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1a7f2707e565a5651ebe438320de9597f5742c3 Gerrit-Change-Number: 57140 Gerrit-PatchSet: 14 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:16:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/it8987: Fix build warning
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Sean Rhodes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57044 ) Change subject: ec/starlabs/it8987: Fix build warning ...................................................................... Patch Set 11: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57044/comment/faa38fe1_b7b4b519 PS11, Line 9: Fix build warning when EC binary not included when it shouldn't be Please add dot/period at the end. https://review.coreboot.org/c/coreboot/+/57044/comment/f94316cd_521ddc8a PS11, Line 10: What is the build warning? -- To view, visit https://review.coreboot.org/c/coreboot/+/57044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id16881fd7901a2eaafc6108676ff429fb71c3571 Gerrit-Change-Number: 57044 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:10:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/it8987: Change method name for get_version
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Sean Rhodes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57172 ) Change subject: ec/starlabs/it8987: Change method name for get_version ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/57172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic14be189b462c5e84b83e61e14a91e954c4eb871 Gerrit-Change-Number: 57172 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:09:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Skip returning default leaf value as `0`
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Subrata Banik, Angel Pons, Kyösti Mälkki. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57305 ) Change subject: arch/x86: Skip returning default leaf value as `0` ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57305/comment/432f0349_e65102eb PS2, Line 11: leaf leafs? https://review.coreboot.org/c/coreboot/+/57305/comment/520d4b9d_a5c97e3b PS2, Line 16: e2b5fee Please add: > Fixes: e2b5fee3b006 (arch/x86: smbios write 7 table using deterministic cache functions) File src/arch/x86/cpu_common.c: https://review.coreboot.org/c/coreboot/+/57305/comment/53376b4b_9b02dff7 PS2, Line 115: return DETERMINISTIC_CACHE_PARAMETERS_CPUID_IA; You could use the ternary operator. -- To view, visit https://review.coreboot.org/c/coreboot/+/57305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b Gerrit-Change-Number: 57305 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:09:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/it8987: Add Kconfig option for EC binary
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Sean Rhodes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57173 ) Change subject: ec/starlabs/it8987: Add Kconfig option for EC binary ...................................................................... Patch Set 6: (1 comment) File src/ec/starlabs/it8987/Kconfig: https://review.coreboot.org/c/coreboot/+/57173/comment/344c69b9_60f3ba03 PS6, Line 14: The EC binary Could you elaborate how to get the binary file? -- To view, visit https://review.coreboot.org/c/coreboot/+/57173 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa342c10cbc2118d84b981dce214648eca9fd97b Gerrit-Change-Number: 57173 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:03:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Fix TPM IRQ conflict with I2C4
by Bora Guvendik (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Anil Kumar K, Selma Bensaid, Tim Wawrzynczak, Bernardo Perez Priego. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57102 ) Change subject: mb/intel/adlrvp_m: Fix TPM IRQ conflict with I2C4 ...................................................................... Patch Set 8: (1 comment) File src/mainboard/intel/adlrvp/gpio_m.c: https://review.coreboot.org/c/coreboot/+/57102/comment/80c7ac7c_95926088 PS8, Line 171: "E3 :" to be consistent with the rest -- To view, visit https://review.coreboot.org/c/coreboot/+/57102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0f3885dec5a6f635254c233709090321491c739 Gerrit-Change-Number: 57102 Gerrit-PatchSet: 8 Gerrit-Owner: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:01:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/it8987: Always show HID Driver
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Sean Rhodes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57178 ) Change subject: ec/starlabs/it8987: Always show HID Driver ...................................................................... Patch Set 8: (3 comments) Patchset: PS8: Maybe split the style changes and functional changes in separate commits? File src/ec/starlabs/it8987/acpi/hid.asl: https://review.coreboot.org/c/coreboot/+/57178/comment/e31eb568_98b2196a PS8, Line 12: Name (HEB1, 0x3003) Why is this removed? https://review.coreboot.org/c/coreboot/+/57178/comment/790ac783_49c4adbe PS8, Line 5: Name (_HID, "INT33D5") // Intel Ultrabook HID Platform Event Driver. Dot/period at the end not needed? -- To view, visit https://review.coreboot.org/c/coreboot/+/57178 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id94b789b72cd315f0c3663419c24a2643d62a75a Gerrit-Change-Number: 57178 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:00:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Check unsupported CPU type while writing to SMBIOS table 7
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Subrata Banik, Angel Pons, Kyösti Mälkki, Swift Geek (Sebastian Grzywna). Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57306 ) Change subject: arch/x86: Check unsupported CPU type while writing to SMBIOS table 7 ...................................................................... Patch Set 2: (1 comment) File src/arch/x86/smbios.c: https://review.coreboot.org/c/coreboot/+/57306/comment/656d60bb_56410173 PS2, Line 770: printk(BIOS_DEBUG, "SMBIOS: Unknown CPU\n"); Should the message be more specific? -- To view, visit https://review.coreboot.org/c/coreboot/+/57306 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id65dc963e235f7080370a32cf69bcc4bee94d28f Gerrit-Change-Number: 57306 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 22:57:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/adlrvp: Add new ADL P board variant for MCHP1727
by Brandon Breitenstein (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Furquan Shaikh, Brandon Breitenstein. Hello build bot (Jenkins), Vijay P Hiremath, Brandon Breitenstein, Tim Wawrzynczak, Angel Pons, Furquan Shaikh, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56839 to look at the new patch set (#8). Change subject: mb/adlrvp: Add new ADL P board variant for MCHP1727 ...................................................................... mb/adlrvp: Add new ADL P board variant for MCHP1727 Add new board variant to enable MCHP1727 Modular EC Card on RVP BUG=b:179214042 BRANCH=none TEST=emerge brya and verify that adlrvp_p_mchp images boot Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169 Signed-off-by: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com> --- M src/mainboard/intel/adlrvp/Kconfig M src/mainboard/intel/adlrvp/Kconfig.name A src/mainboard/intel/adlrvp/variants/adlrvp_p_mchp/overridetree.cb 3 files changed, 46 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/56839/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/56839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169 Gerrit-Change-Number: 56839 Gerrit-PatchSet: 8 Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/adlrvp: Add new ADL P board variant for MCHP1727
by Brandon Breitenstein (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Furquan Shaikh, Brandon Breitenstein. Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56839 ) Change subject: mb/adlrvp: Add new ADL P board variant for MCHP1727 ...................................................................... Patch Set 7: (1 comment) File src/mainboard/intel/adlrvp/Kconfig: https://review.coreboot.org/c/coreboot/+/56839/comment/39b9dd2b_db8093d1 PS7, Line 41: adlrvp_p_ext_ec > Actually if I am reading this code correctly, is the correct overridetree.cb being selected? […] hmm not sure why I left the naming here I think originally it was just using the ext_ec overrides so that would have made sense I will update this to the correct value -- To view, visit https://review.coreboot.org/c/coreboot/+/56839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169 Gerrit-Change-Number: 56839 Gerrit-PatchSet: 7 Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 22:21:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021