coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: drivers/mipi: Orientation is a property of the mainboard, not the panel
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Hung-Te Lin, Julius Werner, Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57324 ) Change subject: drivers/mipi: Orientation is a property of the mainboard, not the panel ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57324/comment/7e39c6aa_b7af8610 PS1, Line 7: Orientation is a property of the mainboard, not the panel Nit: Make orientation a property of the mainboard, not the panel -- To view, visit https://review.coreboot.org/c/coreboot/+/57324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2b716aa4dae036515730c12961fdd8a9ac34753 Gerrit-Change-Number: 57324 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:41:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Make framebuffer orientation to be configurable
by Julius Werner (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Nico Huber, Furquan Shaikh, shkim, Paul Menzel, SH Kim, Angel Pons, Andrey Petrov, Patrick Rudolph. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57199 ) Change subject: drivers/intel/fsp2_0: Make framebuffer orientation to be configurable ...................................................................... Patch Set 1: (1 comment) File src/drivers/intel/fsp2_0/graphics.c: https://review.coreboot.org/c/coreboot/+/57199/comment/2277b91a_4f877b2f PS1, Line 103: enum lb_fb_orientation __weak fsp_get_framebuffer_orientation(void) > I assumed it meant a more common place in the code. There seems to be no need to make this FSP specific. Well, this is the FSP platform graphics driver, right? This is where the framebuffer info is created for this platform, so this needs to decide the orientation. Other platforms which create framebuffer info in their own graphics drivers also decide the orientation there. Sorry, I feel like I'm still not getting it. > 2. I don't think we can simply adjust which of FB_ORIENTATION_LEFT_UP and FB_ORIENTATION_RIGHT_UP we should use for portrait panel. I saw some portrait panels had LEFT_UP setting [https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/sr…], but we need RIGHT_UP setting this time for bugzzy. Yes, hmm, well... that's fair. I kinda noticed this when working on that panel stuff but hoped that in practice it wouldn't become an issue anytime soon since people would probably always rotate those panels in the same way anyway. Guess they don't. The proper solution is for the mainboard that uses these common panel information structures to associate its own orientation with them, so let's do that: CB:57324. -- To view, visit https://review.coreboot.org/c/coreboot/+/57199 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If51d2698d5fdf651183a908717076c8a14605997 Gerrit-Change-Number: 57199 Gerrit-PatchSet: 1 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:34:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: shkim <sh_.kim(a)samsung.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/mipi: Orientation is a property of the mainboard, not the panel
by Julius Werner (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/57324 to review the following change. Change subject: drivers/mipi: Orientation is a property of the mainboard, not the panel ...................................................................... drivers/mipi: Orientation is a property of the mainboard, not the panel It doesn't make sense to store the orientation field directly in the panel information structure, which is supposed to be reuseable between different boards. The thing that determines orientation is how that panel is built into the board in question, which only the board itself can know. The same portrait panel could be rotated left to be used as landscape in one board and rotated right to be used as landscape in another. This patch moves the orientation field out of the panel structure back into the mainboards to reflect this. Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: If2b716aa4dae036515730c12961fdd8a9ac34753 --- M src/drivers/mipi/panel-AUO_B101UAN08_3.c M src/drivers/mipi/panel-AUO_KD101N80_45NA.c M src/drivers/mipi/panel-BOE_TV101WUM_N53.c M src/drivers/mipi/panel-BOE_TV101WUM_NL6.c M src/drivers/mipi/panel-BOE_TV105WUM_NW0.c M src/drivers/mipi/panel-CMN_P097PFG_SSD2858.c M src/drivers/mipi/panel-STA_2081101QFH032011_53G.c M src/drivers/mipi/panel-VIS_RM69299.c M src/include/mipi/panel.h M src/mainboard/google/kukui/panel.h M src/mainboard/google/kukui/panel_anx7625.c M src/mainboard/google/kukui/panel_flapjack.c M src/mainboard/google/kukui/panel_kakadu.c M src/mainboard/google/kukui/panel_katsu.c M src/mainboard/google/kukui/panel_kodama.c M src/mainboard/google/kukui/panel_krane.c M src/mainboard/google/kukui/panel_kukui.c M src/mainboard/google/kukui/panel_ps8640.c M src/mainboard/google/trogdor/mainboard.c 19 files changed, 22 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/57324/1 diff --git a/src/drivers/mipi/panel-AUO_B101UAN08_3.c b/src/drivers/mipi/panel-AUO_B101UAN08_3.c index 8eeac85..5144ce5 100644 --- a/src/drivers/mipi/panel-AUO_B101UAN08_3.c +++ b/src/drivers/mipi/panel-AUO_B101UAN08_3.c @@ -18,7 +18,6 @@ .x_mm = 135, .y_mm = 216, }, }, - .orientation = LB_FB_ORIENTATION_LEFT_UP, .init = { PANEL_DELAY(24), PANEL_DCS(0xB0, 0x01), diff --git a/src/drivers/mipi/panel-AUO_KD101N80_45NA.c b/src/drivers/mipi/panel-AUO_KD101N80_45NA.c index 436940c..6055097 100644 --- a/src/drivers/mipi/panel-AUO_KD101N80_45NA.c +++ b/src/drivers/mipi/panel-AUO_KD101N80_45NA.c @@ -18,7 +18,6 @@ .x_mm = 135, .y_mm = 216, }, }, - .orientation = LB_FB_ORIENTATION_LEFT_UP, .init = { PANEL_DELAY(10), PANEL_DCS(0x11), diff --git a/src/drivers/mipi/panel-BOE_TV101WUM_N53.c b/src/drivers/mipi/panel-BOE_TV101WUM_N53.c index bc45474..d5df681 100644 --- a/src/drivers/mipi/panel-BOE_TV101WUM_N53.c +++ b/src/drivers/mipi/panel-BOE_TV101WUM_N53.c @@ -18,7 +18,6 @@ .x_mm = 135, .y_mm = 216, }, }, - .orientation = LB_FB_ORIENTATION_LEFT_UP, .init = { PANEL_DELAY(24), PANEL_DCS(0xB0, 0x05), diff --git a/src/drivers/mipi/panel-BOE_TV101WUM_NL6.c b/src/drivers/mipi/panel-BOE_TV101WUM_NL6.c index 2c990f8..d7678d8 100644 --- a/src/drivers/mipi/panel-BOE_TV101WUM_NL6.c +++ b/src/drivers/mipi/panel-BOE_TV101WUM_NL6.c @@ -18,7 +18,6 @@ .x_mm = 135, .y_mm = 216, }, }, - .orientation = LB_FB_ORIENTATION_LEFT_UP, .init = { PANEL_DELAY(24), PANEL_DCS(0xB0, 0x05), diff --git a/src/drivers/mipi/panel-BOE_TV105WUM_NW0.c b/src/drivers/mipi/panel-BOE_TV105WUM_NW0.c index 6931193..97b8483 100644 --- a/src/drivers/mipi/panel-BOE_TV105WUM_NW0.c +++ b/src/drivers/mipi/panel-BOE_TV105WUM_NW0.c @@ -18,7 +18,6 @@ .x_mm = 147, .y_mm = 236, }, }, - .orientation = LB_FB_ORIENTATION_LEFT_UP, .init = { PANEL_DCS(0x10), PANEL_DELAY(34), diff --git a/src/drivers/mipi/panel-CMN_P097PFG_SSD2858.c b/src/drivers/mipi/panel-CMN_P097PFG_SSD2858.c index 73e8596..637533e 100644 --- a/src/drivers/mipi/panel-CMN_P097PFG_SSD2858.c +++ b/src/drivers/mipi/panel-CMN_P097PFG_SSD2858.c @@ -18,7 +18,6 @@ .x_mm = 147, .y_mm = 196, }, }, - .orientation = LB_FB_ORIENTATION_NORMAL, .init = { PANEL_GENERIC(0xff, 0x00), /* LOCKCNT=0x1f4, MRX=0, POSTDIV=1 (/2} }, MULT=0x49 diff --git a/src/drivers/mipi/panel-STA_2081101QFH032011_53G.c b/src/drivers/mipi/panel-STA_2081101QFH032011_53G.c index be8ba73..9c4dbe3 100644 --- a/src/drivers/mipi/panel-STA_2081101QFH032011_53G.c +++ b/src/drivers/mipi/panel-STA_2081101QFH032011_53G.c @@ -18,7 +18,6 @@ .x_mm = 135, .y_mm = 217, }, }, - .orientation = LB_FB_ORIENTATION_LEFT_UP, .init = { PANEL_DCS(0xB0, 0x01), PANEL_DCS(0xC3, 0x4F), diff --git a/src/drivers/mipi/panel-VIS_RM69299.c b/src/drivers/mipi/panel-VIS_RM69299.c index aff2a99..697b0e7 100644 --- a/src/drivers/mipi/panel-VIS_RM69299.c +++ b/src/drivers/mipi/panel-VIS_RM69299.c @@ -18,7 +18,6 @@ .x_mm = 74, .y_mm = 131, }, }, - .orientation = LB_FB_ORIENTATION_NORMAL, .init = { PANEL_DCS(0xFE, 0x00, 0x15, 0x80), PANEL_DCS(0xc2, 0x08, 0x15, 0x80), diff --git a/src/include/mipi/panel.h b/src/include/mipi/panel.h index e0a1463..edb6df5 100644 --- a/src/include/mipi/panel.h +++ b/src/include/mipi/panel.h @@ -27,7 +27,6 @@ */ struct panel_serializable_data { struct edid edid; /* edid info of this panel */ - enum lb_fb_orientation orientation; /* Panel orientation */ u8 init[]; /* A packed array of panel_init_command */ }; diff --git a/src/mainboard/google/kukui/panel.h b/src/mainboard/google/kukui/panel.h index 17c1983..c5bc43e 100644 --- a/src/mainboard/google/kukui/panel.h +++ b/src/mainboard/google/kukui/panel.h @@ -11,6 +11,7 @@ struct panel_serializable_data *s; void (*power_on)(void); /* Callback to turn on panel */ void (*post_power_on)(void); /* Callback to run after panel is turned on */ + enum lb_fb_orientation orientation; }; /* Returns the panel description from given ID. */ diff --git a/src/mainboard/google/kukui/panel_anx7625.c b/src/mainboard/google/kukui/panel_anx7625.c index fb3c9b7..90a041b 100644 --- a/src/mainboard/google/kukui/panel_anx7625.c +++ b/src/mainboard/google/kukui/panel_anx7625.c @@ -13,7 +13,6 @@ #define ANX7625_I2C_BUS 4 static struct panel_serializable_data anx7625_data = { - .orientation = LB_FB_ORIENTATION_NORMAL, .init = { PANEL_END }, }; @@ -33,6 +32,7 @@ static struct panel_description anx7625_panel = { .s = &anx7625_data, + .orientation = LB_FB_ORIENTATION_NORMAL, .power_on = dummy_power_on, .post_power_on = start_anx7625, }; diff --git a/src/mainboard/google/kukui/panel_flapjack.c b/src/mainboard/google/kukui/panel_flapjack.c index 16a949d..3ad9d6a 100644 --- a/src/mainboard/google/kukui/panel_flapjack.c +++ b/src/mainboard/google/kukui/panel_flapjack.c @@ -3,10 +3,10 @@ #include "panel.h" static struct panel_description flapjack_panels[] = { - [0] = { .name = "BOE_TV101WUM_NG0", }, - [1] = { .name = "BOE_TV080WUM_NG0", }, - [2] = { .name = "INX_OTA7290D10P", }, - [3] = { .name = "AUO_NT51021D8P", }, + [0] = { .name = "BOE_TV101WUM_NG0", .orientation = LB_FB_ORIENTATION_NORMAL}, + [1] = { .name = "BOE_TV080WUM_NG0", .orientation = LB_FB_ORIENTATION_NORMAL}, + [2] = { .name = "INX_OTA7290D10P", .orientation = LB_FB_ORIENTATION_NORMAL}, + [3] = { .name = "AUO_NT51021D8P", .orientation = LB_FB_ORIENTATION_NORMAL}, }; struct panel_description *get_panel_description(int panel_id) diff --git a/src/mainboard/google/kukui/panel_kakadu.c b/src/mainboard/google/kukui/panel_kakadu.c index f01c28b..df9a92e 100644 --- a/src/mainboard/google/kukui/panel_kakadu.c +++ b/src/mainboard/google/kukui/panel_kakadu.c @@ -3,7 +3,7 @@ #include "panel.h" static struct panel_description kakadu_panels[] = { - [1] = { .name = "BOE_TV105WUM_NW0", }, + [1] = { .name = "BOE_TV105WUM_NW0", .orientation = LB_FB_ORIENTATION_LEFT_UP}, }; struct panel_description *get_panel_description(int panel_id) diff --git a/src/mainboard/google/kukui/panel_katsu.c b/src/mainboard/google/kukui/panel_katsu.c index f2a2070..eeb9573 100644 --- a/src/mainboard/google/kukui/panel_katsu.c +++ b/src/mainboard/google/kukui/panel_katsu.c @@ -3,8 +3,8 @@ #include "panel.h" static struct panel_description katsu_panels[] = { - [1] = { .name = "BOE_TV105WUM_NW0", }, - [2] = { .name = "STA_2081101QFH032011_53G", }, + [1] = { .name = "BOE_TV105WUM_NW0", .orientation = LB_FB_ORIENTATION_LEFT_UP}, + [2] = { .name = "STA_2081101QFH032011_53G", .orientation = LB_FB_ORIENTATION_LEFT_UP}, }; struct panel_description *get_panel_description(int panel_id) diff --git a/src/mainboard/google/kukui/panel_kodama.c b/src/mainboard/google/kukui/panel_kodama.c index efabfa2..35d3d91 100644 --- a/src/mainboard/google/kukui/panel_kodama.c +++ b/src/mainboard/google/kukui/panel_kodama.c @@ -3,8 +3,8 @@ #include "panel.h" static struct panel_description kodama_panels[] = { - [1] = { .name = "AUO_B101UAN08_3", }, - [2] = { .name = "BOE_TV101WUM_N53", }, + [1] = { .name = "AUO_B101UAN08_3", .orientation = LB_FB_ORIENTATION_LEFT_UP}, + [2] = { .name = "BOE_TV101WUM_N53", .orientation = LB_FB_ORIENTATION_LEFT_UP}, }; struct panel_description *get_panel_description(int panel_id) diff --git a/src/mainboard/google/kukui/panel_krane.c b/src/mainboard/google/kukui/panel_krane.c index 6228bcb..3088718 100644 --- a/src/mainboard/google/kukui/panel_krane.c +++ b/src/mainboard/google/kukui/panel_krane.c @@ -3,9 +3,10 @@ #include "panel.h" static struct panel_description krane_panels[] = { - [0] = { .name = "AUO_KD101N80_45NA", }, - [1] = { .name = "BOE_TV101WUM_NL6", }, /* Only Rev3, can be reused. */ - [11] = { .name = "BOE_TV101WUM_NL6", }, + [0] = { .name = "AUO_KD101N80_45NA", .orientation = LB_FB_ORIENTATION_LEFT_UP}, + /* [1] is only Rev3, can be reused. */ + [1] = { .name = "BOE_TV101WUM_NL6", .orientation = LB_FB_ORIENTATION_LEFT_UP}, + [11] = { .name = "BOE_TV101WUM_NL6", .orientation = LB_FB_ORIENTATION_LEFT_UP}, }; struct panel_description *get_panel_description(int panel_id) diff --git a/src/mainboard/google/kukui/panel_kukui.c b/src/mainboard/google/kukui/panel_kukui.c index ae002e6..283b641 100644 --- a/src/mainboard/google/kukui/panel_kukui.c +++ b/src/mainboard/google/kukui/panel_kukui.c @@ -25,6 +25,7 @@ static struct panel_description kukui_panel = { .name = "CMN_P097PFG_SSD2858", + .orientation = LB_FB_ORIENTATION_NORMAL, .power_on = power_on_ssd2858, }; diff --git a/src/mainboard/google/kukui/panel_ps8640.c b/src/mainboard/google/kukui/panel_ps8640.c index f169254..c4e90ea 100644 --- a/src/mainboard/google/kukui/panel_ps8640.c +++ b/src/mainboard/google/kukui/panel_ps8640.c @@ -34,12 +34,12 @@ } static struct panel_serializable_data ps8640_data = { - .orientation = LB_FB_ORIENTATION_NORMAL, .init = { PANEL_END }, }; static struct panel_description ps8640_panel = { .s = &ps8640_data, + .orientation = LB_FB_ORIENTATION_NORMAL, .power_on = dummy_power_on, }; diff --git a/src/mainboard/google/trogdor/mainboard.c b/src/mainboard/google/trogdor/mainboard.c index 4b395ba..066705e 100644 --- a/src/mainboard/google/trogdor/mainboard.c +++ b/src/mainboard/google/trogdor/mainboard.c @@ -117,7 +117,8 @@ static void display_startup(void) { - struct panel_serializable_data *panel = NULL; + struct panel_serializable_data edp_panel = {0}; + struct panel_serializable_data *panel = &edp_panel; if (!display_init_required()) { printk(BIOS_INFO, "Skipping display init.\n"); @@ -130,24 +131,18 @@ return; } else { enum dp_pll_clk_src ref_clk = SN65_SEL_19MHZ; - static struct panel_serializable_data edp_panel = { - .orientation = LB_FB_ORIENTATION_NORMAL, - }; i2c_init(QUPV3_0_SE2, I2C_SPEED_FAST); /* EDP Bridge I2C */ power_on_bridge(); mdelay(250); /* Delay for the panel to be up */ sn65dsi86_bridge_init(BRIDGE_BUS, BRIDGE_CHIP, ref_clk); - if (sn65dsi86_bridge_read_edid(BRIDGE_BUS, BRIDGE_CHIP, &edp_panel.edid) < 0) + if (sn65dsi86_bridge_read_edid(BRIDGE_BUS, BRIDGE_CHIP, &panel->edid) < 0) return; - panel = &edp_panel; } printk(BIOS_INFO, "display init!\n"); edid_set_framebuffer_bits_per_pixel(&panel->edid, 32, 0); - if (display_init(panel) == CB_SUCCESS) { - struct fb_info *info = fb_new_framebuffer_info_from_edid(&panel->edid, 0); - fb_set_orientation(info, panel->orientation); - } + if (display_init(panel) == CB_SUCCESS) + fb_new_framebuffer_info_from_edid(&panel->edid, 0); } static void mainboard_init(struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/57324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2b716aa4dae036515730c12961fdd8a9ac34753 Gerrit-Change-Number: 57324 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Fix TPM IRQ conflict with I2C4
by Selma Bensaid (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Bora Guvendik, Anil Kumar K, Tim Wawrzynczak, Bernardo Perez Priego. Selma Bensaid has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57102 ) Change subject: mb/intel/adlrvp_m: Fix TPM IRQ conflict with I2C4 ...................................................................... Patch Set 9: (1 comment) File src/mainboard/intel/adlrvp/gpio_m.c: https://review.coreboot.org/c/coreboot/+/57102/comment/6fda4ad9_76a838e7 PS8, Line 171: > "E3 :" to be consistent with the rest Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0f3885dec5a6f635254c233709090321491c739 Gerrit-Change-Number: 57102 Gerrit-PatchSet: 9 Gerrit-Owner: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:29:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbftool: Fix the bug in parsing Uefipayload with extended header
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Patrick Rudolph, Dun Tan, King Sumo. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57296 ) Change subject: util/cbftool: Fix the bug in parsing Uefipayload with extended header ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57296/comment/90a858fb_eff1beef PS3, Line 10: This issue is caused by adding FvNameGuid : in UefiPayloadEntry.fdf in EDKII. There is an ext header between header : of Fv and header of PayloadEntry in Fv with FvNameGuid. The ext header : causes the UefiPayloadEntry to be found incorrectly when parsing Fv. > Yes: […] Please mention that in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/57296 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id063efb1c8e6c7a96ec2182e87b71c7e8b7b6423 Gerrit-Change-Number: 57296 Gerrit-PatchSet: 3 Gerrit-Owner: Dun Tan <dun.tan(a)intel.com> Gerrit-Reviewer: King Sumo <kingsumos(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ray Ni <ray.ni(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Dun Tan <dun.tan(a)intel.com> Gerrit-Attention: King Sumo <kingsumos(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:27:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: King Sumo <kingsumos(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/g505s: enable the AMD Core Performance Boost (CPB) feature
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Mike Banon. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51394 ) Change subject: lenovo/g505s: enable the AMD Core Performance Boost (CPB) feature ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/51394/comment/e43bda2b_9a03b262 PS1, Line 12: the performance of Lenovo G505S laptop by up to 50% How can this be measured? -- To view, visit https://review.coreboot.org/c/coreboot/+/51394 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f64dbbf8966e2e42fb5512cacbe645bd8f0bc15 Gerrit-Change-Number: 51394 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:26:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl: Drop SGPM,RGPM and EGPM methods
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Meera Ravindranath, Subrata Banik, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57209 ) Change subject: soc/intel/adl: Drop SGPM,RGPM and EGPM methods ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57209/comment/14bc328d_4d14363e PS3, Line 7: SGPM,RGPM Please add a space after the comma. -- To view, visit https://review.coreboot.org/c/coreboot/+/57209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c7b67b5414d8c80775ab7678ce7b12181af7882 Gerrit-Change-Number: 57209 Gerrit-PatchSet: 3 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:22:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Move common Kconfig from mb Kconfig.name to Kconfig
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57314 ) Change subject: mb/intel/adlrvp: Move common Kconfig from mb Kconfig.name to Kconfig ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57314/comment/5fd2f30a_876e10f2 PS1, Line 11: selects select -- To view, visit https://review.coreboot.org/c/coreboot/+/57314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62d5ec19c3364da79ebe7287b1b3d6eb2a0efca0 Gerrit-Change-Number: 57314 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:21:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/mediatek/mt8195: Remove redundant code
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Ryan Chuang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57275 ) Change subject: vc/mediatek/mt8195: Remove redundant code ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57275/comment/6c4720be_83756812 PS1, Line 8: Please elaborate. Why redundant? Looks like disable by preprocessor macros. -- To view, visit https://review.coreboot.org/c/coreboot/+/57275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b235cbceb231898f00fce7905f596eab54ca595 Gerrit-Change-Number: 57275 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:19:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: reserve WDT reset reason for debugging
by Paul Menzel (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57270 ) Change subject: soc/mediatek: reserve WDT reset reason for debugging ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57270/comment/89e4a208_e250b0d5 PS2, Line 11: Why is `mark_watchdog_tombstone()` removed? -- To view, visit https://review.coreboot.org/c/coreboot/+/57270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5887a8312f4daab3cbd0a30fea0195670a932e52 Gerrit-Change-Number: 57270 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Sep 2021 23:18:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021