Attention is currently required from: Paul Menzel, Furquan Shaikh, Tim Wawrzynczak, Brandon Breitenstein.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56839 )
Change subject: mb/adlrvp: Add new ADL P board variant for MCHP1727
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/56839/comment/42bb31f8_d393674a
PS7, Line 41: adlrvp_p_ext_ec
Actually if I am reading this code correctly, is the correct overridetree.cb being selected?
The OVERRIDE_DEVICETREE is defined as
`variants/$(CONFIG_VARIANT_DIR)/overridetree.cb`
and right here VARIANT_DIR is set as adlrvp_p_ext_ec, so shouldn't the overridetree.cb used be:
`variants/adlrvp_p_ext_ec/overridetree.cb`
while below it's
`variants/adlrvp_p_mchp/overridetree.cb`
--
To view, visit https://review.coreboot.org/c/coreboot/+/56839
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169
Gerrit-Change-Number: 56839
Gerrit-PatchSet: 7
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Comment-Date: Wed, 01 Sep 2021 22:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Nick Vaccaro, Zhuohao Lee, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table
......................................................................
Patch Set 11:
(1 comment)
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/6d77b233_5ca1c362
PS11, Line 116:
To be safest, it's probably best to loop through the children and verify they all have a `chip_info` that points to `&drivers_intel_pmc_mux_conn_ops`
--
To view, visit https://review.coreboot.org/c/coreboot/+/57069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice732be2fa634dbf31ec620552b383c4a5b41451
Gerrit-Change-Number: 57069
Gerrit-PatchSet: 11
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 01 Sep 2021 21:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Nick Vaccaro, Zhuohao Lee, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
looking pretty nice ! 😊 I would just split out the drivers/intel/pmc_mux changes into a separate CL
--
To view, visit https://review.coreboot.org/c/coreboot/+/57069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice732be2fa634dbf31ec620552b383c4a5b41451
Gerrit-Change-Number: 57069
Gerrit-PatchSet: 11
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 01 Sep 2021 21:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, Patrick Rudolph, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57096 )
Change subject: tpch: Introduce new thermal control mechanism for pch device
......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS3:
Looking nice ! 😊
File src/drivers/intel/dptf/Kconfig:
https://review.coreboot.org/c/coreboot/+/57096/comment/882ab49f_b429693b
PS3, Line 12: help
also:
`depends on PMC_IPC_ACPI_INTERFACE`
https://review.coreboot.org/c/coreboot/+/57096/comment/bbe38d0e_1c023534
PS3, Line 13: tpch
dptf
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/57096/comment/ff4bec90_33a39602
PS3, Line 212: acpigen_write_package(0);
A 0-element package? how odd... but I think you still need to end the package too, i.e.:
`acpigen_write_package_end();`
https://review.coreboot.org/c/coreboot/+/57096/comment/cdf563b1_92c2989f
PS3, Line 220: {
: acpigen_write_scope("\\_SB");
: acpigen_write_device("TPCH");
Does the scope of this device matter? Can it just live under the DPTF device like all the others (except TCPU which cannot)? It looks like the kernel driver just matches on the `_HID` so I think it will work
--
To view, visit https://review.coreboot.org/c/coreboot/+/57096
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I035d2844b9ba6a9532ae006fc1c43e34cb94328a
Gerrit-Change-Number: 57096
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 01 Sep 2021 21:20:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Furquan Shaikh, Brandon Breitenstein.
Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56839 )
Change subject: mb/adlrvp: Add new ADL P board variant for MCHP1727
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/intel/adlrvp/variants/adlrvp_m_mchp/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56839/comment/83e896f2_5569789d
PS6, Line 11:
> realized I had pushed m instead of p file fixed that and fixed the extra space
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56839
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169
Gerrit-Change-Number: 56839
Gerrit-PatchSet: 7
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Comment-Date: Wed, 01 Sep 2021 21:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Furquan Shaikh, Brandon Breitenstein.
Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56839 )
Change subject: mb/adlrvp: Add new ADL P board variant for MCHP1727
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/intel/adlrvp/variants/adlrvp_m_mchp/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56839/comment/c20edc5e_414bfcf6
PS6, Line 11:
> nit: extra blank line
realized I had pushed m instead of p file fixed that and fixed the extra space
--
To view, visit https://review.coreboot.org/c/coreboot/+/56839
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169
Gerrit-Change-Number: 56839
Gerrit-PatchSet: 7
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Comment-Date: Wed, 01 Sep 2021 21:19:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Furquan Shaikh, Tim Wawrzynczak, Brandon Breitenstein.
Hello build bot (Jenkins), Vijay P Hiremath, Brandon Breitenstein, Tim Wawrzynczak, Angel Pons, Furquan Shaikh, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56839
to look at the new patch set (#7).
Change subject: mb/adlrvp: Add new ADL P board variant for MCHP1727
......................................................................
mb/adlrvp: Add new ADL P board variant for MCHP1727
Add new board variant to enable MCHP1727 Modular EC Card on RVP
BUG=b:179214042
BRANCH=none
TEST=emerge brya and verify that adlrvp_p_mchp images boot
Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169
Signed-off-by: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com>
---
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/adlrvp/Kconfig.name
A src/mainboard/intel/adlrvp/variants/adlrvp_p_mchp/overridetree.cb
3 files changed, 46 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/56839/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/56839
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169
Gerrit-Change-Number: 56839
Gerrit-PatchSet: 7
Gerrit-Owner: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Vijay P Hiremath <vijay.p.hiremath(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-MessageType: newpatchset