Attention is currently required from: V Sowmya.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54648 )
Change subject: mb/intel/shadowmountain: Enable SaGv support
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54648
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15203920546363466eef567136821b59dda763b0
Gerrit-Change-Number: 54648
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:35:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: V Sowmya.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54648 )
Change subject: mb/intel/shadowmountain: Enable SaGv support
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/54648
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15203920546363466eef567136821b59dda763b0
Gerrit-Change-Number: 54648
Gerrit-PatchSet: 2
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:35:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: amersel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57249 )
Change subject: [wip]mb/dell/optiplex_7010: add Dell Optiplex 7010
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
The OptiPlex 9010 and OptiPlex 7010 seem to use the same board. Have you tried using the existing OptiPlex 9010 code on your board?
--
To view, visit https://review.coreboot.org/c/coreboot/+/57249
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40d1bd4568c0823a266aabc3803e3e2cd53f23c1
Gerrit-Change-Number: 57249
Gerrit-PatchSet: 3
Gerrit-Owner: amersel
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: amersel
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:35:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Swift Geek (Sebastian Grzywna).
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57307 )
Change subject: mb/asrock/e350m1: Enable USB on mPCIe
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Do you have a lspci log? I'd like to see what exactly these devices are.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ee7e3679c9cd87b81f955c68ec89db1dda30aec
Gerrit-Change-Number: 57307
Gerrit-PatchSet: 1
Gerrit-Owner: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com>
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:31:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57391 )
Change subject: mb/google: Unify all variants to start with "-> "
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/57391/comment/a764d7e1_5cdc7307
PS1, Line 69: bool "-> Nightfury (Samsung Galaxy Chromebook 2)"
> Hmmm, the market names weren't here before. […]
I guess not, seems like CB:57392 would be a better place to add this info.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab9e6207fff5a7d2f6d76e5ca33eeaca721a224f
Gerrit-Change-Number: 57391
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:29:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57390 )
Change subject: mb/google: Add board name comments for each board
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/57390
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib941318842136212727f56fc6130381c5c9cd55b
Gerrit-Change-Number: 57390
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:28:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57391 )
Change subject: mb/google: Unify all variants to start with "-> "
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/57391/comment/e782564f_35e62c3a
PS1, Line 69: bool "-> Nightfury (Samsung Galaxy Chromebook 2)"
Hmmm, the market names weren't here before. Is this intentional?
--
To view, visit https://review.coreboot.org/c/coreboot/+/57391
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab9e6207fff5a7d2f6d76e5ca33eeaca721a224f
Gerrit-Change-Number: 57391
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:28:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57390 )
Change subject: mb/google: Add board name comments for each board
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/butterfly/Kconfig.name:
PS1:
> I wouldn't add a comment to boards without variants.
Hmmm, I see that the follow-up adds arrows to the Kconfig booleans.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57390
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib941318842136212727f56fc6130381c5c9cd55b
Gerrit-Change-Number: 57390
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:26:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57390 )
Change subject: mb/google: Add board name comments for each board
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/butterfly/Kconfig.name:
PS1:
I wouldn't add a comment to boards without variants.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57390
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib941318842136212727f56fc6130381c5c9cd55b
Gerrit-Change-Number: 57390
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:25:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment