coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: soc/alderlake: Fix DDR5 boot hang due to incorrect array size
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Tim Wawrzynczak, Meera Ravindranath, Subrata Banik, Ronak Kanabar, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52730 ) Change subject: soc/alderlake: Fix DDR5 boot hang due to incorrect array size ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52730/comment/6b1e7146_5c99da2b PS1, Line 10: of MRC channels. Why? `struct spd_block` is independent of the interface used by MRC/FSP. File src/include/spd_bin.h: https://review.coreboot.org/c/coreboot/+/52730/comment/0b7f6f06_59f43f04 PS1, Line 8: #include <soc/meminit.h> Uh, this is backwards. Common code shouldn't depend on SoC-specific headers. -- To view, visit https://review.coreboot.org/c/coreboot/+/52730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5e9c58f255bdf86a68ce90a4f853bf4e7c7ccfe Gerrit-Change-Number: 52730 Gerrit-PatchSet: 1 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 05 Sep 2021 16:19:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/system76/darp7: Add System76 Darter Pro 7
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Tim Crawford, Jeremy Soller. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52349 ) Change subject: mb/system76/darp7: Add System76 Darter Pro 7 ...................................................................... Patch Set 12: Code-Review+1 (7 comments) File src/mainboard/system76/darp7/Kconfig: https://review.coreboot.org/c/coreboot/+/52349/comment/22923683_4ef54b11 PS12, Line 34: config MAINBOARD_SMBIOS_PRODUCT_NAME : string : default "Darter Pro" : : config MAINBOARD_VERSION : string : default "darp7" : : config CBFS_SIZE : default 0xA00000 : : config CONSOLE_POST : bool : default y : : config DIMM_SPD_SIZE : int : default 512 : : config POST_DEVICE : bool : default n : : config UART_FOR_CONSOLE : int : default 2 It shouldn't be necessary to specify any types. File src/mainboard/system76/darp7/devicetree.cb: https://review.coreboot.org/c/coreboot/+/52349/comment/ebc0e362_04bfab72 PS12, Line 3: .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, Needs an update after CB:56967 https://review.coreboot.org/c/coreboot/+/52349/comment/0954e1e5_630ab7ec PS12, Line 126: register "HybridStorageMode" = "0" I think this is about Optane https://review.coreboot.org/c/coreboot/+/52349/comment/ef5db83b_b9d4d441 PS12, Line 285: # TODO: should this be GPIO_LANRTD3 or LAN_PLT_RST# ? Most likely the former. File src/mainboard/system76/darp7/dsdt.asl: https://review.coreboot.org/c/coreboot/+/52349/comment/ca14bc6d_9107b55a PS12, Line 10: /* OEM revision */ I don't think it is. I'd drop the comment. File src/mainboard/system76/darp7/gpio.h: https://review.coreboot.org/c/coreboot/+/52349/comment/fa55cb4e_c991daf9 PS12, Line 6: #ifndef __ACPI__ Is this guard really needed? File src/mainboard/system76/darp7/romstage.c: https://review.coreboot.org/c/coreboot/+/52349/comment/d9031164_ae6f6fff PS12, Line 11: true Is this intentionally enabled? -- To view, visit https://review.coreboot.org/c/coreboot/+/52349 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93 Gerrit-Change-Number: 52349 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Sun, 05 Sep 2021 16:13:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl: Drop SGPM, RGPM and EGPM methods
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Maulik V Vaghela, Paul Menzel, Meera Ravindranath, Subrata Banik, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57209 ) Change subject: soc/intel/adl: Drop SGPM, RGPM and EGPM methods ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/57209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c7b67b5414d8c80775ab7678ce7b12181af7882 Gerrit-Change-Number: 57209 Gerrit-PatchSet: 4 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 05 Sep 2021 16:03:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/kblrvp: Disable I2C #4 and #5 on PCH-H
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Subrata Banik, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57226 ) Change subject: mb/intel/kblrvp: Disable I2C #4 and #5 on PCH-H ...................................................................... Patch Set 2: (1 comment) File src/mainboard/intel/kblrvp/variants/rvp11/overridetree.cb: https://review.coreboot.org/c/coreboot/+/57226/comment/9143bc60_61c47ca5 PS1, Line 108: device pci 19.2 off end # I2C #4 > > > This needs to be in the overridetree because the devicetree enables it. […] I went with a more detailed explanation of what this commit does. -- To view, visit https://review.coreboot.org/c/coreboot/+/57226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56f34fa2004993d2123ccd5c1008fd71682ec2bd Gerrit-Change-Number: 57226 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 05 Sep 2021 16:00:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/kblrvp: Disable I2C #4 and #5 on PCH-H
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Angel Pons, Subrata Banik, Michael Niewöhner. Hello build bot (Jenkins), Nico Huber, Subrata Banik, Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57226 to look at the new patch set (#2). Change subject: mb/intel/kblrvp: Disable I2C #4 and #5 on PCH-H ...................................................................... mb/intel/kblrvp: Disable I2C #4 and #5 on PCH-H The I2C #4 and I2C #5 devices do not exist on PCH-H. Disable the devices using the PCH-H variants' overridetrees (the base devicetree enables I2C #4), set the `SerialIoDevMode` entries to `PchSerialIoDisabled` and drop inapplicable I2C #4 voltage settings. Change-Id: I56f34fa2004993d2123ccd5c1008fd71682ec2bd Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/intel/kblrvp/variants/rvp11/overridetree.cb M src/mainboard/intel/kblrvp/variants/rvp8/overridetree.cb 2 files changed, 3 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/57226/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56f34fa2004993d2123ccd5c1008fd71682ec2bd Gerrit-Change-Number: 57226 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/amd/pi/hudson: drop HUDSON_UART option and corresponding code
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Martin Roth, Marshall Dawson, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56785 ) Change subject: sb/amd/pi/hudson: drop HUDSON_UART option and corresponding code ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f462d1f83a0f1ba851329ebebb1f3263267fdc6 Gerrit-Change-Number: 56785 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 05 Sep 2021 15:52:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] autoport: support generating BDW mainboard files for HSW
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Iru Cai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51917 ) Change subject: [WIP] autoport: support generating BDW mainboard files for HSW ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: FWIW, I'm trying to unify Haswell and Broadwell coreboot code so that stuff like this isn't needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/51917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie00ec26d62739b3aed598ad8f80952e631925668 Gerrit-Change-Number: 51917 Gerrit-PatchSet: 7 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Comment-Date: Sun, 05 Sep 2021 15:49:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/mp_init.c: Fix building with no smihandler
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54754 ) Change subject: cpu/x86/mp_init.c: Fix building with no smihandler ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/54754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73fee3cf26c0e37cca03299c6730f7b4f1ef6685 Gerrit-Change-Number: 54754 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 05 Sep 2021 15:31:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile: Defer normalizing configuration for reproducible builds
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Alexander Couzens. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52292 ) Change subject: Makefile: Defer normalizing configuration for reproducible builds ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7afd32bd120e5405e65825144b0c30d69931a22 Gerrit-Change-Number: 52292 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 05 Sep 2021 15:30:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: MAINTAINERS: Add myself
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52743 ) Change subject: MAINTAINERS: Add myself ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfa877fc328d64be4de372fb7f4401717158ed9e Gerrit-Change-Number: 52743 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Sun, 05 Sep 2021 15:30:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021