coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: util/liveiso: Make neovim the default editor
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Felix Singer, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57393 ) Change subject: util/liveiso: Make neovim the default editor ...................................................................... Patch Set 6: (1 comment) File util/liveiso/common.nix: https://review.coreboot.org/c/coreboot/+/57393/comment/6ba50c4d_ef7279f3 PS6, Line 19: Tell the Nix evaluator to garbage collect more aggressively. : # This is desirable in memory-constrained environments that don't : # (yet) have swap set up. : environment.variables.GC_INITIAL_HEAP_SIZE = "1M"; Why did this go poof? -- To view, visit https://review.coreboot.org/c/coreboot/+/57393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9345a6e32f3035565e55e50579c97121b4987d83 Gerrit-Change-Number: 57393 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sun, 05 Sep 2021 14:18:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Document USB mapping in devicetree
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Rob Barnes, Karthik Ramasubramanian. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56725 ) Change subject: mb/google/guybrush: Document USB mapping in devicetree ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56725/comment/d71244c7_b881ccc2 PS1, Line 10: Fix inverted mapping in : drivers/usb/acpi. The commit summary made me believe this commit just added comments, and that there wouldn't be any code changes in it. And then I noticed this. I'd greatly appreciate if you could make a separate patch to fix the mapping. -- To view, visit https://review.coreboot.org/c/coreboot/+/56725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14cbb6af021bb27c89aa82456722f21aa09617be Gerrit-Change-Number: 56725 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sun, 05 Sep 2021 14:17:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl: Move USB4 hotplug Kconfig to common
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, Subrata Banik, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57124 ) Change subject: soc/intel/adl: Move USB4 hotplug Kconfig to common ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7c359a0e255c43c2732f6cbe287bc7da14a46e3 Gerrit-Change-Number: 57124 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 05 Sep 2021 14:07:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tgl: Enable USB4 resources based on common Kconfig
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57125 ) Change subject: soc/intel/tgl: Enable USB4 resources based on common Kconfig ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57125/comment/e4ae0ac7_ebdf952b PS5, Line 20: CB:51460 As this is merged, use the commit hash? commit 8d11cdc6fa (the `commit` part is important because it makes Gerrit display a link) File src/soc/intel/tigerlake/Kconfig: https://review.coreboot.org/c/coreboot/+/57125/comment/b2bfe51c_f3505350 PS5, Line 296: int It shouldn't be necessary to repeat the types here. -- To view, visit https://review.coreboot.org/c/coreboot/+/57125 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25ec3f74ebd5727fa4b13f5a3b11050f77ecb008 Gerrit-Change-Number: 57125 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 05 Sep 2021 14:06:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sconfig: Ensure at least one `device` node below each `chip`
by Angel Pons (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Nico Huber, Martin Roth, Arthur Heymans, Kevin Keijzer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51119 ) Change subject: sconfig: Ensure at least one `device` node below each `chip` ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/51119/comment/b61b62fb_c2cb0573 PS4, Line 16: chipchidren_dev missed an `l`: chipchi*l*dren_dev https://review.coreboot.org/c/coreboot/+/51119/comment/3b92f8eb_4539e524 PS4, Line 18: chipchidren missed an `l`: chipchi*l*dren -- To view, visit https://review.coreboot.org/c/coreboot/+/51119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54830bc1fc7d00a0605f3fe4d36a83ef57ef3312 Gerrit-Change-Number: 51119 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Comment-Date: Sun, 05 Sep 2021 14:01:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sconfig: Ensure at least one `device` node below each `chip`
by Nico Huber (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Nico Huber, Martin Roth, Arthur Heymans, Kevin Keijzer. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Kevin Keijzer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/51119 to look at the new patch set (#4). Change subject: sconfig: Ensure at least one `device` node below each `chip` ...................................................................... sconfig: Ensure at least one `device` node below each `chip` Even though `device` entries are children of `chip` entries in the devicetree source format, the chips in the translated C structures are only hooked up to device nodes. Hence, any chip with all its settings will be silently dropped by sconfig if there is no device node below it. Let's adapt the parser to ensure that there is at least one `device` entry. The intermediate `chipchidren_dev` rule applies until the first `device` entry is found, then everything continues as before with the `chipchidren` rule. Change-Id: I54830bc1fc7d00a0605f3fe4d36a83ef57ef3312 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M util/sconfig/sconfig.tab.c_shipped M util/sconfig/sconfig.tab.h_shipped M util/sconfig/sconfig.y 3 files changed, 160 insertions(+), 147 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/51119/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/51119 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54830bc1fc7d00a0605f3fe4d36a83ef57ef3312 Gerrit-Change-Number: 51119 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-MessageType: newpatchset

1 0

Change in libgfxinit[master]: dp aux: Add TODO and pre-condition for I2C writes
by Nico Huber (Code Review) 05 Sep '21

05 Sep '21

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/libgfxinit/+/52824 ) Change subject: dp aux: Add TODO and pre-condition for I2C writes ...................................................................... Abandoned Problem solved. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/52824 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: If7566fc7b701c8a36d9e8a0af5beb7a84a558ee3 Gerrit-Change-Number: 52824 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in libgfxinit[master]: gfxtest: Silence warning about color-component order
by Nico Huber (Code Review) 05 Sep '21

05 Sep '21

Nico Huber has abandoned this change. ( https://review.coreboot.org/c/libgfxinit/+/55425 ) Change subject: gfxtest: Silence warning about color-component order ...................................................................... Abandoned Warning got disabled. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/55425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I7ffec27fef927846045e20b438a4ff6f44b23298 Gerrit-Change-Number: 55425 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/cannonlake: Clear RTC_BATTERY_DEAD
by Nico Huber (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56668 ) Change subject: soc/intel/cannonlake: Clear RTC_BATTERY_DEAD ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56668/comment/aabe0d15_a2002a1f PS1, Line 11: RTC_BATTERY_DEAD : is set Why is that? Is it really always like this after flashing? or is this an `if`? https://review.coreboot.org/c/coreboot/+/56668/comment/705d770a_4d70a7e7 PS1, Line 13: which clears RTC_BATTERY_DEAD towards the end of its : execution Is this FSP's only reaction? Doesn't it need to know the failure state for anything else? -- To view, visit https://review.coreboot.org/c/coreboot/+/56668 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54f519edb9f4295f83a581db9cb43f5ae5d0d483 Gerrit-Change-Number: 56668 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 05 Sep 2021 11:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lib/edid_fill_fb: Make framebuffer orientation to be configurable
by Nico Huber (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: shkim, Paul Menzel, SH Kim, Julius Werner, Yu-Ping Wu, Karthik Ramasubramanian. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57327 ) Change subject: lib/edid_fill_fb: Make framebuffer orientation to be configurable ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: I agree the existing API was better. I think we can have two mechanisms (the direct, sane, existing API) and the weak override function side by side or better modify the existing fb_info like Julius suggests. That you had to add a lot of code to Kukui just to keep the existing functionality shows that the existing API makes sense. > I think the real problem here is that the FSP graphics driver is too far removed from the mainboard and doesn't allow to directly pass anything in or out. The cleanest solution for that would be to fix it so that the mainboard init code actually calls something to trigger display initialization and then gets something back (e.g. a struct fb_info pointer). It's basically impossible without properly designing FSP first. I have my reasons when I keep repeating that FSP is not coreboot compatible. But it's also not necessary. It's much easier to write open-source code (there are no secrets in display modesetting on x86, or at least they are abstracted away (AMD's ATOMBIOS)). > If we don't want to do that, because it's a bit too big of a change maybe, you could also do something like have the FSP graphics driver store the fb_info pointer in a global and provide a function for the mainboard code to retrieve it and add additional info to it. That's a nice thought. We could give the mainboard code access to the registered fb_info structs. I suppose mainboard code would know that it's only a single entry, so to simplify things an access function for the first list entry might be enough, e.g.: struct lb_framebufer *lb_get_first_framebuffer(void) { if (list.next) return &list.next->fb; return NULL; } The mainboard code could then override whatever it likes and we wouldn't need any specific override mechanism: struct lb_framebuffer *const fb = lb_get_first_framebuffer(); if (fb) fb.orientation = ... The only obstacle might be to find the right time in coreboot's flow to do this. I guess we can generally expect graphics init to be ready after the device initialization phase. -- To view, visit https://review.coreboot.org/c/coreboot/+/57327 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice7f7ab66e40d19c76fbf5876e7d4d3e3b2088fa Gerrit-Change-Number: 57327 Gerrit-PatchSet: 4 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: shkim <sh_.kim(a)samsung.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sun, 05 Sep 2021 11:07:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: shkim <sh_.kim(a)samsung.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021