coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS
by Furquan Shaikh (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Sunwei Li, Paul Menzel, Weimin Wu, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57105 ) Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS ...................................................................... Patch Set 9: Code-Review+1 (1 comment) Patchset: PS9: Defer to Karthik for +2. -- To view, visit https://review.coreboot.org/c/coreboot/+/57105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac09663b095e758f1bc0cfaf7adb6e84d203788a Gerrit-Change-Number: 57105 Gerrit-PatchSet: 9 Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sun, 05 Sep 2021 07:29:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Clear RTC_BATTERY_DEAD
by Furquan Shaikh (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56617 ) Change subject: soc/intel/alderlake: Clear RTC_BATTERY_DEAD ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/alderlake/pmutil.c: https://review.coreboot.org/c/coreboot/+/56617/comment/edd2c212_baa5c399 PS1, Line 188: soc_get_rtc_failed > Done This series looks okay to me. I am wondering if there is scope for us to simplify things somewhat. Currently, there are two paths in coreboot: 1. verstage: Checks if CMOS failed (and clears failed flag). If yes, then it calls cmos_init. 2. ramstage: Checks if CMOS failed (and clears failed flag). If yes, then it calls cmos_check_update_date and cmos_init. Should this instead be such that: 1. bootblock checks for CMOS failed and takes all appropriate steps to fix that and clears RTC failed flag. 2. verstage wouldn't check for CMOS failure at all. Instead it has its own checksum that it does to see if VBNV contents are valid. If not, it restores from backup (This checksum and restore is already done in `read_vbnv_cmos()`. 3. ramstage doesn't need to do anything special. With this, bootblock always inits CMOS correctly and this doesn't need to be handled in different stages. Thoughts? (Also, the same needs to be aligned on AMD platforms as well). -- To view, visit https://review.coreboot.org/c/coreboot/+/56617 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dc21c19ea8ce561e9655e189ec26aba7a07967e Gerrit-Change-Number: 56617 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 05 Sep 2021 07:19:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: elogtool: add "add" command
by Furquan Shaikh (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Ricardo Quesada, Jack Rosenthal. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57397 ) Change subject: elogtool: add "add" command ...................................................................... Patch Set 1: (8 comments) File util/cbfstool/elogtool.c: https://review.coreboot.org/c/coreboot/+/57397/comment/0e935d64_743aa5b4 PS1, Line 155: offset = sizeof(struct elog_header); : data = buffer_get(buf); : : /* Point to the first event */ : event = data + offset; : : while (offset < bytes_to_shrink) { : assert(!(event->type == ELOG_TYPE_EOL || event->length == 0) && : "Unexpected premature end of buffer"); : offset += event->length; : event = elog_get_next_event(event); : } : cleared = offset - sizeof(struct elog_header); : remaining = buffer_size(buf) - offset; : : /* Overlapping copy */ : memmove(data + hdr_size, data + hdr_size + cleared, remaining); : memset(data + hdr_size + remaining, ELOG_TYPE_EOL, cleared); Use of buffer operations should get rid of some of the math: ``` size_t cleared = 0; struct buffer rb, *r_iter = &rb; struct buffer wb, *w_iter = &wb; buffer_clone(r_iter, buf); buffer_clone(w_iter, buf); while (cleared < bytes_to_shrink) { assert(buffer_size(r_iter) > sizeof(struct event_header)); event = buffer_get(r_iter); assert(event->type != ELOG_TYPE_EOL && event->length > 0 && event->length <= buffer_size(r_iter)); buffer_seek(r_iter, event->length); cleared += event->length; } memmove(buffer_get(w_iter), buffer_get(r_iter), buffer_size(r_iter)); buffer_seek(w_iter, buffer_size(r_iter)); memset(buffer_get(w_iter), ELOG_TYPE_EOL, buffer_size(w_iter)); if (!eventlog_init_event(buffer_get(w_iter), ELOG_TYPE_LOG_CLEAR, cleared, sizeof(cleared)) return ELOGTOOL_EXIT_NOT_ENOUGH_BUFFER_SPACE; *out_offset = next_available_event_offset(w_iter); return ELOGTOOL_EXIT_SUCCESS; ``` https://review.coreboot.org/c/coreboot/+/57397/comment/6f72ddc0_8001629d PS1, Line 247: nit: The usage() function above prints out the invoked name as well. I think this should too for consistency and also how typically usage functions are written. https://review.coreboot.org/c/coreboot/+/57397/comment/17639ef6_0e64b250 PS1, Line 290: can Did you mean cannot? https://review.coreboot.org/c/coreboot/+/57397/comment/9c77f624_a7f137a4 PS1, Line 310: int size_t https://review.coreboot.org/c/coreboot/+/57397/comment/b4bc41ae_71fb9382 PS1, Line 312: int size_t https://review.coreboot.org/c/coreboot/+/57397/comment/fc33d818_09fdad8c PS1, Line 313: int size_t https://review.coreboot.org/c/coreboot/+/57397/comment/f40535ea_041b8814 PS1, Line 314: int size_t https://review.coreboot.org/c/coreboot/+/57397/comment/d4f1320c_ce25a996 PS1, Line 323: As commented on https://review.coreboot.org/c/coreboot/+/57395/1/util/cbfstool/elogtool.c#1…, I think we can seek past the header here to keep things simpler for rest of the functions. ``` buffer_clone(&copy, b); buffer_seek(&copy, sizeof((struct elog_header)); offset = next_available_event_offset(&copy); if (offset > threshold) { ret = shrink_buffer(&copy, buffer_size(&copy) - threshold, &offset); if (ret ...) ... } buffer_seek(&copy, offset); ... ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/57397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6fdf4f951565f842d1bff52173811b52f617f66 Gerrit-Change-Number: 57397 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ricardo Quesada <ricardoq(a)google.com> Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org> Gerrit-Comment-Date: Sun, 05 Sep 2021 06:50:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl: Move USB4 hotplug Kconfig to common
by Furquan Shaikh (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Subrata Banik, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57124 ) Change subject: soc/intel/adl: Move USB4 hotplug Kconfig to common ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > needs a rebase Done. -- To view, visit https://review.coreboot.org/c/coreboot/+/57124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7c359a0e255c43c2732f6cbe287bc7da14a46e3 Gerrit-Change-Number: 57124 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 05 Sep 2021 04:38:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl: Move USB4 hotplug Kconfig to common
by Furquan Shaikh (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Subrata Banik, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Subrata Banik, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57124 to look at the new patch set (#5). Change subject: soc/intel/adl: Move USB4 hotplug Kconfig to common ...................................................................... soc/intel/adl: Move USB4 hotplug Kconfig to common This change adds a new Kconfig `SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES` that can be selected by mainboard to reserve hotplug resources for USB4 at the SoC level. `ADL_ENABLE_USB4_PCIE_RESOURCES` is dropped from soc/intel/alderlake and instead the newly added Kconfig is now used. This new Kconfig is added so that the same config can be used across different platforms. In following changes, this Kconfig is utilized by TGL as well. Change-Id: Id7c359a0e255c43c2732f6cbe287bc7da14a46e3 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/intel/adlrvp/Kconfig M src/soc/intel/alderlake/Kconfig M src/soc/intel/common/block/usb4/Kconfig 4 files changed, 14 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/57124/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/57124 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7c359a0e255c43c2732f6cbe287bc7da14a46e3 Gerrit-Change-Number: 57124 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/leafhill,minnow3: remove ADD_FSP_BINARIES config override
by Martin Roth (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57346 ) Change subject: mb/intel/leafhill,minnow3: remove ADD_FSP_BINARIES config override ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > that should work perfectly fine with the clutter here. It looks like the […] Felix, that sounds like a good plan. Let's make it overridable at the FSP level. -- To view, visit https://review.coreboot.org/c/coreboot/+/57346 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23439f3134eef9460625addbff7efd64c5f65ae5 Gerrit-Change-Number: 57346 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 05 Sep 2021 01:16:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: add warning when ADD_FSP_BINARIES isn't selected
by Nico Huber (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Andrey Petrov, Patrick Rudolph, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57368 ) Change subject: drivers/intel/fsp2_0: add warning when ADD_FSP_BINARIES isn't selected ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/drivers/intel/fsp2_0/Makefile.inc: https://review.coreboot.org/c/coreboot/+/57368/comment/61eef637_007a8982 PS1, Line 121: likely won't boot\n" : printf "successfully I guess we know for sure that it won't boot without the blobs, so how about: [...] and will not boot unless they are added later. -- To view, visit https://review.coreboot.org/c/coreboot/+/57368 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6efc184ecc4059818474937fd31574f703c9bdc6 Gerrit-Change-Number: 57368 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 04 Sep 2021 22:49:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp/Makefile: error out when FSP files aren't specified
by Nico Huber (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Furquan Shaikh, Andrey Petrov, Patrick Rudolph, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57219 ) Change subject: drivers/intel/fsp/Makefile: error out when FSP files aren't specified ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57219 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5f2d75d066f0b4e491e9c8420b7a0cbd4ba9e28 Gerrit-Change-Number: 57219 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 04 Sep 2021 22:47:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/leafhill,minnow3: remove FSP_M_CBFS and FSP_S_CBFS override
by Nico Huber (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57350 ) Change subject: mb/intel/leafhill,minnow3: remove FSP_M_CBFS and FSP_S_CBFS override ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53922786382a2e7d29b3df560a1998f41e1d2ea8 Gerrit-Change-Number: 57350 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 04 Sep 2021 22:43:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/leafhill,minnow3: remove FSP_M_FILE and FSP_S_FILE override
by Nico Huber (Code Review) 05 Sep '21

05 Sep '21

Attention is currently required from: Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57347 ) Change subject: mb/intel/leafhill,minnow3: remove FSP_M_FILE and FSP_S_FILE override ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/57347 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20c8cebea8327d59f0f33d05b824a74bf2121f4b Gerrit-Change-Number: 57347 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 04 Sep 2021 22:43:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021