Attention is currently required from: Andrey Petrov, Patrick Rudolph, Felix Held.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57368 )
Change subject: drivers/intel/fsp2_0: add warning when ADD_FSP_BINARIES isn't selected
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/57368/comment/61eef637_007a8982
PS1, Line 121: likely won't boot\n"
: printf "successfully
I guess we know for sure that it won't boot without the blobs, so how about:
[...] and will not boot unless they are added later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6efc184ecc4059818474937fd31574f703c9bdc6
Gerrit-Change-Number: 57368
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 04 Sep 2021 22:49:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment