Attention is currently required from: Henry Sun, Weimin Wu, Zhi7 Li.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56804 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56804/comment/ceab3dc6_2ba55c68
PS3, Line 9: Refer to https://review.coreboot.org/c/coreboot/+/55744.
Please use
> commit df520855 (soc/intel/jsl: Add disable_external_bypass_vr config)
as the git tools operate with these hashes.
https://review.coreboot.org/c/coreboot/+/56804/comment/b48f041d_51c49d01
PS3, Line 15: by powerd_dbus_suspend
This fits on one line.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 3
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:50:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Paul Menzel, Paul F Yang, Karthik Ramasubramanian.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54673 )
Change subject: mb/google/dedede/var/galtic: Add charger throttling function
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54673/comment/b78b8201_49a585e9
PS5, Line 10:
> Please add that to the commit message. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/54673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e1849551ff051bca591f19f9e40da4c89ab74e7
Gerrit-Change-Number: 54673
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul F Yang <paul.f.yang(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul F Yang <paul.f.yang(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Paul F Yang, Karthik Ramasubramanian.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54673 )
Change subject: mb/google/dedede/var/galtic: Add charger throttling function
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS5:
> The code looks good, but I suggest to give precise current number for better understanding, like thi […]
ok understand
--
To view, visit https://review.coreboot.org/c/coreboot/+/54673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e1849551ff051bca591f19f9e40da4c89ab74e7
Gerrit-Change-Number: 54673
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul F Yang <paul.f.yang(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul F Yang <paul.f.yang(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:46:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul F Yang <paul.f.yang(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Joey Peng, Marco Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56380/comment/bec2be1d_9afd8436
PS4, Line 14:
> Please add a Fixes: tag, which commit this improves/fixes.
Is that commit 3b879f46b49b756b4f6e851d97677a821e11ce1d?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Gerrit-Change-Number: 56380
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Marco Chen <marcochen(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Marco Chen <marcochen(a)chromium.org>
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:46:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Joey Peng, Marco Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56380/comment/d0d83d59_fc00f956
PS4, Line 2: joey.peng
Please use Joey Peng.
https://review.coreboot.org/c/coreboot/+/56380/comment/8262c1a5_eaf58d5d
PS4, Line 14:
Please add a Fixes: tag, which commit this improves/fixes.
https://review.coreboot.org/c/coreboot/+/56380/comment/48dfb3ee_33108696
PS4, Line 16: TEST=Build coreboot and check that device works
Did the touchpad work before that change?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Gerrit-Change-Number: 56380
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Marco Chen <marcochen(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Marco Chen <marcochen(a)chromium.org>
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:44:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Weimin Wu.
Zhi7 Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56804 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
......................................................................
Patch Set 3:
(5 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/56804/comment/cd62ca16_92429b98
PS1, Line 7: test only
> mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
Done
https://review.coreboot.org/c/coreboot/+/56804/comment/c2e1675e_4b27bfeb
PS1, Line 9: test for anpec compatibility
> Refer to https://review.coreboot.org/c/coreboot/+/55744. […]
Done
https://review.coreboot.org/c/coreboot/+/56804/comment/f448c919_747df26d
PS1, Line 11: None
> b:190727416
Done
https://review.coreboot.org/c/coreboot/+/56804/comment/f6e5c4e2_94a819e7
PS1, Line 13: anpec compatibility
> enter S0ix and resume normally […]
Done
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56804/comment/ebf28a9a_2e373fd4
PS1, Line 1: #include <baseboard/variants.h>
> pls add SPDX identifier at top of file, like this: […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 3
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:44:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Joey Peng, Paul Menzel, Marco Chen.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56380/comment/0e4b10f9_4d92dc72
PS4, Line 153: register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
Have a question in the issue tracker to check whether this change will impact current Elan touchscreen chip or not (instead of 3915N)?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Gerrit-Change-Number: 56380
Gerrit-PatchSet: 4
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Marco Chen <marcochen(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Marco Chen <marcochen(a)chromium.org>
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:27:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner, Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56719 )
Change subject: tests/Makefile.inc: Add function wrapping mechanism
......................................................................
Patch Set 5:
(1 comment)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56719/comment/8bd70240_8951a69d
PS2, Line 129: 0
> Ooooohhhh... […]
Ok, so everything works when using `awk $1` for value/address. The `before=` is not required. I think, that now it should work without any (or at leas big) problems :)
Oh, and I was using Ghidra to examine all versions of affected object files and binaries. Everything seems to be linking fine. If the `__real_<funcname>` is not being used, linker should drop it, thus not requiring dependencies of this function.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56719
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cd0d66a17029955cbf75c8b155a7ebb7f5513aa
Gerrit-Change-Number: 56719
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment