Attention is currently required from: Henry Sun, Weimin Wu. Zhi7 Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56804 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR ......................................................................
Patch Set 3:
(5 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/56804/comment/cd62ca16_92429b98 PS1, Line 7: test only
mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
Done
https://review.coreboot.org/c/coreboot/+/56804/comment/c2e1675e_4b27bfeb PS1, Line 9: test for anpec compatibility
Refer to https://review.coreboot.org/c/coreboot/+/55744. […]
Done
https://review.coreboot.org/c/coreboot/+/56804/comment/f448c919_747df26d PS1, Line 11: None
b:190727416
Done
https://review.coreboot.org/c/coreboot/+/56804/comment/f6e5c4e2_94a819e7 PS1, Line 13: anpec compatibility
enter S0ix and resume normally […]
Done
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56804/comment/ebf28a9a_2e373fd4 PS1, Line 1: #include <baseboard/variants.h>
pls add SPDX identifier at top of file, like this: […]
Done