Attention is currently required from: Julius Werner, Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56719 )
Change subject: tests/Makefile.inc: Add function wrapping mechanism
......................................................................
Patch Set 5:
(1 comment)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56719/comment/8bd70240_8951a69d
PS2, Line 129: 0
Ooooohhhh... […]
Ok, so everything works when using `awk $1` for value/address. The `before=` is not required. I think, that now it should work without any (or at leas big) problems :)
Oh, and I was using Ghidra to examine all versions of affected object files and binaries. Everything seems to be linking fine. If the `__real_<funcname>` is not being used, linker should drop it, thus not requiring dependencies of this function.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cd0d66a17029955cbf75c8b155a7ebb7f5513aa
Gerrit-Change-Number: 56719
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment