Aamir Bohra has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/56826 )
Change subject: mb/amd/bilby: Set Clk always on for x4 and x8 external PCIe Slot
......................................................................
mb/amd/bilby: Set Clk always on for x4 and x8 external PCIe Slot
Keep the clock source for PCIe slots as always on. Also turn off the
unused (0/1/5/6) clock sources. Currently bilby only uses clock sources
2, 3 and 4.
TEST:Verify end devices enumerate on D:F 1.1/1.2 RPs over warm reboot.
Signed-off-by: Aamir Bohra <aamirbohra(a)gmail.com>
Change-Id: Ida485b06279b0a8659c8d00873c3d6023d1e542f
---
M src/mainboard/amd/bilby/devicetree.cb
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/56826/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56826
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida485b06279b0a8659c8d00873c3d6023d1e542f
Gerrit-Change-Number: 56826
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, Karthik Ramasubramanian.
Hello Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56758
to look at the new patch set (#7).
Change subject: soc/intel/common/cpu: Handle non-zero BSP APIC ID in init_cpus
......................................................................
soc/intel/common/cpu: Handle non-zero BSP APIC ID in init_cpus
coreboot always assumes that BSP APIC ID will always be 0 but as
per Intel 64 and IA-32 Architectures Software Developer’s Manual
Volume 3: 8.4.1 BSP and AP Processors, it says that BSP can
be any processor whose index/APIC ID might not be 0.
To handle this situation, init_cpu call is required to modify to
handle dynamic detection of APIC ID from BSP instead of hardcoding
always through devicetree. Function has been updated to create
a new node with actual BSP APIC ID when devicetree doesn't contain
APIC ID defined. In case APID ID is defined, function will use a
node with the APIC ID defined in devicetree.
Changes also requires to remove "lapic 0" hardcoding from devicetree
to allow code to fill BSP APIC ID dynamically. Otherwise coreboot
will create an extra node for CPU with APIC ID 0 and it'll show as a
extra node in kernel. This will cause kernel to report wrong (extra)
core count information then actually present.
BUG=None
BRANCH=None
TEST=Boot the JSL system and observe there is no functional impacts.
Without this CL kernel core count in `lscpu` = 3
With this CL, kernel core count is corrected to 2.
Change-Id: Ib14a5c31b3afb0d773284c684bd1994a78b94445
Signed-off-by: MAULIK V VAGHELA <maulik.v.vaghela(a)intel.com>
---
M src/soc/intel/common/block/cpu/mp_init.c
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/56758/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/56758
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib14a5c31b3afb0d773284c684bd1994a78b94445
Gerrit-Change-Number: 56758
Gerrit-PatchSet: 7
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Furquan Shaikh, Julius Werner.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56790 )
Change subject: arch/arm64: Add PCI configuration interface
......................................................................
Patch Set 1:
(1 comment)
File src/arch/arm64/include/arch/pci_cfg.h:
https://review.coreboot.org/c/coreboot/+/56790/comment/d7d89124_242f2b19
PS1, Line 12: extern void *arch_pci_map_bus(u32 dev, u32 where, u8 size);
> I think we can make this work in the common mmio_cfg.h functions by providing the map_bus function. […]
Hi Furquan,
Thanks for your review.
Do we have a chance to add the map_bus and config r/w function as a callback hook in the device structure like the Linux kernel did? Maybe it will be more compatible with the non-x86 platform. What do you think?
Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56790
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccb3fd1f1f9c5074aea94db6c55d75df0789f5df
Gerrit-Change-Number: 56790
Gerrit-PatchSet: 1
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 05 Aug 2021 03:42:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jeff Chase, Tim Wawrzynczak, Joe Tessler.
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56819 )
Change subject: mb/google/hatch/scout: Update DPTF parameters
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56819
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5dc89d1d4c2b64c9aac780a7db743a91fd0ebc9b
Gerrit-Change-Number: 56819
Gerrit-PatchSet: 2
Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Jeff Chase <jnchase(a)google.com>
Gerrit-Reviewer: Joe Tessler <jrt(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jeff Chase <jnchase(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Joe Tessler <jrt(a)google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 03:40:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Marshall Dawson, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55602 )
Change subject: amdfwtool: Decorate the comment and blank
......................................................................
Patch Set 4:
(2 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/55602/comment/94f3980d_c2a57fbb
PS3, Line 45:
> Maybe a comment that a 2nd-level is not required on all families
Done
https://review.coreboot.org/c/coreboot/+/55602/comment/8eb329db_ccf485c7
PS3, Line 48: BDT
> Spell this out as "BIOS Directory Table"?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/55602
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f64c9a240503f9d0bf240916c1066944fa39d27
Gerrit-Change-Number: 55602
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Thu, 05 Aug 2021 03:29:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Bao Zheng, Zheng Bao.
Hello build bot (Jenkins), Zheng Bao,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55602
to look at the new patch set (#4).
Change subject: amdfwtool: Decorate the comment and blank
......................................................................
amdfwtool: Decorate the comment and blank
Add more detailed description and note in comment.
And fix some blank.
Change-Id: I6f64c9a240503f9d0bf240916c1066944fa39d27
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 36 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/55602/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/55602
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f64c9a240503f9d0bf240916c1066944fa39d27
Gerrit-Change-Number: 55602
Gerrit-PatchSet: 4
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-MessageType: newpatchset
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56718 )
Change subject: util/kconfig: Provide default for DEFCONFIG
......................................................................
util/kconfig: Provide default for DEFCONFIG
Our documentation claims that the DEFCONFIG make variable, used for
targets such as savedefconfig, defaults to 'defconfig'.
With the update to kconfig 5.13 we lost this default, so bring it back.
Fixes: 53ea1d44f0 ("util/kconfig: Uprev to Linux 5.13's kconfig")
Resolves: https://ticket.coreboot.org/issues/317
Change-Id: Idb88b69ffa855fa97df8c821601308e717575550
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56718
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Martin Roth <martinroth(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M util/kconfig/Makefile.inc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin Roth: Looks good to me, approved
Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.inc
index bedb41d..c3b764b 100644
--- a/util/kconfig/Makefile.inc
+++ b/util/kconfig/Makefile.inc
@@ -6,6 +6,8 @@
export LC_ALL=C
export LANG=C
+DEFCONFIG ?= defconfig
+
# Include original Makefile, with just enough edits to work for us
$(objk)/Makefile.real: $(dir $(lastword $(MAKEFILE_LIST)))Makefile
mkdir -p $(objk)
--
To view, visit https://review.coreboot.org/c/coreboot/+/56718
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb88b69ffa855fa97df8c821601308e717575550
Gerrit-Change-Number: 56718
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged