Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56718 )
Change subject: util/kconfig: Provide default for DEFCONFIG
......................................................................
util/kconfig: Provide default for DEFCONFIG
Our documentation claims that the DEFCONFIG make variable, used for
targets such as savedefconfig, defaults to 'defconfig'.
With the update to kconfig 5.13 we lost this default, so bring it back.
Fixes: 53ea1d44f0 ("util/kconfig: Uprev to Linux 5.13's kconfig")
Resolves: https://ticket.coreboot.org/issues/317
Change-Id: Idb88b69ffa855fa97df8c821601308e717575550
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56718
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Martin Roth <martinroth(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M util/kconfig/Makefile.inc
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin Roth: Looks good to me, approved
Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.inc
index bedb41d..c3b764b 100644
--- a/util/kconfig/Makefile.inc
+++ b/util/kconfig/Makefile.inc
@@ -6,6 +6,8 @@
export LC_ALL=C
export LANG=C
+DEFCONFIG ?= defconfig
+
# Include original Makefile, with just enough edits to work for us
$(objk)/Makefile.real: $(dir $(lastword $(MAKEFILE_LIST)))Makefile
mkdir -p $(objk)
--
To view, visit https://review.coreboot.org/c/coreboot/+/56718
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb88b69ffa855fa97df8c821601308e717575550
Gerrit-Change-Number: 56718
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Idwer Vollering, Paul Menzel, Angel Pons.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 )
Change subject: util/kconfig: detect ncurses on FreeBSD
......................................................................
Patch Set 5:
(1 comment)
File util/kconfig/mconf-cfg.sh:
https://review.coreboot.org/c/coreboot/+/56677/comment/a53a0d3d_ea2bece8
PS2, Line 40: fi
> It looks like Linux upstream removed that in commit c0f975af17 (kconfig: Support building mconf with […]
If people on BSD override the HOSTCC setting, this patch isn't needed, but I don't think that's what we want. I support merging this change.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e
Gerrit-Change-Number: 56677
Gerrit-PatchSet: 5
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 02:47:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Idwer Vollering, Paul Menzel, Angel Pons.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56677 )
Change subject: util/kconfig: detect ncurses on FreeBSD
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS4:
> I still like to know if Linux’ upstream fails the same way under FreeBSD.
It sounds like it doesn't fail so long as HOSTCC is overridden. I don't think that's the right solution for coreboot, so this seems reasonable to me.
File util/kconfig/mconf-cfg.sh:
https://review.coreboot.org/c/coreboot/+/56677/comment/341efb2e_78403c84
PS5, Line 40: fi
> By the way, should the source only be changed by the patches, or are both modified. […]
My understanding is that Both need to be modified. The patches, as I understand, are there to support future updates and are already applied to the kconfig update that is currently in the tree.
https://review.coreboot.org/c/coreboot/+/37152
--
To view, visit https://review.coreboot.org/c/coreboot/+/56677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4344ba2116c0b8618357db4248d993509cbb666e
Gerrit-Change-Number: 56677
Gerrit-PatchSet: 5
Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 02:45:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Aseda Aboagye, Karthik Ramasubramanian.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56798 )
Change subject: mb/google/dedede: Create driblee variant
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> Is it using Cr50 or TPM2. […]
Thank you for prompt reply.
Driblee is using TPM2.0 and I updated the related files.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ad9a4e0cf7999337b55d62d5cc94e4f6c2e98f3
Gerrit-Change-Number: 56798
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 02:45:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held.
Martin Roth has removed Marshall Dawson from this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed
......................................................................
Removed reviewer Marshall Dawson.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56818
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278768e361499919666d07e1dd92d83c2390035e
Gerrit-Change-Number: 56818
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Felix Held.
Martin Roth has removed Jason Glenesk from this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed
......................................................................
Removed reviewer Jason Glenesk.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56818
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278768e361499919666d07e1dd92d83c2390035e
Gerrit-Change-Number: 56818
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Felix Held.
Martin Roth has removed Raul Rangel from this change. ( https://review.coreboot.org/c/coreboot/+/56818 )
Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed
......................................................................
Removed reviewer Raul Rangel.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56818
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278768e361499919666d07e1dd92d83c2390035e
Gerrit-Change-Number: 56818
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Frank Wu, Henry Sun, Aseda Aboagye.
Hello build bot (Jenkins), Henry Sun, Aseda Aboagye, EricR Lai, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56798
to look at the new patch set (#2).
Change subject: mb/google/dedede: Create driblee variant
......................................................................
mb/google/dedede: Create driblee variant
Create the driblee variant of the waddledee reference board by
copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.5.0).
BUG=b:191732473
BRANCH=None
TEST=util/abuild/abuild -p none -t google/dedede -x -a
make sure the build includes GOOGLE_DRIBLEE
Signed-off-by: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Change-Id: I1ad9a4e0cf7999337b55d62d5cc94e4f6c2e98f3
---
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/driblee/include/variant/ec.h
A src/mainboard/google/dedede/variants/driblee/include/variant/gpio.h
A src/mainboard/google/dedede/variants/driblee/memory/Makefile.inc
A src/mainboard/google/dedede/variants/driblee/memory/dram_id.generated.txt
A src/mainboard/google/dedede/variants/driblee/memory/mem_parts_used.txt
A src/mainboard/google/dedede/variants/driblee/overridetree.cb
8 files changed, 79 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/56798/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ad9a4e0cf7999337b55d62d5cc94e4f6c2e98f3
Gerrit-Change-Number: 56798
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro.
Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56801 )
Change subject: gimble: enable elan touchscreen
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/gimble/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56801/comment/04c97261_a8d39fd1
PS3, Line 138: 300
> From the Elan touchscreen spec, it said " T3 ≥ 300ms. […]
After confirmed with Elan, they said reset_delay_ms must not lower than 150ms. Can we use 300ms for now, and I think HW will measure the suspend resume time once they test the suspend item.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56801
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20a7fd0b370803c14990b77bab302727af197ccb
Gerrit-Change-Number: 56801
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 02:25:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-MessageType: comment