Attention is currently required from: Hung-Te Lin, Furquan Shaikh, Julius Werner.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56790 )
Change subject: arch/arm64: Add PCI configuration interface
......................................................................
Patch Set 1:
(1 comment)
File src/arch/arm64/include/arch/pci_cfg.h:
https://review.coreboot.org/c/coreboot/+/56790/comment/d7d89124_242f2b19
PS1, Line 12: extern void *arch_pci_map_bus(u32 dev, u32 where, u8 size);
I think we can make this work in the common mmio_cfg.h functions by providing the map_bus function. […]
Hi Furquan,
Thanks for your review.
Do we have a chance to add the map_bus and config r/w function as a callback hook in the device structure like the Linux kernel did? Maybe it will be more compatible with the non-x86 platform. What do you think?
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccb3fd1f1f9c5074aea94db6c55d75df0789f5df
Gerrit-Change-Number: 56790
Gerrit-PatchSet: 1
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 05 Aug 2021 03:42:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment