Attention is currently required from: Henry Sun, Weimin Wu, Zhi7 Li.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56804 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56804/comment/ceab3dc6_2ba55c68
PS3, Line 9: Refer to https://review.coreboot.org/c/coreboot/+/55744.
Please use
commit df520855 (soc/intel/jsl: Add disable_external_bypass_vr config)
as the git tools operate with these hashes.
https://review.coreboot.org/c/coreboot/+/56804/comment/b48f041d_51c49d01
PS3, Line 15: by powerd_dbus_suspend
This fits on one line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 3
Gerrit-Owner: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 05 Aug 2021 08:50:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment