Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Felix Held.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56781 )
Change subject: soc/amd/common: move GPIO ACPIMMIO access functions to gpio_banks block
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d6dea72c6bebbbe6ce545bedfc74f91e0042c4
Gerrit-Change-Number: 56781
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 05 Aug 2021 14:24:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56781 )
Change subject: soc/amd/common: move GPIO ACPIMMIO access functions to gpio_banks block
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/56781/comment/ca2c2e27_3551dd31
PS2, Line 21: acpimmio_gpio0
> sounds like a good idea; will probably do that as a follow-up though
done in CB:56831
--
To view, visit https://review.coreboot.org/c/coreboot/+/56781
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d6dea72c6bebbbe6ce545bedfc74f91e0042c4
Gerrit-Change-Number: 56781
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 14:17:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56831 )
Change subject: soc/amd/common/block/gpio_banks: add comment about acpimmio_* symbols
......................................................................
soc/amd/common/block/gpio_banks: add comment about acpimmio_* symbols
Suggested-by: Martin Roth <martinroth(a)chromium.org>
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I0016a6c7d6581cb261cab6178268c1a86b89c839
---
M src/soc/amd/common/block/gpio_banks/gpio.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/56831/1
diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c
index 22c030d..eb38ec1 100644
--- a/src/soc/amd/common/block/gpio_banks/gpio.c
+++ b/src/soc/amd/common/block/gpio_banks/gpio.c
@@ -15,6 +15,12 @@
#include <assert.h>
#include <string.h>
+/*
+ * acpimmio_gpio0, acpimmio_remote_gpio and acpimmio_iomux are defined in
+ * soc/amd/common/block/acpimmio/mmio_util.c and declared as extern variables/constants in
+ * amdblocks/acpimmio.h which is included in this file.
+ */
+
/* MMIO access of new-style GPIO bank configuration registers */
static inline void *gpio_ctrl_ptr(gpio_t gpio_num)
{
--
To view, visit https://review.coreboot.org/c/coreboot/+/56831
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0016a6c7d6581cb261cab6178268c1a86b89c839
Gerrit-Change-Number: 56831
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Hello Jason Glenesk, Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56830
to look at the new patch set (#2).
Change subject: soc/amd/common/block/gpio_banks: inline iomux_read8 and iomux_write8
......................................................................
soc/amd/common/block/gpio_banks: inline iomux_read8 and iomux_write8
Since both functions are only called from one function each, inline them
into those functions. Also get_gpio_mux just returned the return value
of iomux_read8, so there were two functions with identical functionality
which shouldn't be the case.
Suggested-by: Martin Roth <martinroth(a)chromium.org>
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I5662d0226edb25a9954fa47b42e208729a79e5a9
---
M src/soc/amd/common/block/gpio_banks/gpio.c
1 file changed, 4 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/56830/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56830
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5662d0226edb25a9954fa47b42e208729a79e5a9
Gerrit-Change-Number: 56830
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56811
to look at the new patch set (#6).
Change subject: [WIP] soc/amd/cezanne/include/gpio: add remote GPIO pin mux definitions
......................................................................
[WIP] soc/amd/cezanne/include/gpio: add remote GPIO pin mux definitions
Add the pin definitions for the remote GPIOs and the GPIO pin mux values
for the GPIO mode of those pins. For now, accessing the remote GPIOs is
only supported from the native coreboot code running on the x86 cores
and not from verstage on PSP or ACPI.
TODO: Test the code.
BUG=b:194524995
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I0e57042e74da88503b36d6065e9500876287f8bb
---
M src/soc/amd/cezanne/include/soc/gpio.h
1 file changed, 37 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/56811/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/56811
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e57042e74da88503b36d6065e9500876287f8bb
Gerrit-Change-Number: 56811
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Marshall Dawson.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Matt Papageorge, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56450
to look at the new patch set (#3).
Change subject: soc/amd/picasso: Move IVRS generation code to common
......................................................................
soc/amd/picasso: Move IVRS generation code to common
Move IVRS acpi table generation code to common, so that it can be shared
by other programs.
BUG=b:190515051
TEST=Build picasso coreboot image. Compare IVRS tables before/after
change.
Change-Id: Icd5fec3a9d66e8301e267312020e726d9bc1aa70
Signed-off-by: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
---
M src/soc/amd/common/block/acpi/Makefile.inc
A src/soc/amd/common/block/acpi/ivrs.c
M src/soc/amd/common/block/include/amdblocks/acpi.h
M src/soc/amd/picasso/Kconfig
M src/soc/amd/picasso/agesa_acpi.c
5 files changed, 471 insertions(+), 450 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/56450/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56450
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd5fec3a9d66e8301e267312020e726d9bc1aa70
Gerrit-Change-Number: 56450
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56780 )
Change subject: soc/amd/common/block/gpio_banks: factor out get_gpio_mux
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/56780/comment/1e2750da_112da036
PS1, Line 165: iomux_read8
> i'll probably do that later in the patch series when the iomux_read8 implementation is moved to this […]
done in CB:56830
--
To view, visit https://review.coreboot.org/c/coreboot/+/56780
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d7a8c5a7188fd558a577352f8b246e61f3edd63
Gerrit-Change-Number: 56780
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 13:57:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martinroth(a)google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56830 )
Change subject: soc/amd/common/block/gpio: inline iomux_read8 and iomux_write8
......................................................................
soc/amd/common/block/gpio: inline iomux_read8 and iomux_write8
Since both functions are only called from one function each, inline them
into those functions. Also get_gpio_mux just returned the return value
of iomux_read8, so there were two functions with identical functionality
which shouldn't be the case.
Suggested-by: Martin Roth <martinroth(a)chromium.org>
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I5662d0226edb25a9954fa47b42e208729a79e5a9
---
M src/soc/amd/common/block/gpio_banks/gpio.c
1 file changed, 4 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/56830/1
diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c
index 6149f63..22c030d 100644
--- a/src/soc/amd/common/block/gpio_banks/gpio.c
+++ b/src/soc/amd/common/block/gpio_banks/gpio.c
@@ -50,25 +50,15 @@
(gpio_num - AMD_GPIO_FIRST_REMOTE_GPIO_NUMBER);
}
-static inline uint8_t iomux_read8(gpio_t gpio_num)
+static uint8_t get_gpio_mux(gpio_t gpio_num)
{
return read8(gpio_mux_ptr(gpio_num));
}
-static inline void iomux_write8(gpio_t gpio_num, uint8_t value)
+static void set_gpio_mux(gpio_t gpio_num, uint8_t function)
{
- write8(gpio_mux_ptr(gpio_num), value);
-}
-
-static uint8_t get_gpio_mux(gpio_t gpio)
-{
- return iomux_read8(gpio);
-}
-
-static void set_gpio_mux(gpio_t gpio, uint8_t function)
-{
- iomux_write8(gpio, function & AMD_GPIO_MUX_MASK);
- get_gpio_mux(gpio); /* Flush posted write */
+ write8(gpio_mux_ptr(gpio_num), function & AMD_GPIO_MUX_MASK);
+ get_gpio_mux(gpio_num); /* Flush posted write */
}
static int get_gpio_gevent(gpio_t gpio, const struct soc_amd_event *table,
--
To view, visit https://review.coreboot.org/c/coreboot/+/56830
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5662d0226edb25a9954fa47b42e208729a79e5a9
Gerrit-Change-Number: 56830
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Attention is currently required from: Ravi kumar, Martin Roth, Jakub Czapiga.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56591 )
Change subject: Revert "util/kconfig: Uprev to Linux 5.13's kconfig"
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
What is the rationale behind the request to revert this commit?
There is at least one pending change that presume the presence of Linux 5.13's kconfig.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56591
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I212366a7b56ead9e05bc095cf276776c8f7a2a26
Gerrit-Change-Number: 56591
Gerrit-PatchSet: 2
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 13:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment