Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56831 )
Change subject: soc/amd/common/block/gpio_banks: add comment about acpimmio_* symbols ......................................................................
soc/amd/common/block/gpio_banks: add comment about acpimmio_* symbols
Suggested-by: Martin Roth martinroth@chromium.org Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I0016a6c7d6581cb261cab6178268c1a86b89c839 --- M src/soc/amd/common/block/gpio_banks/gpio.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/56831/1
diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c index 22c030d..eb38ec1 100644 --- a/src/soc/amd/common/block/gpio_banks/gpio.c +++ b/src/soc/amd/common/block/gpio_banks/gpio.c @@ -15,6 +15,12 @@ #include <assert.h> #include <string.h>
+/* + * acpimmio_gpio0, acpimmio_remote_gpio and acpimmio_iomux are defined in + * soc/amd/common/block/acpimmio/mmio_util.c and declared as extern variables/constants in + * amdblocks/acpimmio.h which is included in this file. + */ + /* MMIO access of new-style GPIO bank configuration registers */ static inline void *gpio_ctrl_ptr(gpio_t gpio_num) {