Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.

Felix Held has uploaded this change for review.

View Change

soc/amd/common/block/gpio_banks: add comment about acpimmio_* symbols

Suggested-by: Martin Roth <martinroth@chromium.org>
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I0016a6c7d6581cb261cab6178268c1a86b89c839
---
M src/soc/amd/common/block/gpio_banks/gpio.c
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/56831/1
diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c
index 22c030d..eb38ec1 100644
--- a/src/soc/amd/common/block/gpio_banks/gpio.c
+++ b/src/soc/amd/common/block/gpio_banks/gpio.c
@@ -15,6 +15,12 @@
#include <assert.h>
#include <string.h>

+/*
+ * acpimmio_gpio0, acpimmio_remote_gpio and acpimmio_iomux are defined in
+ * soc/amd/common/block/acpimmio/mmio_util.c and declared as extern variables/constants in
+ * amdblocks/acpimmio.h which is included in this file.
+ */
+
/* MMIO access of new-style GPIO bank configuration registers */
static inline void *gpio_ctrl_ptr(gpio_t gpio_num)
{

To view, visit change 56831. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0016a6c7d6581cb261cab6178268c1a86b89c839
Gerrit-Change-Number: 56831
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-MessageType: newchange