Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55163 )
Change subject: soc/mediatek/mt8195: fix GPIO register offsets
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55163/comment/5beb661c_0ac6047f
PS1, Line 9: Fix GPIO pu/pd offset.
> Thanks. Please put this in commit description […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/55163/comment/7025b8c2_cf9a6172
PS4, Line 7: soc/mediatek/mt8195: fix GPIO register offset
> Plural: offsets?
Done
https://review.coreboot.org/c/coreboot/+/55163/comment/ee8d0d0c_cec7bd7a
PS4, Line 10:
> Where did you get the new values from? Did something not work before and works now?
I add document info in commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55163
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b0f8a24756092a97933cc9d4ba13a9e79c73e91
Gerrit-Change-Number: 55163
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 04 Jun 2021 06:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin.
Rex-BC Chen has uploaded a new patch set (#115) to the change originally created by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/52260 )
Change subject: DO-NOT-SUBMIT: MT8195 Cherry review ToT
......................................................................
DO-NOT-SUBMIT: MT8195 Cherry review ToT
Signed-off-by: Yidi Lin <yidi.lin(a)mediatek.com>
Change-Id: I3ed96b245bbb52501e9b7d6b89ed42468f505ab0
---
M 3rdparty/amd_blobs
M 3rdparty/blobs
M 3rdparty/intel-microcode
M README.md
4 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/52260/115
--
To view, visit https://review.coreboot.org/c/coreboot/+/52260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ed96b245bbb52501e9b7d6b89ed42468f505ab0
Gerrit-Change-Number: 52260
Gerrit-PatchSet: 115
Gerrit-Owner: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joel Kitching <kitching(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-MessageType: newpatchset
Paul2 Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55176 )
Change subject: TEST ONLY DO NOT SUMMIT
......................................................................
Patch Set 1: Code-Review-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/55176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie01870e0f3b0259f590cf9d133fab5e763f988a4
Gerrit-Change-Number: 55176
Gerrit-PatchSet: 1
Gerrit-Owner: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 04 Jun 2021 06:10:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Paul2 Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55176 )
Change subject: TEST ONLY DO NOT SUMMIT
......................................................................
TEST ONLY DO NOT SUMMIT
TEST
BUG=none
BRANCH=none
TEST=none
Change-Id: Ie01870e0f3b0259f590cf9d133fab5e763f988a4
---
M README.md
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/55176/1
diff --git a/README.md b/README.md
index 14879c1..41d9549 100644
--- a/README.md
+++ b/README.md
@@ -1,3 +1,4 @@
+TEST ONLY
coreboot README
===============
--
To view, visit https://review.coreboot.org/c/coreboot/+/55176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie01870e0f3b0259f590cf9d133fab5e763f988a4
Gerrit-Change-Number: 55176
Gerrit-PatchSet: 1
Gerrit-Owner: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans, Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Marshall Dawson, Johnny Lin, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Morgan Jang, Werner Zeh, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55012 )
Change subject: arch/x86: Set RTC century byte offset in FADT x86-wide
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
'for file in $(find -name \*.layout); do grep -l "^400" $file; done'
Looks like a lot of mainboards have an option in cmos.layout there...
You might want to explicitly set that byte as reserved in there for all boards. You can check that in C code: see for instance soc/intel/xeon_sp/cpx/romstage.c how this is done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fa5ddc368c129a5f847c64064374aae2d4f0c43
Gerrit-Change-Number: 55012
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 04 Jun 2021 06:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55163 )
Change subject: soc/mediatek/mt8195: fix GPIO register offset
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55163/comment/bc317dcc_d85b6d3a
PS4, Line 7: soc/mediatek/mt8195: fix GPIO register offset
Plural: offsets?
https://review.coreboot.org/c/coreboot/+/55163/comment/552895e2_4f684b2a
PS4, Line 10:
Where did you get the new values from? Did something not work before and works now?
--
To view, visit https://review.coreboot.org/c/coreboot/+/55163
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b0f8a24756092a97933cc9d4ba13a9e79c73e91
Gerrit-Change-Number: 55163
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 04 Jun 2021 05:59:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Werner Zeh.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55089 )
Change subject: mb/siemens/mc_apl{1,2,3,5,6}: Provide I2C timings for 400 kHz
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/55089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82e11e5dde8ad1047713f105c5a6d020eebf1ffd
Gerrit-Change-Number: 55089
Gerrit-PatchSet: 4
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Fri, 04 Jun 2021 05:57:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment