Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54901 )
Change subject: amdfwtool: Add a function to extract firmwares
......................................................................
Patch Set 13:
(1 comment)
File util/amdfwtool/extract.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120676):
https://review.coreboot.org/c/coreboot/+/54901/comment/437e4536_a2110a38
PS13, Line 91: close (mod_fd);
space prohibited between function name and open parenthesis '('
--
To view, visit https://review.coreboot.org/c/coreboot/+/54901
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74a6c7ff56cc11530695d1068763ecdd86282a17
Gerrit-Change-Number: 54901
Gerrit-PatchSet: 13
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 04 Jun 2021 03:10:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Bao Zheng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/55158 )
Change subject: cbfstool: Print out the CBFS offset and size
......................................................................
Abandoned
cbfstool layout can do this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55158
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7f55180cecfcb7526cf5ae94741b6ae526b66
Gerrit-Change-Number: 55158
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: abandon
Attention is currently required from: Zheng Bao.
Hello build bot (Jenkins), Zheng Bao,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55160
to look at the new patch set (#3).
Change subject: [WIP]amdfwtool: Add a script to replace AMD firmware
......................................................................
[WIP]amdfwtool: Add a script to replace AMD firmware
Change-Id: Ib450277d55ad254234a451e06747121fff731ee0
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
A util/amdfwtool/replace.sh
1 file changed, 84 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/55160/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/55160
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib450277d55ad254234a451e06747121fff731ee0
Gerrit-Change-Number: 55160
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Zheng Bao
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55156
to look at the new patch set (#6).
Change subject: mb/google/cherry: Get RAM code from ADC
......................................................................
mb/google/cherry: Get RAM code from ADC
On Chromebooks the RAM code is implemented by the resistor straps
that we can read and decode from ADC. For Cherry the RAM code can be
read from ADC channel 2 and 3.
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I4f28bc1c567cb886bd90d930219981a6206b9bb9
---
M src/mainboard/google/cherry/boardid.c
1 file changed, 59 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/55156/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/55156
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f28bc1c567cb886bd90d930219981a6206b9bb9
Gerrit-Change-Number: 55156
Gerrit-PatchSet: 6
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin.
Rex-BC Chen has uploaded a new patch set (#114) to the change originally created by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/52260 )
Change subject: DO-NOT-SUBMIT: MT8195 Cherry review ToT
......................................................................
DO-NOT-SUBMIT: MT8195 Cherry review ToT
Signed-off-by: Yidi Lin <yidi.lin(a)mediatek.com>
Change-Id: I3ed96b245bbb52501e9b7d6b89ed42468f505ab0
---
M 3rdparty/amd_blobs
M 3rdparty/blobs
M 3rdparty/intel-microcode
M README.md
4 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/52260/114
--
To view, visit https://review.coreboot.org/c/coreboot/+/52260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ed96b245bbb52501e9b7d6b89ed42468f505ab0
Gerrit-Change-Number: 52260
Gerrit-PatchSet: 114
Gerrit-Owner: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Joel Kitching <kitching(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-MessageType: newpatchset