Attention is currently required from: Furquan Shaikh, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55158 )
Change subject: cbfstool: Print out the CBFS offset and size
......................................................................
Patch Set 2:
(1 comment)
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/55158/comment/e1210ad9_99e129e7
PS2, Line 1507: printf("cbfs_start: 0x%lx\n", image.buffer.offset);
: printf("cbfs_size: 0x%lx\n", image.buffer.size);
> There is already support for printing the offset of CBFS using `cbfstool FILE layout`. […]
Yes. It helps.
will Abandon it later.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55158
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebb7f55180cecfcb7526cf5ae94741b6ae526b66
Gerrit-Change-Number: 55158
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Fri, 04 Jun 2021 02:19:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Marco Chen.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55091 )
Change subject: mb/google/dedede/var/cret: Add ssfc codec cs42l42 support
......................................................................
Patch Set 6:
(1 comment)
This change is ready for review.
File src/mainboard/google/dedede/variants/cret/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55091/comment/13880c3a_4c803e30
PS5, Line 179: probe AUDIO_CODEC_SOURCE AUDIO_CODEC_UNPROVISIONED
> Leave comment in the issue tracker.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/55091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c53291e07fd785c1360c05171eed634788bc665
Gerrit-Change-Number: 55091
Gerrit-PatchSet: 6
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marco Chen <marcochen(a)google.com>
Gerrit-Attention: Marco Chen <marcochen(a)google.com>
Gerrit-Comment-Date: Fri, 04 Jun 2021 02:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen <marcochen(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55149 )
Change subject: soc/amd/cezanne: Configure I2C Pad RX Select through devicetree
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/55149
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I595a64736fdac0274abffb68c5e521302275b845
Gerrit-Change-Number: 55149
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 03 Jun 2021 23:18:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Wayne3 Wang, Henry Sun, Ariel Chang, Paul Menzel, Paul2 Huang, Alex1 Kao.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54529 )
Change subject: mb/google/dedede: Support Realtek audio codec ALC5682I and speaker L/R
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/dedede/variants/pirika/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/54529/comment/b59b1248_f968a66e
PS10, Line 68: probe AUDIO_AMP UNPROVISIONED
Is there an unprovisioned case? If the CBI is always provisioned with amplifier info, then this line can be removed. We did it for other variants where the amplifier info was not provisioned.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54529
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8173ffbfb1a8f18978a5e35c69972d4a6d8cb04a
Gerrit-Change-Number: 54529
Gerrit-PatchSet: 10
Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Wayne3 Wang <wayne3_wang(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Ariel Chang <ariel_chang(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul2 Huang <paul2_huang(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 03 Jun 2021 22:36:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55035 )
Change subject: mb/google/dedede/var/sasukette: Modify the touch pad I2C address
......................................................................
mb/google/dedede/var/sasukette: Modify the touch pad I2C address
There are two touch pads that Sasukette used have the same I2C address.
It will show "/dev/input/event4: SPPT2600:00 06CB:CE9D Touchpad" when
the Synaptics touch pad is connected after running evtest under VT2.
BUG=b:189520603
BRANCH=dedede
TEST=It will show "/dev/input/event4: SYNA0A00:00 06CB:CE9D Touchpad"
when the Synaptics touch pad is connected after running evtest under VT2.
Signed-off-by: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Change-Id: If0bd80baa27dfeb7bcb43f0ca4b02e1228e372a6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55035
Reviewed-by: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/google/dedede/variants/sasukette/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Karthik Ramasubramanian: Looks good to me, approved
zanxi chen: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/sasukette/overridetree.cb b/src/mainboard/google/dedede/variants/sasukette/overridetree.cb
index cb4c78f..0f48365 100644
--- a/src/mainboard/google/dedede/variants/sasukette/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/sasukette/overridetree.cb
@@ -125,7 +125,7 @@
register "generic.wake" = "GPE0_DW0_03"
register "generic.probed" = "1"
register "hid_desc_reg_offset" = "0x20"
- device i2c 2c on end
+ device i2c 2a on end
end
chip drivers/i2c/hid
register "generic.hid" = ""ELAN0000""
--
To view, visit https://review.coreboot.org/c/coreboot/+/55035
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0bd80baa27dfeb7bcb43f0ca4b02e1228e372a6
Gerrit-Change-Number: 55035
Gerrit-PatchSet: 5
Gerrit-Owner: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-CC: Jessie Xu <xuyanan(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: merged