coreboot-gerrit June 2021

coreboot-gerrit@coreboot.org

1 participants
7127 discussions

Change in coreboot[master]: util/crossgcc: Avoid complex filename sets
by Patrick Georgi (Code Review) 06 Jun '21

06 Jun '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54060 ) Change subject: util/crossgcc: Avoid complex filename sets ...................................................................... util/crossgcc: Avoid complex filename sets bin/{foo,bar,baz} can fail if one of the files doesn't exist (depending on the shell in use). Instead, cd into the directory and list the files individually. Change-Id: I042b2e45fded1b63551d8e65ead2a7bbbf96b1e7 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/54060 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/crossgcc/buildgcc 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index e3db60d..aee55f9 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -844,8 +844,9 @@ HOST="$HOST" CFLAGS="$CFLAGS" \ OPT_CFLAGS="-O -D_FORTIFY_SOURCE=2 -D COREBOOT_TOOLCHAIN_VERSION='\"coreboot toolchain v$CROSSGCC_VERSION\"' " \ $MAKE $JOBS CC="$(hostcc host)" iasl acpibin acpidump acpiexec acpihelp acpisrc acpixtract - rm -f "$DESTDIR$TARGETDIR/bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpisrc,acpixtract}" || touch "$RDIR/.failed" - cp bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpisrc,acpixtract} "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed" + mkdir -p "$DESTDIR$TARGETDIR/bin/" + (cd "$DESTDIR$TARGETDIR/bin" && rm -f iasl acpibin acpidump acpiexec acpihelp acpisrc acpixtract) || touch "$RDIR/.failed" + (cd bin && cp iasl acpibin acpidump acpiexec acpihelp acpisrc acpixtract "$DESTDIR$TARGETDIR/bin") || touch "$RDIR/.failed" } build_LLVM() { -- To view, visit https://review.coreboot.org/c/coreboot/+/54060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042b2e45fded1b63551d8e65ead2a7bbbf96b1e7 Gerrit-Change-Number: 54060 Gerrit-PatchSet: 7 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: util/crossgcc: Update to clang 12
by Patrick Georgi (Code Review) 06 Jun '21

06 Jun '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55157 ) Change subject: util/crossgcc: Update to clang 12 ...................................................................... util/crossgcc: Update to clang 12 Change-Id: I38fc64fa872e2ecb0a10fb5378b3ce0d6a02443c Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/55157 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M util/crossgcc/buildgcc D util/crossgcc/sum/clang-11.0.0.src.tar.xz.cksum A util/crossgcc/sum/clang-12.0.0.src.tar.xz.cksum D util/crossgcc/sum/clang-tools-extra-11.0.0.src.tar.xz.cksum A util/crossgcc/sum/clang-tools-extra-12.0.0.src.tar.xz.cksum D util/crossgcc/sum/cmake-3.18.1.tar.gz.cksum A util/crossgcc/sum/cmake-3.20.3.tar.gz.cksum D util/crossgcc/sum/compiler-rt-11.0.0.src.tar.xz.cksum A util/crossgcc/sum/compiler-rt-12.0.0.src.tar.xz.cksum D util/crossgcc/sum/llvm-11.0.0.src.tar.xz.cksum A util/crossgcc/sum/llvm-12.0.0.src.tar.xz.cksum 11 files changed, 16 insertions(+), 14 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 3c8b1a8..e3db60d 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -43,8 +43,8 @@ PYTHON_VERSION=3.8.5 EXPAT_VERSION=2.2.9 # CLANG version number -CLANG_VERSION=11.0.0 -CMAKE_VERSION=3.18.1 +CLANG_VERSION=12.0.0 +CMAKE_VERSION=3.20.3 NASM_VERSION=2.15.05 # GCC toolchain archive locations @@ -65,7 +65,7 @@ CLANG_ARCHIVE="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" CRT_ARCHIVE="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" CTE_ARCHIVE="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" -CMAKE_ARCHIVE="https://cmake.org/files/v3.18/cmake-${CMAKE_VERSION}.tar.gz" +CMAKE_ARCHIVE="https://cmake.org/files/v${CMAKE_VERSION%.*}/cmake-${CMAKE_VERSION}.tar.gz" NASM_ARCHIVE="https://www.nasm.us/pub/nasm/releasebuilds/${NASM_VERSION}/nasm-${NASM_VERS…" ALL_ARCHIVES="$GMP_ARCHIVE $MPFR_ARCHIVE $MPC_ARCHIVE \ @@ -850,19 +850,21 @@ build_LLVM() { - cd .. || exit 1 - ln -sf "$PWD/$CLANG_DIR" "$LLVM_DIR/tools/clang" - ln -sf "$PWD/$CTE_DIR" "$LLVM_DIR/tools/clang/tools/extra" - ln -sf "$PWD/$CRT_DIR" "$LLVM_DIR/projects/compiler-rt" - cd - || exit 1 + ln -nsf "$LLVM_DIR" ../llvm + ln -nsf "$CLANG_DIR" ../clang + ln -nsf "$CTE_DIR" ../clang-tools-extra + ln -nsf "$CRT_DIR" ../compiler-rt $CMAKE -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX="$DESTDIR$TARGETDIR" \ -DCLANG_VENDOR="coreboot toolchain v$CROSSGCC_VERSION - " \ - -DCMAKE_BUILD_TYPE=Release ../$LLVM_DIR || touch .failed + -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;compiler-rt" \ + -DCMAKE_BUILD_TYPE=Release ../llvm || touch .failed # shellcheck disable=SC2086 $MAKE $JOBS || touch .failed $MAKE install || touch .failed + rm -f ../llvm ../clang ../clang-tools-extra ../compiler-rt + cp -a ../$CLANG_DIR/tools/scan-build/* "$DESTDIR$TARGETDIR/bin" cp -a ../$CLANG_DIR/tools/scan-view/* "$DESTDIR$TARGETDIR/bin" diff --git a/util/crossgcc/sum/clang-11.0.0.src.tar.xz.cksum b/util/crossgcc/sum/clang-11.0.0.src.tar.xz.cksum deleted file mode 100644 index 817234f..0000000 --- a/util/crossgcc/sum/clang-11.0.0.src.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -02c87f5e07f2a1c1e2dbb8ce8328f0106d70b10d tarballs/clang-11.0.0.src.tar.xz diff --git a/util/crossgcc/sum/clang-12.0.0.src.tar.xz.cksum b/util/crossgcc/sum/clang-12.0.0.src.tar.xz.cksum new file mode 100644 index 0000000..42be5d9 --- /dev/null +++ b/util/crossgcc/sum/clang-12.0.0.src.tar.xz.cksum @@ -0,0 +1 @@ +51250856f368acef5ab335a16f994bf29ad3d115 tarballs/clang-12.0.0.src.tar.xz diff --git a/util/crossgcc/sum/clang-tools-extra-11.0.0.src.tar.xz.cksum b/util/crossgcc/sum/clang-tools-extra-11.0.0.src.tar.xz.cksum deleted file mode 100644 index f6b260f..0000000 --- a/util/crossgcc/sum/clang-tools-extra-11.0.0.src.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -b77dc0494894b997c8f4012debbf0bf469462386 tarballs/clang-tools-extra-11.0.0.src.tar.xz diff --git a/util/crossgcc/sum/clang-tools-extra-12.0.0.src.tar.xz.cksum b/util/crossgcc/sum/clang-tools-extra-12.0.0.src.tar.xz.cksum new file mode 100644 index 0000000..6328594 --- /dev/null +++ b/util/crossgcc/sum/clang-tools-extra-12.0.0.src.tar.xz.cksum @@ -0,0 +1 @@ +5fe54db45be35b8f77acc32f08e01912f8e8b915 tarballs/clang-tools-extra-12.0.0.src.tar.xz diff --git a/util/crossgcc/sum/cmake-3.18.1.tar.gz.cksum b/util/crossgcc/sum/cmake-3.18.1.tar.gz.cksum deleted file mode 100644 index c4f3ed2..0000000 --- a/util/crossgcc/sum/cmake-3.18.1.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -60c36386d0df016adc96c8bb3215d02de3777869 tarballs/cmake-3.18.1.tar.gz diff --git a/util/crossgcc/sum/cmake-3.20.3.tar.gz.cksum b/util/crossgcc/sum/cmake-3.20.3.tar.gz.cksum new file mode 100644 index 0000000..2ac43e8 --- /dev/null +++ b/util/crossgcc/sum/cmake-3.20.3.tar.gz.cksum @@ -0,0 +1 @@ +96e498c4d1ac238b6852b1113102bf2301bb88d8 tarballs/cmake-3.20.3.tar.gz diff --git a/util/crossgcc/sum/compiler-rt-11.0.0.src.tar.xz.cksum b/util/crossgcc/sum/compiler-rt-11.0.0.src.tar.xz.cksum deleted file mode 100644 index fe447bf..0000000 --- a/util/crossgcc/sum/compiler-rt-11.0.0.src.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -be3e79fb93cd99135643a191f27c49449bf9c0ee tarballs/compiler-rt-11.0.0.src.tar.xz diff --git a/util/crossgcc/sum/compiler-rt-12.0.0.src.tar.xz.cksum b/util/crossgcc/sum/compiler-rt-12.0.0.src.tar.xz.cksum new file mode 100644 index 0000000..650f8e5 --- /dev/null +++ b/util/crossgcc/sum/compiler-rt-12.0.0.src.tar.xz.cksum @@ -0,0 +1 @@ +7b02a455fbc6fe395da8d5411072acc04d669d94 tarballs/compiler-rt-12.0.0.src.tar.xz diff --git a/util/crossgcc/sum/llvm-11.0.0.src.tar.xz.cksum b/util/crossgcc/sum/llvm-11.0.0.src.tar.xz.cksum deleted file mode 100644 index c95d6a5..0000000 --- a/util/crossgcc/sum/llvm-11.0.0.src.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -5723ae20d1e6e9ccfda208cb9a8cf2f87c3a6107 tarballs/llvm-11.0.0.src.tar.xz diff --git a/util/crossgcc/sum/llvm-12.0.0.src.tar.xz.cksum b/util/crossgcc/sum/llvm-12.0.0.src.tar.xz.cksum new file mode 100644 index 0000000..e4f3aa3 --- /dev/null +++ b/util/crossgcc/sum/llvm-12.0.0.src.tar.xz.cksum @@ -0,0 +1 @@ +dbc1cf6aa2dbdeccd7ad26c9215b56963a5686d3 tarballs/llvm-12.0.0.src.tar.xz -- To view, visit https://review.coreboot.org/c/coreboot/+/55157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38fc64fa872e2ecb0a10fb5378b3ce0d6a02443c Gerrit-Change-Number: 55157 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: [WIP] src/superio/smsc: Add support for the SCH5555
by Máté Kukri (Code Review) 06 Jun '21

06 Jun '21

Máté Kukri has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55250 ) Change subject: [WIP] src/superio/smsc: Add support for the SCH5555 ...................................................................... [WIP] src/superio/smsc: Add support for the SCH5555 Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com> Change-Id: I9323198f1139cd0c3dd37f977ae7693b721654f4 --- M src/superio/smsc/Makefile.inc A src/superio/smsc/sch5555/Kconfig A src/superio/smsc/sch5555/Makefile.inc A src/superio/smsc/sch5555/sch5555.h A src/superio/smsc/sch5555/sch5555_bootblock.c A src/superio/smsc/sch5555/sch5555_common.c 6 files changed, 248 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/55250/1 diff --git a/src/superio/smsc/Makefile.inc b/src/superio/smsc/Makefile.inc index 86cf9c5..a65789a 100644 --- a/src/superio/smsc/Makefile.inc +++ b/src/superio/smsc/Makefile.inc @@ -13,3 +13,4 @@ subdirs-y += smscsuperio subdirs-y += sio1036 subdirs-y += sch5545 +subdirs-y += sch5555 diff --git a/src/superio/smsc/sch5555/Kconfig b/src/superio/smsc/sch5555/Kconfig new file mode 100644 index 0000000..2745b68 --- /dev/null +++ b/src/superio/smsc/sch5555/Kconfig @@ -0,0 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-only + +config SUPERIO_SMSC_SCH5555 + bool diff --git a/src/superio/smsc/sch5555/Makefile.inc b/src/superio/smsc/sch5555/Makefile.inc new file mode 100644 index 0000000..58c896e --- /dev/null +++ b/src/superio/smsc/sch5555/Makefile.inc @@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0-only + +bootblock-$(CONFIG_SUPERIO_SMSC_SCH5555) += sch5555_common.c sch5555_bootblock.c +# ramstage-$(CONFIG_SUPERIO_SMSC_SCH5555) += sch5555_ramstage.c diff --git a/src/superio/smsc/sch5555/sch5555.h b/src/superio/smsc/sch5555/sch5555.h new file mode 100644 index 0000000..c349580 --- /dev/null +++ b/src/superio/smsc/sch5555/sch5555.h @@ -0,0 +1,88 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef SUPERIO_SCH5555_H +#define SUPERIO_SCH5555_H + +// Config I/O ports +#define SMSC_INDEX 0x2e +#define SMSC_DATA 0x2f + +// Global registers +#define LDN_SELECT 0x07 +#define DEVICE_ID 0x20 +#define DEVICE_REV 0x21 +#define DEVICE_MODE 0x24 + +// Logical device numbers +#define LDN_EMI 0x00 +#define LDN_8042 0x01 +#define LDN_UART1 0x07 +#define LDN_UART2 0x08 +#define LDN_RUNTIME 0x0a +#define LDN_FDC 0x0b +#define LDN_LPCI 0x0c +#define LDN_PARPORT 0x11 +#define LDN_GLOBAL 0x3f + +// Activate the current LDN (for each LDN) +#define LDN_ACTIVE 0x30 + +// LPC interface registers +#define LPCI_IRQ_CONF 0x40 // Each interrupt is at this +n bytes + +#define LPCI_EMI_BAR 0x64 // BAR offset (inside LPCI) for each LDN +#define LPCI_UART1_BAR 0x68 +#define LPCI_UART2_BAR 0x6c +#define LPCI_RUNTIME_BAR 0x70 +#define LPCI_8042_BAR 0x78 +#define LPCI_FDC_BAR 0x7c +#define LPCI_PARPORT_BAR 0x80 + +// Runtime registers (in I/O space) +#define RUNTIME_PME_STS 0x00 +#define RUNTIME_PME_EN 0x01 +#define RUNTIME_PME_EN1 0x05 +#define RUNTIME_LED 0x25 +#define RUNTIME_UNK1 0x35 // NOTE: not in the datasheet but Dell's firmware writes to it + +// +// Same mapping for these BARs as Dell firmware +// +#define EMI_IOBASE 0xa00 +#define RUNTIME_IOBASE 0xa40 + +// +// Common accessor functions +// + +void smsc_conf_enter(void); +void smsc_conf_exit(void); +uint8_t smsc_read8(uint8_t offset); +uint16_t smsc_read16(uint8_t offset); +uint32_t smsc_read32(uint8_t offset); +void smsc_write8(uint8_t offset, uint8_t value); +void smsc_write16(uint8_t offset, uint16_t value); +void smsc_write32(uint8_t offset, uint32_t value); +uint8_t emi_read8(uint16_t addr); +uint16_t emi_read16(uint16_t addr); +uint32_t emi_read32(uint16_t addr); +void emi_write8(uint16_t addr, uint8_t val); +void emi_write16(uint16_t addr, uint16_t val); +void emi_write32(uint16_t addr, uint32_t val); + +// +// Bootblock entry points +// + +void sch5555_early_init(void); + +#define SCH5555_UART1 0 +#define SCH5555_UART2 1 + +void sch5555_enable_serial(uint8_t uart_no, uint16_t serial_iobase); + +// +// Ramstage entry points +// + +#endif diff --git a/src/superio/smsc/sch5555/sch5555_bootblock.c b/src/superio/smsc/sch5555/sch5555_bootblock.c new file mode 100644 index 0000000..bdd309b --- /dev/null +++ b/src/superio/smsc/sch5555/sch5555_bootblock.c @@ -0,0 +1,49 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <arch/io.h> +#include "sch5555.h" + +/* + * Here we do just enough init so that the motherboard specific magic EMI + * sequences could actually be sent before the serial enable function is called + */ +void sch5555_early_init(void) +{ + smsc_conf_enter(); + + // Enable IRQs + smsc_write8(LDN_SELECT, LDN_GLOBAL); + smsc_write8(DEVICE_MODE, 0x04); + + // Map EMI and runtime registers + smsc_write8(LDN_SELECT, LDN_LPCI); + smsc_write32(LPCI_EMI_BAR, (EMI_IOBASE << 16) | 0x800f); + smsc_write32(LPCI_RUNTIME_BAR, (RUNTIME_IOBASE << 16) | 0x8a3f); + + smsc_conf_exit(); +} + +void sch5555_enable_serial(uint8_t uart_no, uint16_t serial_iobase) +{ + smsc_conf_enter(); + + // Set LPCI register to map UART into I/O space + smsc_write8(LDN_SELECT, LDN_LPCI); + + switch (uart_no) { + case SCH5555_UART1: + smsc_write32(LPCI_UART1_BAR, serial_iobase << 16 | 0x8707); + smsc_write8(LDN_SELECT, LDN_UART1); + break; + case SCH5555_UART2: + smsc_write32(LPCI_UART2_BAR, serial_iobase << 16 | 0x8707); + smsc_write8(LDN_SELECT, LDN_UART2); + break; + } + + // Setup UART's configuration registers + smsc_write8(LDN_ACTIVE, 0x01); // Activate + smsc_write8(0x0f, 0x02); // Config select + + smsc_conf_exit(); +} diff --git a/src/superio/smsc/sch5555/sch5555_common.c b/src/superio/smsc/sch5555/sch5555_common.c new file mode 100644 index 0000000..f0dc562 --- /dev/null +++ b/src/superio/smsc/sch5555/sch5555_common.c @@ -0,0 +1,102 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <arch/io.h> +#include "sch5555.h" + +// +// Super I/O register access +// + +void smsc_conf_enter(void) +{ + outb(0x55, SMSC_INDEX); +} + +void smsc_conf_exit(void) +{ + outb(0xaa, SMSC_INDEX); +} + +uint8_t smsc_read8(uint8_t offset) +{ + outb(offset, SMSC_INDEX); + return inb(SMSC_DATA); +} + +uint16_t smsc_read16(uint8_t offset) +{ + uint16_t val = 0; + val |= smsc_read8(offset); + val |= smsc_read8(offset + 1) << 8; + return val; +} + +uint32_t smsc_read32(uint8_t offset) +{ + uint32_t val = 0; + val |= smsc_read8(offset); + val |= smsc_read8(offset + 1) << 8; + val |= smsc_read8(offset + 2) << 16; + val |= smsc_read8(offset + 3) << 24; + return val; +} + +void smsc_write8(uint8_t offset, uint8_t value) +{ + outb(offset, SMSC_INDEX); + outb(value, SMSC_DATA); +} + +void smsc_write16(uint8_t offset, uint16_t value) +{ + smsc_write8(offset, value & 0xff); + smsc_write8(offset + 1, (value >> 8) & 0xff); +} + +void smsc_write32(uint8_t offset, uint32_t value) +{ + smsc_write8(offset, value & 0xff); + smsc_write8(offset + 1, (value >> 8) & 0xff); + smsc_write8(offset + 2, (value >> 16) & 0xff); + smsc_write8(offset + 3, (value >> 24) & 0xff); +} + +// +// EMI access +// + +uint8_t emi_read8(uint16_t addr) +{ + outw(addr | 0x8000, EMI_IOBASE + 2); + return inb(EMI_IOBASE + 4); +} + +uint16_t emi_read16(uint16_t addr) +{ + outw(addr | 0x8001, EMI_IOBASE + 2); + return inw(EMI_IOBASE + 4); +} + +uint32_t emi_read32(uint16_t addr) +{ + outw(addr | 0x8002, EMI_IOBASE + 2); + return inl(EMI_IOBASE + 4); +} + +void emi_write8(uint16_t addr, uint8_t val) +{ + outw(addr | 0x8000, EMI_IOBASE + 2); + outb(val, EMI_IOBASE + 4); +} + +void emi_write16(uint16_t addr, uint16_t val) +{ + outw(addr | 0x8001, EMI_IOBASE + 2); + outw(val, EMI_IOBASE + 4); +} + +void emi_write32(uint16_t addr, uint32_t val) +{ + outw(addr | 0x8002, EMI_IOBASE + 2); + outl(val, EMI_IOBASE + 4); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/55250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9323198f1139cd0c3dd37f977ae7693b721654f4 Gerrit-Change-Number: 55250 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Ada: Enable the newest Ada standard + extensions supported by gnat
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55168 ) Change subject: Ada: Enable the newest Ada standard + extensions supported by gnat ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/55168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If2f627bdf7f29ffdd4433b4ca608b2291ebe1551 Gerrit-Change-Number: 55168 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 13:02:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/crossgcc: Update to clang 12
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55157 ) Change subject: util/crossgcc: Update to clang 12 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55157 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I38fc64fa872e2ecb0a10fb5378b3ce0d6a02443c Gerrit-Change-Number: 55157 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 13:01:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/crossgcc: Avoid complex filename sets
by Angel Pons (Code Review) 06 Jun '21

06 Jun '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54060 ) Change subject: util/crossgcc: Avoid complex filename sets ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54060 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I042b2e45fded1b63551d8e65ead2a7bbbf96b1e7 Gerrit-Change-Number: 54060 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 06 Jun 2021 13:01:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/lapic: Add lapic_update32() helper
by Kyösti Mälkki (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Wonkyu Kim. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55187 ) Change subject: cpu/x86/lapic: Add lapic_update32() helper ...................................................................... Patch Set 3: (1 comment) File src/cpu/x86/lapic/lapic.c: https://review.coreboot.org/c/coreboot/+/55187/comment/83b9330d_0131d1c0 PS3, Line 35: LAPIC_DELIVERY_MODE_EXTINT); Docs say DELIVERY_MODE_EXTINT should only appear on one LAPIC. LVT_REMOTE_IRR and SEND_PENDING are read-only bits? -- To view, visit https://review.coreboot.org/c/coreboot/+/55187 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57c5d85d3098f9d59f26f427fe16829e4e769194 Gerrit-Change-Number: 55187 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Comment-Date: Sun, 06 Jun 2021 12:49:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86: Default to PARALLEL_MP selected
by Arthur Heymans (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Angel Pons, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Morgan Jang, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55196 ) Change subject: cpu/x86: Default to PARALLEL_MP selected ...................................................................... Patch Set 4: (1 comment) File src/cpu/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/55196/comment/94fd63cf_a5287d14 PS3, Line 6: PARALLEL_MP > If we decide LEGACY_CPU_INIT should go away, I'd rather have them tagged explicitly. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/55196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9833c4f6c43b3e67f95bd465c42d7a5036dff914 Gerrit-Change-Number: 55196 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 12:22:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86: Default to PARALLEL_MP selected
by Arthur Heymans (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Angel Pons, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Morgan Jang, Felix Held. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55196 ) Change subject: cpu/x86: Default to PARALLEL_MP selected ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9833c4f6c43b3e67f95bd465c42d7a5036dff914 Gerrit-Change-Number: 55196 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 06 Jun 2021 12:21:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86: Default to PARALLEL_MP selected
by Kyösti Mälkki (Code Review) 06 Jun '21

06 Jun '21

Attention is currently required from: Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Angel Pons, Arthur Heymans, Andrey Petrov, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Tim Wawrzynczak, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Morgan Jang, Felix Held. Hello build bot (Jenkins), Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Angel Pons, Arthur Heymans, Andrey Petrov, Patrick Rudolph, Jason Glenesk, Anjaneya "Reddy" Chagam, Damien Zammit, Marshall Dawson, Johnny Lin, Suresh Bellampalli, Tim Wawrzynczak, Vanessa Eusebio, Michal Motyl, Morgan Jang, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55196 to look at the new patch set (#4). Change subject: cpu/x86: Default to PARALLEL_MP selected ...................................................................... cpu/x86: Default to PARALLEL_MP selected Change-Id: I9833c4f6c43b3e67f95bd465c42d7a5036dff914 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/cpu/intel/haswell/Kconfig M src/cpu/intel/model_2065x/Kconfig M src/cpu/intel/model_206ax/Kconfig M src/cpu/qemu-x86/Kconfig M src/cpu/x86/Kconfig M src/northbridge/amd/agesa/family14/Kconfig M src/northbridge/amd/agesa/family15tn/Kconfig M src/northbridge/amd/agesa/family16kb/Kconfig M src/northbridge/amd/pi/00730F01/Kconfig M src/northbridge/intel/e7505/Kconfig M src/northbridge/intel/gm45/Kconfig M src/northbridge/intel/i440bx/Kconfig M src/northbridge/intel/i945/Kconfig M src/northbridge/intel/pineview/Kconfig M src/northbridge/intel/x4x/Kconfig M src/soc/amd/cezanne/Kconfig M src/soc/amd/picasso/Kconfig M src/soc/amd/stoneyridge/Kconfig M src/soc/intel/alderlake/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/baytrail/Kconfig M src/soc/intel/braswell/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/icelake/Kconfig M src/soc/intel/jasperlake/Kconfig M src/soc/intel/skylake/Kconfig M src/soc/intel/tigerlake/Kconfig M src/soc/intel/xeon_sp/Kconfig 30 files changed, 13 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/55196/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/55196 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9833c4f6c43b3e67f95bd465c42d7a5036dff914 Gerrit-Change-Number: 55196 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Damien Zammit Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2021