coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: MAINTAINERS: Add myself
by Nick Vaccaro (Code Review) 29 Apr '21

29 Apr '21

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52743 ) Change subject: MAINTAINERS: Add myself ...................................................................... MAINTAINERS: Add myself Change-Id: Ibfa877fc328d64be4de372fb7f4401717158ed9e Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M MAINTAINERS 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/52743/1 diff --git a/MAINTAINERS b/MAINTAINERS index 3514690..07df3f3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -278,6 +278,7 @@ GOOGLE VOLTEER MAINBOARDS M: Tim Wawrzynczak <twawrzynczak(a)chromium.org> +M: Nick Vaccaro <nvaccaro(a)chromium.org> S: Maintained F: src/mainboard/google/volteer/ -- To view, visit https://review.coreboot.org/c/coreboot/+/52743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfa877fc328d64be4de372fb7f4401717158ed9e Gerrit-Change-Number: 52743 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: libpayload: i8042: Enable keyboard translation by defualt on exit
by Furquan Shaikh (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Nico Huber, Duncan Laurie, Tim Wawrzynczak. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52737 ) Change subject: libpayload: i8042: Enable keyboard translation by defualt on exit ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > Would need to just use CHROMEOS since this is inside libpayload kconfig, but that could certainly wo […] Based on the discussion on CB:47594, it looks like it is safe to set the default to set2+translate. So, going with a default of 'y' seems fine to me. -- To view, visit https://review.coreboot.org/c/coreboot/+/52737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I25dfe3f425a5bb57e97476564886672b707aa3bd Gerrit-Change-Number: 52737 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <duncan(a)iceblink.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-CC: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Duncan Laurie <duncan(a)iceblink.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 28 Apr 2021 21:15:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Duncan Laurie <duncan(a)iceblink.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amd/cezanne: Add telemetry setting to UPD
by Felix Held (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang, chris wang. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52733 ) Change subject: amd/cezanne: Add telemetry setting to UPD ...................................................................... Patch Set 1: (1 comment) File src/vendorcode/amd/fsp/cezanne/FspmUpd.h: https://review.coreboot.org/c/coreboot/+/52733/comment/091e7732_a70eda7d PS1, Line 106: 0x04C7 > We have SO many unaligned fields. […] oh, yeah there are more other unaligned fields than i thought; looks like i didn't remember to check that when integrating the upd headers for cezanne. i'd avoid moving already used upd fields around, since the binary interface changes are always a bit of a pain, so i'd probably avoid that if possible. things we should write down somewhere as a check-list to not make the same mistake in a next generation. not sure what the best action would be now though. it would be nicer to have everything aligned, but i'm also not completely convinced that it's worth breaking the binary interface -- To view, visit https://review.coreboot.org/c/coreboot/+/52733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dd3643e9c582a41192130901935eef321b2c67e Gerrit-Change-Number: 52733 Gerrit-PatchSet: 1 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Wed, 28 Apr 2021 21:13:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/mtrr: Prefer keeping WRCOMB requests to reserving MTRRs for OS
by Furquan Shaikh (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Tim Wawrzynczak. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52642 ) Change subject: cpu/x86/mtrr: Prefer keeping WRCOMB requests to reserving MTRRs for OS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I108c743d25baaeae1860732601cc7abda2f05932 Gerrit-Change-Number: 52642 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 28 Apr 2021 21:04:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: increase SMM_CODE_SEGMENT_SIZE
by Nick Vaccaro (Code Review) 29 Apr '21

29 Apr '21

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52742 ) Change subject: cpu/x86/smm: increase SMM_CODE_SEGMENT_SIZE ...................................................................... cpu/x86/smm: increase SMM_CODE_SEGMENT_SIZE Increase SMM_CODE_SEGMENT_SIZE to 0x10f00 to accomodate for the permanent SMM handler's size on tiger lake. BUG=b:186661594 TEST=`emerge-volteer coreboot chromeos-bootimage`, flash voxel and verify it boots to kernel. Change-Id: Ie9fdae7cdf812d92a4d3b61368de884f4e55aa3a Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/cpu/x86/smm/smm_module_loader.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/52742/1 diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index e3b8417..2e046f3 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -10,7 +10,7 @@ #include <security/intel/stm/SmmStm.h> #define FXSAVE_SIZE 512 -#define SMM_CODE_SEGMENT_SIZE 0x10000 +#define SMM_CODE_SEGMENT_SIZE 0x10f00 /* FXSAVE area during relocation. While it may not be strictly needed the SMM stub code relies on the FXSAVE area being non-zero to enable SSE instructions within SMM mode. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/52742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9fdae7cdf812d92a4d3b61368de884f4e55aa3a Gerrit-Change-Number: 52742 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: cpu/x86/mtrr: Prefer keeping WRCOMB requests to reserving MTRRs for OS
by Tim Wawrzynczak (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Tim Wawrzynczak. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52642 to look at the new patch set (#2). Change subject: cpu/x86/mtrr: Prefer keeping WRCOMB requests to reserving MTRRs for OS ...................................................................... cpu/x86/mtrr: Prefer keeping WRCOMB requests to reserving MTRRs for OS Given that keeping 2 MTRRs reserved for the OS is more of an advisory, the MTRR calculation should fulfill WRCOMB requests if possible instead of reserving them. Change-Id: I108c743d25baaeae1860732601cc7abda2f05932 Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/cpu/x86/mtrr/mtrr.c 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/52642/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I108c743d25baaeae1860732601cc7abda2f05932 Gerrit-Change-Number: 52642 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/mtrr: Prefer keeping WRCOMB requests to reserving MTRRs for OS
by Furquan Shaikh (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Tim Wawrzynczak. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52642 ) Change subject: cpu/x86/mtrr: Prefer keeping WRCOMB requests to reserving MTRRs for OS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Needs update? -- To view, visit https://review.coreboot.org/c/coreboot/+/52642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I108c743d25baaeae1860732601cc7abda2f05932 Gerrit-Change-Number: 52642 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 28 Apr 2021 19:59:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/mtrr: Use a Kconfig for reserving MTRRs for OS
by Furquan Shaikh (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Nico Huber, Patrick Rudolph, Stefan Reinauer, Tim Wawrzynczak, Subrata Banik, Arthur Heymans, Aaron Durbin, EricR Lai. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52522 ) Change subject: cpu/x86/mtrr: Use a Kconfig for reserving MTRRs for OS ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52522 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ae2851248c95fd516627b101ebcb36ec59c29c3 Gerrit-Change-Number: 52522 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 28 Apr 2021 19:59:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/google/chromeos: Refactor GNVS init
by Furquan Shaikh (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Martin Roth, Kyösti Mälkki. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50612 ) Change subject: vc/google/chromeos: Refactor GNVS init ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e92206561812eb3dc69739df49b6c3a93853858 Gerrit-Change-Number: 50612 Gerrit-PatchSet: 7 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 28 Apr 2021 19:56:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vc/google/chromeos: Refactor GNVS init
by Tim Wawrzynczak (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Furquan Shaikh, Martin Roth, Kyösti Mälkki. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50612 ) Change subject: vc/google/chromeos: Refactor GNVS init ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/50612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7e92206561812eb3dc69739df49b6c3a93853858 Gerrit-Change-Number: 50612 Gerrit-PatchSet: 7 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 28 Apr 2021 18:42:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021