Attention is currently required from: Henry Sun, Frank Chu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52565 )
Change subject: mb/google/dedede/var/galith: Support Wifi SAR for DVT phase
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/mainboard/google/dedede/variants/galtic/variant.c:
https://review.coreboot.org/c/coreboot/+/52565/comment/2ea598ad_ae8afac1
PS1, Line 8: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_DISABLED)))
: return "wifi_sar-galtic.hex";
> that's right, this modification is to consider upgrading different cases in the future and for minim […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/52565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bb76c207ef033f81ecdd57849535b8ac8d13ae
Gerrit-Change-Number: 52565
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 00:02:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Peter Lemenkov, Alexander Couzens, Patrick Rudolph.
amersel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52659 )
Change subject: mb/lenovo/w541: Add Thinkpad W541
......................................................................
Patch Set 9:
(3 comments)
Patchset:
PS8:
> Great, we almost there! I think the only missing piece is libgfxinit issue (probably gma-mainboard. […]
Since you mentioned it could be an issue with ports on `gma-mainboard.ads`, I tried VGA and noticed that libgfxinit is working on VGA but still not on eDP and DisplayPort.
Looking up a schematic of the W541, it looks like VGA is connected the Southbridge while the other ports appear connected to the CPU. I wonder if we need to configure this differently to work.
http://laptop-schematics.com/userfiles/schm/12291_0.png
File src/mainboard/lenovo/w541/board_info.txt:
https://review.coreboot.org/c/coreboot/+/52659/comment/13347468_e338202c
PS8, Line 2: FIXME: put ROM package, ROM socketed, ROM protocol, Flashrom support
> One more thing. […]
Done
File src/mainboard/lenovo/w541/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52659/comment/f2bc8123_19b927ee
PS8, Line 8: .up_delay_ms = 2000,
> I'm afraid these values are wrong. I've recalculated them and I believ they should be […]
Done.
Unfortunately, this didn't fix the libgfxinit issue. I was trying several other values earlier which I grabbed from the data.vbt but none of them allowed my display to show before reaching the kernel.
That said, I do have a non-OEM eDP panel installed so I wonder if that's the issue.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 9
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 23:43:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth.
Hello Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52747
to look at the new patch set (#3).
Change subject: util/sconfig: Add support for discontiguous FW_CONFIG fields
......................................................................
util/sconfig: Add support for discontiguous FW_CONFIG fields
Sooner or later, some board was going to need extra FW_CONFIG bits for
a field that was already in production, so this patch adds support for
adding extra (unused) bits to a field.
The extra are appended via a syntax like:
`field FIELD_NAME START0 END0 | START1 END1 | START2 END2 ...`
and the suffixed bits are all treated as if they are contiguous when
defining option values.
BUG=b:185190978
TEST=Modified volteer fw_config to the following:
field AUDIO 8 10 | 29 29 | 31 31
option NONE 0
option MAX98357_ALC5682I_I2S 1
option MAX98373_ALC5682I_I2S 2
option MAX98373_ALC5682_SNDW 3
option MAX98373_ALC5682I_I2S_UP4 4
option MAX98360_ALC5682I_I2S 5
option RT1011_ALC5682I_I2S 6
option AUDIO_FOO 7
option AUDIO_BAR 8
option AUDIO_QUUX 9
option AUDIO_BLAH1 10
option AUDIO_BLAH2 15
option AUDIO_BLAH3 16
option AUDIO_BLAH4 31
end
which yielded (in static_fw_config.h):
FW_CONFIG_FIELD_AUDIO_MASK 0xa0000700
FW_CONFIG_FIELD_AUDIO_OPTION_NONE_VALUE 0x0
FW_CONFIG_FIELD_AUDIO_OPTION_MAX98357_ALC5682I_I2S_VALUE 0x100
FW_CONFIG_FIELD_AUDIO_OPTION_MAX98373_ALC5682I_I2S_VALUE 0x200
FW_CONFIG_FIELD_AUDIO_OPTION_MAX98373_ALC5682_SNDW_VALUE 0x300
FW_CONFIG_FIELD_AUDIO_OPTION_MAX98373_ALC5682I_I2S_UP4_VALUE 0x400
FW_CONFIG_FIELD_AUDIO_OPTION_MAX98360_ALC5682I_I2S_VALUE 0x500
FW_CONFIG_FIELD_AUDIO_OPTION_RT1011_ALC5682I_I2S_VALUE 0x600
FW_CONFIG_FIELD_AUDIO_OPTION_AUDIO_FOO_VALUE 0x700
FW_CONFIG_FIELD_AUDIO_OPTION_AUDIO_BAR_VALUE 0x20000000
FW_CONFIG_FIELD_AUDIO_OPTION_AUDIO_QUUX_VALUE 0x20000100
FW_CONFIG_FIELD_AUDIO_OPTION_AUDIO_BLAH1_VALUE 0x20000200
FW_CONFIG_FIELD_AUDIO_OPTION_AUDIO_BLAH2_VALUE 0x20000700
FW_CONFIG_FIELD_AUDIO_OPTION_AUDIO_BLAH3_VALUE 0x80000000
FW_CONFIG_FIELD_AUDIO_OPTION_AUDIO_BLAH4_VALUE 0xa0000700
Change-Id: I5ed76706347ee9642198efc77139abdc3af1b8a6
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
---
M util/sconfig/lex.yy.c_shipped
M util/sconfig/main.c
M util/sconfig/sconfig.h
M util/sconfig/sconfig.l
M util/sconfig/sconfig.tab.c_shipped
M util/sconfig/sconfig.tab.h_shipped
M util/sconfig/sconfig.y
7 files changed, 494 insertions(+), 360 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/52747/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52747
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ed76706347ee9642198efc77139abdc3af1b8a6
Gerrit-Change-Number: 52747
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth.
Hello Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52747
to look at the new patch set (#2).
Change subject: util/sconfig: Add support for discontiguous FW_CONFIG fields
......................................................................
util/sconfig: Add support for discontiguous FW_CONFIG fields
Sooner or later, some board was going to need extra FW_CONFIG bits for
a field that was already in production, so this patch adds support for
adding extra (unused) bits to a field.
The extra are appended via a syntax like:
`field FIELD_NAME START0 END0 | START1 END1 | START2 END2 ...`
and the suffixed bits are all treated as if they are contiguous when
defining option values.
BUG=b:185190978
TEST=Modified volteer fw_config to the following:
field AUDIO 8 10 | 29 29 | 31 31
option NONE 0
option MAX98357_ALC5682I_I2S 1
option MAX98373_ALC5682I_I2S 2
option MAX98373_ALC5682_SNDW 3
option MAX98373_ALC5682I_I2S_UP4 4
option MAX98360_ALC5682I_I2S 5
option RT1011_ALC5682I_I2S 6
option AUDIO_FOO 7
option AUDIO_BAR 8
option AUDIO_QUUX 9
option AUDIO_BLAH1 10
option AUDIO_BLAH2 15
option AUDIO_BLAH3 16
option AUDIO_BLAH4 31
end
which yielded (in static_fw_config.h):
Change-Id: I5ed76706347ee9642198efc77139abdc3af1b8a6
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
---
M util/sconfig/lex.yy.c_shipped
M util/sconfig/main.c
M util/sconfig/sconfig.h
M util/sconfig/sconfig.l
M util/sconfig/sconfig.tab.c_shipped
M util/sconfig/sconfig.tab.h_shipped
M util/sconfig/sconfig.y
7 files changed, 494 insertions(+), 360 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/52747/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52747
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ed76706347ee9642198efc77139abdc3af1b8a6
Gerrit-Change-Number: 52747
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alexander Couzens, Patrick Rudolph, amersel.
Hello build bot (Jenkins), Alexander Couzens, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52659
to look at the new patch set (#9).
Change subject: mb/lenovo/w541: Add Thinkpad W541
......................................................................
mb/lenovo/w541: Add Thinkpad W541
Adds support for the Thinkpad W541 based on Peter Lemenkov's initial W541 port.
Compiled and tested with SeaBIOS booting into Arch Linux 5.10.32-lts using a VGA BIOS ROM extracted using VBiosFinder.
The Haswell mrc.bin blob is required.
Tested working:
- SATA SSD
- SATA DVD drive
- All USB ports
- Sdcard
- Speakers/headphone jack
- Keyboard/touchpad
- VGA
- mini DisplayPort (Thunderbolt untested)
- eDP laptop screen
- Camera
- Smartcard reader
- Internal flashing when IFD is unlocked
- Thinkpad basic dock
- CMOS options
- WLAN
- Bluetooth
- Ethernet
- Using me_cleaner
Not working:
- libgfxinit
- Keyboard backlight
- Each boot takes 20s
Signed-off-by: Amersel <amersel(a)runbox.me>
Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
---
A src/mainboard/lenovo/w541/Kconfig
A src/mainboard/lenovo/w541/Kconfig.name
A src/mainboard/lenovo/w541/Makefile.inc
A src/mainboard/lenovo/w541/acpi/ec.asl
A src/mainboard/lenovo/w541/acpi/platform.asl
A src/mainboard/lenovo/w541/acpi/superio.asl
A src/mainboard/lenovo/w541/acpi_tables.c
A src/mainboard/lenovo/w541/board_info.txt
A src/mainboard/lenovo/w541/cmos.default
A src/mainboard/lenovo/w541/cmos.layout
A src/mainboard/lenovo/w541/data.vbt
A src/mainboard/lenovo/w541/devicetree.cb
A src/mainboard/lenovo/w541/dsdt.asl
A src/mainboard/lenovo/w541/gma-mainboard.ads
A src/mainboard/lenovo/w541/gpio.c
A src/mainboard/lenovo/w541/hda_verb.c
A src/mainboard/lenovo/w541/mainboard.c
A src/mainboard/lenovo/w541/romstage.c
A src/mainboard/lenovo/w541/smihandler.c
19 files changed, 767 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/52659/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/52659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia43070f51bba3cf59ba9b7d9e29e4e778efbeb08
Gerrit-Change-Number: 52659
Gerrit-PatchSet: 9
Gerrit-Owner: amersel
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: amersel
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Felix Held.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52680 )
Change subject: mb/google/guybrush: Set system_config to 2 for guybrush boards
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/52680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ce2acb3b4ed51aa9a0aa379ed125f0b04f04d31
Gerrit-Change-Number: 52680
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 28 Apr 2021 23:09:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment