Attention is currently required from: Timofey Komarov, Felix Singer, Nico Huber, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Allow to use Amber Lake FSP
......................................................................
Patch Set 5:
(2 comments)
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/8eb4f312_7a66bdce
PS5, Line 19: select SOC_INTEL_COMMON_SKYLAKE_BASE
> You can also select SKYLAKE_SOC_PCH_H here.
Good point! When this was SOC_INTEL_AMBERLAKE, it also included actual Amber Lake parts, which are not PCH-H. But now that this is SOC_INTEL_SKYLAKE_LGA1151_V2, it is always paired with PCH-H (see help text)
https://review.coreboot.org/c/coreboot/+/52692/comment/64cf8458_489f2d67
PS5, Line 21: Intel chipsets with LGA1151v2 socket (e.g., B365, H310C, Z370) support
Hmm, chipsets don't have a socket. How about:
Selected by mainboards with a LGA1151 v2 socket and a Z370, H310C or B365 PCH
--
To view, visit https://review.coreboot.org/c/coreboot/+/52692
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6b9c676da55088cb5a12a218ea58d349ee440c
Gerrit-Change-Number: 52692
Gerrit-PatchSet: 5
Gerrit-Owner: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 18:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Stefan Reinauer, David Hendricks, Subrata Banik, Ron Minnich.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52735 )
Change subject: doc/relnotes/4.14: add Intel Xeon-SP support status change
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File Documentation/releases/coreboot-4.14-relnotes.md:
https://review.coreboot.org/c/coreboot/+/52735/comment/280c9bfa_6df3d083
PS1, Line 55: became
nit: I'd say `is now considered`
--
To view, visit https://review.coreboot.org/c/coreboot/+/52735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibead1c75bb4e41fedc2799366b5b006d76fc8f4e
Gerrit-Change-Number: 52735
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 18:38:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, chris wang, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52680 )
Change subject: mb/google/guybrush: Set system_config to 2 for guybrush boards
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ce2acb3b4ed51aa9a0aa379ed125f0b04f04d31
Gerrit-Change-Number: 52680
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 28 Apr 2021 18:36:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52715 )
Change subject: drivers/intel/gma/Kconfig: Simplify CFL/WHL/CML conditions
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52715/comment/5cc9489b_e16f4b13
PS1, Line 8:
> NB. It works like this because CANNONLAKE in coreboot means […]
Yeah, we might as well rename things then.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52715
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id56761b2a57754b8f8d726a4bd2674ffa6fd1159
Gerrit-Change-Number: 52715
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 18:33:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Martin Roth has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/52741 )
Change subject: mb/google/mancomb: Add SPI configuration to Kconfig
......................................................................
mb/google/mancomb: Add SPI configuration to Kconfig
Mancomb will have the boot flash on a daughterboard, so the SPI speeds
need to be low for now.
BUG=b:182211161
TEST=Build
Signed-off-by: Martin Roth <martinroth(a)chromium.org>
Change-Id: Icacb68d65fb414197d7b8d45799527d8d2568dc7
---
M src/mainboard/google/mancomb/Kconfig
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/52741/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52741
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icacb68d65fb414197d7b8d45799527d8d2568dc7
Gerrit-Change-Number: 52741
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: newpatchset