Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52737 )
Change subject: libpayload: i8042: Enable keyboard translation by defualt on exit
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Another option would be to set the default to `n`, but then select it for `EC_GOOGLE_CHROMEEC`, sinc […]
Would need to just use CHROMEOS since this is inside libpayload kconfig, but that could certainly work for chrome os to keep the default for everyone else set to translation disabled.
Anyone using libpayload on a recent chromebook would also need to set this to 'n' to get a working keyboard.
I'm happy to do whatever works for upstream.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52737
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25dfe3f425a5bb57e97476564886672b707aa3bd
Gerrit-Change-Number: 52737
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <duncan(a)iceblink.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 18:04:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, chris wang, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52733 )
Change subject: amd/cezanne: Add telemetry setting to UPD
......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/cezanne/chip.h:
https://review.coreboot.org/c/coreboot/+/52733/comment/9a028f74_5d3d99b6
PS1, Line 73: uint32_t telemetry_vddcrvddfull_scale_current;
> i'd add _mA to match picasso and have the unit right in the struct element name; same in line 75
++
File src/vendorcode/amd/fsp/cezanne/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52733/comment/c6ce5ae3_ef56664d
PS1, Line 106: 0x04C7
> see my comment about the alignment on the fsp-side patch. […]
We have SO many unaligned fields. I think that we should either care about all of them, or not care about this one. If we care, we should really update the entire structure to be aligned(which is my preference).
The FSP build gives warnings about the unaligned PCDs, so we should be able to halt on that if someone adds an unaligned PCD in the future.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52733
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dd3643e9c582a41192130901935eef321b2c67e
Gerrit-Change-Number: 52733
Gerrit-PatchSet: 1
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:52:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Varshit B Pandya, Anil Kumar K, Shaunak Saha, Jamie Ryu, Selma Bensaid, Maulik V Vaghela, Nathan D Ciobanu, Subrata Banik, Bernardo Perez Priego.
Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52681 )
Change subject: mb/intel/adlrvp: Set SKUID for adlrvp to 255
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
> @Nathan. What do u suggest ? Could u provide a change for model.yaml to remove SKU ID . […]
Yes, please make the model.yaml change instead.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52681
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e501f995988b95c480637599412c8ddea0814dc
Gerrit-Change-Number: 52681
Gerrit-PatchSet: 3
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Nathan D Ciobanu <nathan.d.ciobanu(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Nathan D Ciobanu <nathan.d.ciobanu(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:51:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anil Kumar K <anil.kumar.k(a)intel.com>
Comment-In-Reply-To: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels
......................................................................
Patch Set 3:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/1ad154fa_b7390aa4
PS3, Line 101: if(CONFIG(TROGDOR_HAS_MIPI_PANEL))
space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/9490028a_63a4ba68
PS3, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/489fe61d_0ac69fe5
PS3, Line 172: write32(&dsi0->int_ctrl,0x0);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/36d3e989_803777e3
PS3, Line 210: printk(BIOS_ERR,
Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/e1737f05_55bfdde0
PS3, Line 281: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/97c52214_6962d0ef
PS3, Line 289: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/9487c056_39cfb244
PS3, Line 292: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/a9a51ecb_966f2413
PS3, Line 299: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/a8f9f481_3ce4375e
PS3, Line 302: wmb();
memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/51adebd5_61557fc5
PS3, Line 319: write32(&dsi0->int_ctrl,0x0);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/92b618e0_ace35fa0
PS3, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/151cdaf9_f122e87d
PS3, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/a13ab787_9d5fd195
PS3, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/cc37c4f7_864463de
PS3, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118013):
https://review.coreboot.org/c/coreboot/+/52662/comment/06424a0a_cac68b4f
PS3, Line 343: if(!pinfo && !pinfo->init_cmd)
space required before the open parenthesis '('
--
To view, visit https://review.coreboot.org/c/coreboot/+/52662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id698265a4e2399ad1c26e026e9a5f8ecd305467f
Gerrit-Change-Number: 52662
Gerrit-PatchSet: 3
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:48:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Chris Wang, chris wang.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52736 )
Change subject: mb/google/guybrush: update the telemetry setting
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52736
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib92bb169693634665fc8e165837e7ae3e6137bcf
Gerrit-Change-Number: 52736
Gerrit-PatchSet: 1
Gerrit-Owner: chris wang <Chris.Wang(a)amd.com>
Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: chris wang <Chris.Wang(a)amd.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:48:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Ravi kumar, Martin Roth, mturney mturney, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52376 )
Change subject: HACK payloads: Add libpci for arm arch HACK
......................................................................
Patch Set 5:
(14 comments)
File payloads/libpayload/drivers/pci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/a9ce2acf_76f019fd
PS5, Line 57: #define PCIE_ATU_TYPE_IO (0x2 << 0)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/010ced98_0cadfca4
PS5, Line 57: #define PCIE_ATU_TYPE_IO (0x2 << 0)
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/8e4727da_062c5acb
PS5, Line 84: static void dw_pcie_writel_ob_unroll(void * atu_base,
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/150d22b0_ce1c51de
PS5, Line 224: if (current_bus == 1)
Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/3ba09cfe_e91cd69e
PS5, Line 231:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/0eb36b4c_be2be634
PS5, Line 248: io_size);
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/0cff3e42_8eb6279a
PS5, Line 253: u8 pci_read_config8(u32 dev, u16 reg)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/b83926ba_7f561830
PS5, Line 254: {
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/466a4622_6b5ba549
PS5, Line 255: int val, offset = reg;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/38a0c334_f3c6c93f
PS5, Line 264: qcom_read_config(NVME_PCIE_BDF(1,0,0), reg, &val, 16);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/e160f56f_763fbd42
PS5, Line 264: qcom_read_config(NVME_PCIE_BDF(1,0,0), reg, &val, 16);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/3420cffe_2680b18d
PS5, Line 268: u32 pci_read_config32(u32 dev, u16 reg)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/32d3492d_8e98a233
PS5, Line 343: u16 reg = 0x10+ (bar * 4);
need consistent spacing around '+' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118007):
https://review.coreboot.org/c/coreboot/+/52376/comment/cf085ed4_40f9bf22
PS5, Line 344: val = pci_read_config32(dev, reg );
space prohibited before that close parenthesis ')'
--
To view, visit https://review.coreboot.org/c/coreboot/+/52376
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9850125d27da9d7bec3fc3af9995c6db240b4b3d
Gerrit-Change-Number: 52376
Gerrit-PatchSet: 5
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:47:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment