Attention is currently required from: Nico Huber, Furquan Shaikh, Duncan Laurie.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52737 )
Change subject: libpayload: i8042: Enable keyboard translation by defualt on exit
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Another option would be to set the default to `n`, but then select it for `EC_GOOGLE_CHROMEEC`, since that is what is exporting the keymap in set1 format
--
To view, visit https://review.coreboot.org/c/coreboot/+/52737
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25dfe3f425a5bb57e97476564886672b707aa3bd
Gerrit-Change-Number: 52737
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <duncan(a)iceblink.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Duncan Laurie <duncan(a)iceblink.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:46:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar, Martin Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52371 )
Change subject: sc7280: Add GSI FW download support
......................................................................
Patch Set 5:
(11 comments)
File src/soc/qualcomm/sc7280/include/soc/qupv3_config.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/990e90ab_dce28e7e
PS5, Line 77: {
open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/845f221b_45523e9d
PS5, Line 79: uint32_t iram_dword1; /* word 1 of a single IRAM firmware entry */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/3bb778ce_4763227a
PS5, Line 83: {
open brace '{' following struct go on the same line
File src/soc/qualcomm/sc7280/qupv3_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/ac6ced17_19d5a0e6
PS5, Line 204: write32(®s->gsi_periph_base_lsb,0);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/2ecc2e31_ab5c7c85
PS5, Line 205: write32(®s->gsi_periph_base_msb,0);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/77dadef7_2bb30aa9
PS5, Line 210: if (fwIep[i].offset < GSI_REG_BASE_SIZE) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/cb54637b_4f9d4df9
PS5, Line 221: memcpy((®s->gsi_inst_ramn),(void *)fwIRam,
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/98b151ba_c8ae2909
PS5, Line 223: setbits_le32(®s->gsi_mcs_cfg, GSI_MCS_CFG_MCS_ENABLE_BMSK );
space prohibited before that close parenthesis ')'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/17e8d74e_6556b278
PS5, Line 224: setbits_le32(®s->gsi_cfg, GSI_CFG_DOUBLE_MCS_CLK_FREQ_BMSK | GSI_CFG_GSI_ENABLE_BMSK);
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/1d9bbab4_82cbeafe
PS5, Line 226: write32(®s->gsi_ee_n_scratch_0_addr,0x0);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118002):
https://review.coreboot.org/c/coreboot/+/52371/comment/49a0ce30_3cffc1fe
PS5, Line 227: write32(®s->ee_n_gsi_ee_generic_cmd,0x81);
space required after that ',' (ctx:VxV)
--
To view, visit https://review.coreboot.org/c/coreboot/+/52371
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b966a6a074fc43c62d2639da9cf68b083cc7319
Gerrit-Change-Number: 52371
Gerrit-PatchSet: 5
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:45:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, mturney mturney, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49392 )
Change subject: sc7280: shrm.elf loading changes
......................................................................
Patch Set 33:
(1 comment)
File src/soc/qualcomm/sc7280/shrm_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117992):
https://review.coreboot.org/c/coreboot/+/49392/comment/d5bf118b_2d8f73b2
PS33, Line 9: void shrm_fw_load_reset()
Bad function definition - void shrm_fw_load_reset() should probably be void shrm_fw_load_reset(void)
--
To view, visit https://review.coreboot.org/c/coreboot/+/49392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44484573a829eaefbd34907c6fe78d427506a762
Gerrit-Change-Number: 49392
Gerrit-PatchSet: 33
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 28 Apr 2021 17:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Varshit B Pandya, Shaunak Saha, Jamie Ryu, Selma Bensaid, Maulik V Vaghela, Jack Rosenthal, Nathan D Ciobanu, Subrata Banik, Bernardo Perez Priego, Anil Kumar K.
Hello Bora Guvendik, Shaunak Saha, build bot (Jenkins), Wonkyu Kim, Selma Bensaid, Maulik V Vaghela, Jack Rosenthal, Subrata Banik, Bernardo Perez Priego, Anil Kumar K, Varshit B Pandya, Jamie Ryu, Nathan D Ciobanu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52681
to look at the new patch set (#3).
Change subject: mb/intel/adlrvp: Set SKUID for adlrvp to 255
......................................................................
mb/intel/adlrvp: Set SKUID for adlrvp to 255
This change is required for mosys and cros_config to work
Branch=None
Test=build and boot ADL-M RVP. On DUT execute cros_config / name outputs "adlrvp"
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: I8e501f995988b95c480637599412c8ddea0814dc
---
M src/mainboard/intel/adlrvp/mainboard.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/52681/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52681
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e501f995988b95c480637599412c8ddea0814dc
Gerrit-Change-Number: 52681
Gerrit-PatchSet: 3
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Nathan D Ciobanu <nathan.d.ciobanu(a)intel.com>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Jack Rosenthal <jrosenth(a)chromium.org>
Gerrit-Attention: Nathan D Ciobanu <nathan.d.ciobanu(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49768
to look at the new patch set (#32).
Change subject: sc7280: cpucp loading changes
......................................................................
sc7280: cpucp loading changes
Change-Id: Idac22c8cb231658616999bc577bdf49f9aa7ae74
Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
---
M src/soc/qualcomm/common/include/soc/symbols_common.h
M src/soc/qualcomm/sc7280/Makefile.inc
A src/soc/qualcomm/sc7280/cpucp_load_reset.c
A src/soc/qualcomm/sc7280/include/soc/cpucp.h
M src/soc/qualcomm/sc7280/memlayout.ld
M src/soc/qualcomm/sc7280/soc.c
6 files changed, 73 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/49768/32
--
To view, visit https://review.coreboot.org/c/coreboot/+/49768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idac22c8cb231658616999bc577bdf49f9aa7ae74
Gerrit-Change-Number: 49768
Gerrit-PatchSet: 32
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49767
to look at the new patch set (#32).
Change subject: sc7280: aop loading changes
......................................................................
sc7280: aop loading changes
Change-Id: I90b0f48e15df390970e027bff2065b7a89b14cec
Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
---
M src/soc/qualcomm/sc7280/Makefile.inc
A src/soc/qualcomm/sc7280/aop_load_reset.c
A src/soc/qualcomm/sc7280/include/soc/aop.h
M src/soc/qualcomm/sc7280/memlayout.ld
M src/soc/qualcomm/sc7280/mmu.c
M src/soc/qualcomm/sc7280/soc.c
6 files changed, 59 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/49767/32
--
To view, visit https://review.coreboot.org/c/coreboot/+/49767
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90b0f48e15df390970e027bff2065b7a89b14cec
Gerrit-Change-Number: 49767
Gerrit-PatchSet: 32
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, mturney mturney, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, mturney mturney, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49392
to look at the new patch set (#33).
Change subject: sc7280: shrm.elf loading changes
......................................................................
sc7280: shrm.elf loading changes
Change-Id: I44484573a829eaefbd34907c6fe78d427506a762
Signed-off-by: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
---
M src/mainboard/google/herobrine/romstage.c
M src/soc/qualcomm/common/include/soc/symbols_common.h
M src/soc/qualcomm/sc7280/Makefile.inc
A src/soc/qualcomm/sc7280/include/soc/shrm.h
M src/soc/qualcomm/sc7280/memlayout.ld
A src/soc/qualcomm/sc7280/shrm_load_reset.c
6 files changed, 47 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/49392/33
--
To view, visit https://review.coreboot.org/c/coreboot/+/49392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44484573a829eaefbd34907c6fe78d427506a762
Gerrit-Change-Number: 49392
Gerrit-PatchSet: 33
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset