coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: amd/cezanne: Add telemetry setting to UPD
by chris wang (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang, Felix Held. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52733 ) Change subject: amd/cezanne: Add telemetry setting to UPD ...................................................................... Patch Set 3: (2 comments) File src/soc/amd/cezanne/chip.h: https://review.coreboot.org/c/coreboot/+/52733/comment/55e15c41_f28cbeae PS1, Line 73: uint32_t telemetry_vddcrvddfull_scale_current; > ++ Done File src/soc/amd/cezanne/fsp_m_params.c: https://review.coreboot.org/c/coreboot/+/52733/comment/f8cdcd7c_c73ea8b5 PS1, Line 121: /* telemetry settings */ > "voltage regulator telemetry settings" would be more specific here Done -- To view, visit https://review.coreboot.org/c/coreboot/+/52733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dd3643e9c582a41192130901935eef321b2c67e Gerrit-Change-Number: 52733 Gerrit-PatchSet: 3 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 28 Apr 2021 23:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: update the telemetry setting
by chris wang (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Chris Wang, chris wang. Hello build bot (Jenkins), Martin Roth, Chris Wang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52736 to look at the new patch set (#3). Change subject: mb/google/guybrush: update the telemetry setting ...................................................................... mb/google/guybrush: update the telemetry setting Update the telemetry setting for guybrush vddcrvddfull_scale_current : 92165 #mA ddcrvddoffset : 412 vddcrsocfull_scale_current : 30233 #mA vddcrsocoffset : 457 BUG=b:182754399 TEST=Build, boot to guybrush Change-Id: Ib92bb169693634665fc8e165837e7ae3e6137bcf Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> --- M src/mainboard/google/guybrush/variants/guybrush/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/52736/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib92bb169693634665fc8e165837e7ae3e6137bcf Gerrit-Change-Number: 52736 Gerrit-PatchSet: 3 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: amd/cezanne: Add telemetry setting to UPD
by chris wang (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52733 to look at the new patch set (#3). Change subject: amd/cezanne: Add telemetry setting to UPD ...................................................................... amd/cezanne: Add telemetry setting to UPD Add telemetry setting to UPD, the value comes from the SDLE testing. BUG=b:182754399 TEST=Build & Boot guybrush Cq-Depend: chrome-internal:3787638 Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: I9dd3643e9c582a41192130901935eef321b2c67e --- M src/soc/amd/cezanne/chip.h M src/soc/amd/cezanne/fsp_m_params.c M src/vendorcode/amd/fsp/cezanne/FspmUpd.h 3 files changed, 23 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/52733/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/52733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dd3643e9c582a41192130901935eef321b2c67e Gerrit-Change-Number: 52733 Gerrit-PatchSet: 3 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/adlrvp_m: Disable Type-C xDCI
by Bernardo Perez Priego (Code Review) 29 Apr '21

29 Apr '21

Bernardo Perez Priego has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52744 ) Change subject: mb/intel/adlrvp_m: Disable Type-C xDCI ...................................................................... mb/intel/adlrvp_m: Disable Type-C xDCI Disabling this pci 0d.1 device since it is not required. Signed-off-by: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Change-Id: Iccdf38111e3961ba887829abfa4146a9b37df9be --- M src/mainboard/intel/adlrvp/devicetree_m.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/52744/1 diff --git a/src/mainboard/intel/adlrvp/devicetree_m.cb b/src/mainboard/intel/adlrvp/devicetree_m.cb index ec33ee1..51d97bc 100644 --- a/src/mainboard/intel/adlrvp/devicetree_m.cb +++ b/src/mainboard/intel/adlrvp/devicetree_m.cb @@ -164,7 +164,7 @@ device pci 09.0 off end # NPK device pci 0a.0 off end # Crash-log SRAM device pci 0d.0 on end # USB xHCI - device pci 0d.1 on end # USB xDCI (OTG) + device pci 0d.1 off end # USB xDCI (OTG) device pci 0d.2 on end # TBT DMA0 device pci 0d.3 on end # TBT DMA1 device pci 0e.0 off end # VMD -- To view, visit https://review.coreboot.org/c/coreboot/+/52744 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iccdf38111e3961ba887829abfa4146a9b37df9be Gerrit-Change-Number: 52744 Gerrit-PatchSet: 1 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/mancomb: Add STAPM values to overridetree
by chris wang (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Martin Roth, Chris Wang. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52709 ) Change subject: mb/google/mancomb: Add STAPM values to overridetree ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/mancomb/variants/mancomb/overridetree.cb: https://review.coreboot.org/c/coreboot/+/52709/comment/bfb5c4c7_37f81198 PS1, Line 3: register "system_configuration" = "3" > This isn't wrong here, but it should go in the top level devicetree since it's going to be the same […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/52709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ed76e5212a5a8b5fb4fcc3d6884ceff82377b7 Gerrit-Change-Number: 52709 Gerrit-PatchSet: 2 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 28 Apr 2021 22:39:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/mancomb: Add STAPM values to overridetree
by chris wang (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Chris Wang, chris wang. Hello build bot (Jenkins), Martin Roth, Chris Wang, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52709 to look at the new patch set (#2). Change subject: mb/google/mancomb: Add STAPM values to overridetree ...................................................................... mb/google/mancomb: Add STAPM values to overridetree follow the FP6 IRM(#56328) to set the stapm parameter. and allow other mancomb variants boards can customize those parameters. BUG=b:1181157669 TEST=build. Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Ib3ed76e5212a5a8b5fb4fcc3d6884ceff82377b7 --- M src/mainboard/google/mancomb/variants/baseboard/devicetree.cb M src/mainboard/google/mancomb/variants/mancomb/overridetree.cb 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/52709/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ed76e5212a5a8b5fb4fcc3d6884ceff82377b7 Gerrit-Change-Number: 52709 Gerrit-PatchSet: 2 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/adlrvp: Align chromeos.fmd file with Brya
by Furquan Shaikh (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52732 ) Change subject: mb/intel/adlrvp: Align chromeos.fmd file with Brya ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52732/comment/f4d9df19_b176532e PS2, Line 9: While moving to emerge build for coreboot I think it would be better to say that when building adlrvp with chromeos.fmd layout and adding all Chrome OS related artifacts, adlrvp is running out of space in RO region. https://review.coreboot.org/c/coreboot/+/52732/comment/8c5cb7a9_48ab3b5b PS2, Line 10: align with Brya Rather than aligning with brya, what is more important is creating space in RO. Yes, aligning with brya helps because it has the same requirements. But, The primary issue is that adlrvp runs out of space in RO when building for Chrome OS. -- To view, visit https://review.coreboot.org/c/coreboot/+/52732 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I644e2e5ba06d2b816d413a7cc9f5f248d8a6fee8 Gerrit-Change-Number: 52732 Gerrit-PatchSet: 2 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Spoorthi K <spoorthi.k(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Wed, 28 Apr 2021 21:50:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Align chromeos.fmd file with Brya
by Furquan Shaikh (Code Review) 29 Apr '21

29 Apr '21

1 0

Change in coreboot[master]: drivers/i2c/designware: Use safe defaults for SCL parameters
by Furquan Shaikh (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Duncan Laurie, Kyösti Mälkki, Werner Zeh. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52723 ) Change subject: drivers/i2c/designware: Use safe defaults for SCL parameters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbafae22c83ffbc16c179fb5412fb4fd6b70813a Gerrit-Change-Number: 52723 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Duncan Laurie <duncan(a)iceblink.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Duncan Laurie <duncan(a)iceblink.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 28 Apr 2021 21:36:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: increase SMM_CODE_SEGMENT_SIZE
by Tim Wawrzynczak (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Furquan Shaikh, John Zhao, Nick Vaccaro, Tim Wawrzynczak. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52742 ) Change subject: cpu/x86/smm: increase SMM_CODE_SEGMENT_SIZE ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Need to understand why first, we shouldn't be loading more things into SMM -- To view, visit https://review.coreboot.org/c/coreboot/+/52742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9fdae7cdf812d92a4d3b61368de884f4e55aa3a Gerrit-Change-Number: 52742 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Wed, 28 Apr 2021 21:31:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021