coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: amd/cezanne: Add telemetry setting to UPD
by Marshall Dawson (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Chris Wang, chris wang, Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52733 ) Change subject: amd/cezanne: Add telemetry setting to UPD ...................................................................... Patch Set 3: (1 comment) File src/vendorcode/amd/fsp/cezanne/FspmUpd.h: https://review.coreboot.org/c/coreboot/+/52733/comment/9fc5b94d_4092917c PS1, Line 106: 0x04C7 > oh, yeah there are more other unaligned fields than i thought; looks like i didn't remember to check […] I would align, however it's just a habit. I believe the FSP doesn't care. Looking at the warnings of unalinged fields, I think many of those are innocuous and are weird-sized definitions like port_descriptors and phy_tune. I don't see a warning for any old 32-bit value that's misaligned. -- To view, visit https://review.coreboot.org/c/coreboot/+/52733 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dd3643e9c582a41192130901935eef321b2c67e Gerrit-Change-Number: 52733 Gerrit-PatchSet: 3 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 29 Apr 2021 00:47:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: increase SMM_CODE_SEGMENT_SIZE
by Nick Vaccaro (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, John Zhao. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52742 ) Change subject: cpu/x86/smm: increase SMM_CODE_SEGMENT_SIZE ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Need to understand why first, we shouldn't be loading more things into SMM The bloat occurred when x86 was switched over to the V2 SMM loader and deprecated the V1 option with https://review.coreboot.org/c/coreboot/+/51187. -- To view, visit https://review.coreboot.org/c/coreboot/+/52742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9fdae7cdf812d92a4d3b61368de884f4e55aa3a Gerrit-Change-Number: 52742 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Thu, 29 Apr 2021 00:45:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] soc/mediatek,qualcomm: Replace some CONFIG(CHROMEOS)
by Julius Werner (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Kyösti Mälkki. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50879 ) Change subject: [WIP] soc/mediatek,qualcomm: Replace some CONFIG(CHROMEOS) ...................................................................... Patch Set 7: (1 comment) Patchset: PS6: > Well as CONFIG(TPM) does not exist.. […] Yeah, that's what I meant. (We do TPM1 || TPM2 a lot so maybe adding a helper Kconfig to represent that would also be a good idea.) -- To view, visit https://review.coreboot.org/c/coreboot/+/50879 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40b72cd63b051a2649ff450f50946e5a0a00ed4f Gerrit-Change-Number: 50879 Gerrit-PatchSet: 7 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 29 Apr 2021 00:42:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/cezanne: Supply SMBIOS/DMI Type 17 data
by Nikolai Vyssotski (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Felix Held. Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52230 ) Change subject: soc/amd/cezanne: Supply SMBIOS/DMI Type 17 data ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/52230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa89ee1ce6efa0280f17a443e07571a1190873a6 Gerrit-Change-Number: 52230 Gerrit-PatchSet: 5 Gerrit-Owner: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 29 Apr 2021 00:34:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/dram: Add support for LPDDR4 4266
by build bot (Jenkins) (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Marshall Dawson, Nikolai Vyssotski, Rob Barnes, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52745 ) Change subject: device/dram: Add support for LPDDR4 4266 ...................................................................... Patch Set 2: (2 comments) File src/device/dram/ddr4.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118036): https://review.coreboot.org/c/coreboot/+/52745/comment/a3a9b175_658a46b0 PS2, Line 175: sizeof(ddr4_speeds)/sizeof(ddr4_speeds[0])); Prefer ARRAY_SIZE(ddr4_speeds) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118036): https://review.coreboot.org/c/coreboot/+/52745/comment/6b8d32e8_def04399 PS2, Line 181: sizeof(lpddr4_speeds)/sizeof(lpddr4_speeds[0])); Prefer ARRAY_SIZE(lpddr4_speeds) -- To view, visit https://review.coreboot.org/c/coreboot/+/52745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8ddfc98fff4255670c50e1ddd4d0a1326265772 Gerrit-Change-Number: 52745 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 29 Apr 2021 00:33:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso/dmi.c: Fix builds for boards without Google EC
by Nikolai Vyssotski (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Nikolai Vyssotski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52748 ) Change subject: soc/amd/picasso/dmi.c: Fix builds for boards without Google EC ...................................................................... soc/amd/picasso/dmi.c: Fix builds for boards without Google EC For CRBs without Google EC with CONFIG_CHROMEOS=y we will get a build error as google_chromeec_cbi_get_dram_part_num() is not defined. Use EC_GOOGLE_CHROMEEC instead of CHROMEOS to gate the call. BUG=b:184124605 Change-Id: I2b200f4fb11513c6fc17a2f0af3e12e5a3e3e5a1 Signed-off-by: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> --- M src/soc/amd/picasso/dmi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/52748/1 diff --git a/src/soc/amd/picasso/dmi.c b/src/soc/amd/picasso/dmi.c index 1133670..69928ad 100644 --- a/src/soc/amd/picasso/dmi.c +++ b/src/soc/amd/picasso/dmi.c @@ -158,7 +158,7 @@ } printk(BIOS_DEBUG, "AMD_FSP_DMI_HOB found\n"); - if (CONFIG(CHROMEOS)) { + if (CONFIG(EC_GOOGLE_CHROMEEC)) { /* Prefer DRAM part number from CBI. */ if (google_chromeec_cbi_get_dram_part_num( cbi_part_number, sizeof(cbi_part_number)) == 0) { -- To view, visit https://review.coreboot.org/c/coreboot/+/52748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2b200f4fb11513c6fc17a2f0af3e12e5a3e3e5a1 Gerrit-Change-Number: 52748 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/picasso: Move Type 17 DMI generation to common
by Nikolai Vyssotski (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52746 to look at the new patch set (#2). Change subject: soc/amd/picasso: Move Type 17 DMI generation to common ...................................................................... soc/amd/picasso: Move Type 17 DMI generation to common Move dmi.c code to common/fsp to be shared among different SOCs. BUG=b:184124605 Change-Id: I46071556bbbbf6435d9e3724bba19e102bd02535 Signed-off-by: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> --- M src/soc/amd/common/Kconfig.common M src/soc/amd/common/fsp/Makefile.inc R src/soc/amd/common/fsp/dmi.c M src/soc/amd/picasso/Kconfig M src/soc/amd/picasso/Makefile.inc 5 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/52746/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52746 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46071556bbbbf6435d9e3724bba19e102bd02535 Gerrit-Change-Number: 52746 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: device/dram: Add support for LPDDR4 4266
by Nikolai Vyssotski (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Marshall Dawson, Nikolai Vyssotski, Rob Barnes, Felix Held. Hello build bot (Jenkins), Marshall Dawson, Rob Barnes, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/52745 to look at the new patch set (#2). Change subject: device/dram: Add support for LPDDR4 4266 ...................................................................... device/dram: Add support for LPDDR4 4266 Add 4266 MT/s LPDDD4 to a separate lpddr4_speed table. Set min/max limits to 1866/2133 MHz per JEDEC 209-4C. BUG=b:184124605 Change-Id: Id8ddfc98fff4255670c50e1ddd4d0a1326265772 Signed-off-by: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> --- M src/device/dram/ddr4.c 1 file changed, 44 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/52745/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52745 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8ddfc98fff4255670c50e1ddd4d0a1326265772 Gerrit-Change-Number: 52745 Gerrit-PatchSet: 2 Gerrit-Owner: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush: update the telemetry setting
by Marshall Dawson (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Chris Wang, chris wang. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52736 ) Change subject: mb/google/guybrush: update the telemetry setting ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib92bb169693634665fc8e165837e7ae3e6137bcf Gerrit-Change-Number: 52736 Gerrit-PatchSet: 3 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Thu, 29 Apr 2021 00:23:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/mancomb: Add STAPM values to overridetree
by Marshall Dawson (Code Review) 29 Apr '21

29 Apr '21

Attention is currently required from: Martin Roth, Chris Wang, chris wang. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52709 ) Change subject: mb/google/mancomb: Add STAPM values to overridetree ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52709/comment/be728017_e6b85902 PS2, Line 9: . Remove period, also can flow some of the text on the next line up to here. https://review.coreboot.org/c/coreboot/+/52709/comment/10ed76ad_215fe263 PS2, Line 9: f Cap F File src/mainboard/google/mancomb/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/52709/comment/e408095d_13b66ae0 PS2, Line 4: Nit, remove extra whitespace. I don't see this aligning vertically with anything. I suspect the line was copy/pasted from the other file. -- To view, visit https://review.coreboot.org/c/coreboot/+/52709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib3ed76e5212a5a8b5fb4fcc3d6884ceff82377b7 Gerrit-Change-Number: 52709 Gerrit-PatchSet: 2 Gerrit-Owner: chris wang <Chris.Wang(a)amd.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: chris wang <Chris.Wang(a)amd.com> Gerrit-Comment-Date: Thu, 29 Apr 2021 00:14:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021