Attention is currently required from: Tim Wawrzynczak, Christian Walter.
Hello build bot (Jenkins), Tim Wawrzynczak, Christian Walter,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59768
to look at the new patch set (#4).
Change subject: drivers/i2c/tpm: Add override function for TPM I2C bus
......................................................................
drivers/i2c/tpm: Add override function for TPM I2C bus
Provide a way to let boards can determine which TPM bus to use
at runtime.
Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com>
Change-Id: I658468ed3880de0a6b947c212fa8737956928c57
---
M src/drivers/i2c/tpm/Kconfig
M src/drivers/i2c/tpm/tis.c
M src/drivers/i2c/tpm/tis_atmel.c
M src/security/tpm/tis.h
4 files changed, 23 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/59768/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/59768
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I658468ed3880de0a6b947c212fa8737956928c57
Gerrit-Change-Number: 59768
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Julius Werner, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59738 )
Change subject: lib/fls: Add fls support
......................................................................
Patch Set 2:
(2 comments)
File src/commonlib/bsd/include/commonlib/bsd/helpers.h:
https://review.coreboot.org/c/coreboot/+/59738/comment/8b6c1564_0b14776e
PS1, Line 132: @x: the word to search
> @param x Input number.
Ack
https://review.coreboot.org/c/coreboot/+/59738/comment/424ec634_9c6195ff
PS1, Line 134: ffs
> There's no such function here. Please remove the comment.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/59738
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32
Gerrit-Change-Number: 59738
Gerrit-PatchSet: 2
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 08:14:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Julius Werner, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59738 )
Change subject: lib/fls: Add fls support
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59738/comment/c151a99e_48449f2e
PS1, Line 12: only used
> define fls only
Ack
https://review.coreboot.org/c/coreboot/+/59738/comment/7d6097ad_3e59f913
PS1, Line 15: This code is copied from Linux kernel in: include/asm-generic/bitops/fls.h
> The license here (BSD) is different (from kernel's GPL-2. […]
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/59738/comment/ee42ee11_3932e4a6
PS2, Line 7: lib/fls
lib
Patchset:
PS1:
> Of course not, but I found there are some misunderstandings, __ffs only calculate the first signific […]
Right. Sorry, my mistake.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59738
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32
Gerrit-Change-Number: 59738
Gerrit-PatchSet: 2
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 08:14:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Comment-In-Reply-To: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Paul Menzel.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56792 )
Change subject: soc/mediatek/mt8195: Add driver to configure PCIe
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/mt8195/pcie.c:
https://review.coreboot.org/c/coreboot/+/56792/comment/43eee149_e0cdb22c
PS3, Line 54: int i;
> `unsigned int` or `size_t`
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56792
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6799c53b03a33be91157ea088d829beb4272976
Gerrit-Change-Number: 56792
Gerrit-PatchSet: 6
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 01 Dec 2021 07:30:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56792
to look at the new patch set (#6).
Change subject: soc/mediatek/mt8195: Add driver to configure PCIe
......................................................................
soc/mediatek/mt8195: Add driver to configure PCIe
Add a new function 'mtk_pcie_prepare' to configure and initialize PCIe
bus.
Signed-off-by: Jianjun Wang <jianjun.wang(a)mediatek.com>
Change-Id: If6799c53b03a33be91157ea088d829beb4272976
---
A src/soc/mediatek/mt8195/include/soc/pcie.h
A src/soc/mediatek/mt8195/pcie.c
2 files changed, 82 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/56792/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/56792
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6799c53b03a33be91157ea088d829beb4272976
Gerrit-Change-Number: 56792
Gerrit-PatchSet: 6
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Hung-Te Lin, Furquan Shaikh, Paul Menzel.
Hello Shelley Chen, Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56791
to look at the new patch set (#6).
Change subject: soc/mediatek: Add PCIe support
......................................................................
soc/mediatek: Add PCIe support
Add PCIe support for MediaTek platform.
Reference:
- MT8195 Register Map V0.3-2, Chapter 3.18 PCIe controller (Page 1250)
- linux/drivers/pci/controller/pcie-mediatek-gen3.c
This code is based on MT8195 platform, but it should be common in each
platform with the same PCIe IP in the future.
TEST=Build pass and boot up to kernel successfully via SSD
BUG=b:178565024
Signed-off-by: Jianjun Wang <jianjun.wang(a)mediatek.com>
Change-Id: Ib9b6adaafa20aeee136372ec9564273f86776da0
---
A src/soc/mediatek/common/include/soc/pcie_common.h
A src/soc/mediatek/common/pcie.c
2 files changed, 337 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/56791/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/56791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b6adaafa20aeee136372ec9564273f86776da0
Gerrit-Change-Number: 56791
Gerrit-PatchSet: 6
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Julius Werner, Yu-Ping Wu.
Hello Hung-Te Lin, Shelley Chen, Paul Menzel, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59738
to look at the new patch set (#2).
Change subject: lib/fls: Add fls support
......................................................................
lib/fls: Add fls support
Implement fls() by calling clz(), and remove the duplicate definitions
in commonlib/storage/sdhci.c.
Signed-off-by: Jianjun Wang <jianjun.wang(a)mediatek.com>
Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32
---
M src/commonlib/storage/sdhci.c
M src/include/lib.h
2 files changed, 4 insertions(+), 31 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/59738/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/59738
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32
Gerrit-Change-Number: 59738
Gerrit-PatchSet: 2
Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Reka Norman, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Subrata Banik, Krishna P Bhat D, Usha P, Patrick Rudolph, Kangheui Won.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59752 )
Change subject: soc/intel/alderlake: Configure 9 I/O for ADL-N
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/59752/comment/0687b4fe_e035dcb3
PS1, Line 177: SOC_INTEL_ALDERLAKE_PCH_N
> ADL-N supports max of 5 PCIE ports to be enabled, but does not specify which 5. […]
ACK
--
To view, visit https://review.coreboot.org/c/coreboot/+/59752
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ebbcdcdb1ccc34b80ec71ac3e591fe4ad6b1904
Gerrit-Change-Number: 59752
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Kangheui Won <khwon(a)google.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 07:15:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Comment-In-Reply-To: Usha P <usha.p(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Sridhar Siricilla, Subrata Banik, Krishna P Bhat D, Patrick Rudolph, Kangheui Won.
Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59752 )
Change subject: soc/intel/alderlake: Configure 9 I/O for ADL-N
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59752/comment/2895a62c_b5d70a17
PS1, Line 7: soc/intel/alderlake: Select number of I/O for ADL-N
> Please be specific and include the number: […]
Done
https://review.coreboot.org/c/coreboot/+/59752/comment/e036b2f5_475eee6e
PS1, Line 9: Select number of I/O based on PCH for Alder Lake-N
> Where is the number 9 documented in?
Added the document number to commit message
--
To view, visit https://review.coreboot.org/c/coreboot/+/59752
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ebbcdcdb1ccc34b80ec71ac3e591fe4ad6b1904
Gerrit-Change-Number: 59752
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Kangheui Won <khwon(a)google.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 07:07:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment