December 2021 - coreboot-gerrit

Change in coreboot[master]: soc/intel/alderlake: Add Kconfig for ADL_N PCH
by Usha P (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Reka Norman, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Kangheui Won. Hello Reka Norman, build bot (Jenkins), Maulik V Vaghela, Rizwan Qureshi, Tim Wawrzynczak, Subrata Banik, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Kangheui Won, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59751 to look at the new patch set (#2). Change subject: soc/intel/alderlake: Add Kconfig for ADL_N PCH ...................................................................... soc/intel/alderlake: Add Kconfig for ADL_N PCH Add SOC_INTEL_ALDERLAKE_PCH_N option in Kconfig Signed-off-by: Usha P <usha.p(a)intel.com> Change-Id: I1be10aea36db5a14ca8d7cf5c087163e44554f78 --- M src/soc/intel/alderlake/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/59751/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1be10aea36db5a14ca8d7cf5c087163e44554f78 Gerrit-Change-Number: 59751 Gerrit-PatchSet: 2 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Kangheui Won <khwon(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Adding Kconfig for ADL_N PCH
by Usha P (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Reka Norman, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Kangheui Won. Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59751 ) Change subject: soc/intel/alderlake: Adding Kconfig for ADL_N PCH ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/alderlake/Kconfig: https://review.coreboot.org/c/coreboot/+/59751/comment/9d4c7f9c_1e241f72 PS1, Line 14: Choose this option if you have PCH-N chipset. > Can’t this be auto-detected at runtime? This is a config to control the compilation specific to ADL-N. Detecting it in runtime would need to parse through all PCH ID's which won't help us in eliminating the compilation overhead. -- To view, visit https://review.coreboot.org/c/coreboot/+/59751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1be10aea36db5a14ca8d7cf5c087163e44554f78 Gerrit-Change-Number: 59751 Gerrit-PatchSet: 1 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Kangheui Won <khwon(a)google.com> Gerrit-Comment-Date: Wed, 01 Dec 2021 04:51:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/tpm: Add override function for TPM I2C bus
by EricR Lai (Code Review) Dec. 1, 2021

Dec. 1, 2021

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59768 ) Change subject: drivers/i2c/tpm: Add override function for TPM I2C bus ...................................................................... drivers/i2c/tpm: Add override function for TPM I2C bus Provide a way to let boards can determine which TPM bus to use at runtime. Signed-off-by: Eric Lai <ericr_lai(a)compal.corp-partner.google.com> Change-Id: I658468ed3880de0a6b947c212fa8737956928c57 --- M src/drivers/i2c/tpm/Kconfig M src/drivers/i2c/tpm/tis.c M src/drivers/i2c/tpm/tis_atmel.c M src/drivers/i2c/tpm/tpm.h M src/security/tpm/tis.h 5 files changed, 18 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/59768/1 diff --git a/src/drivers/i2c/tpm/Kconfig b/src/drivers/i2c/tpm/Kconfig index df622f0..ea76c06 100644 --- a/src/drivers/i2c/tpm/Kconfig +++ b/src/drivers/i2c/tpm/Kconfig @@ -34,6 +34,9 @@ hex "I2C TPM chip bus" default 0x9 # FIXME, workaround for Kconfig BS depends on I2C_TPM + help + get_tpm_i2c_bus() is now the interface, in case a board uses some information + at runtime to determine which TPM bus to use. config DRIVER_TPM_I2C_ADDR hex "I2C TPM chip address" diff --git a/src/drivers/i2c/tpm/tis.c b/src/drivers/i2c/tpm/tis.c index 80de2df..fdbb1de 100644 --- a/src/drivers/i2c/tpm/tis.c +++ b/src/drivers/i2c/tpm/tis.c @@ -28,7 +28,7 @@ return -1; } - rc = tpm_vendor_init(&chip, CONFIG_DRIVER_TPM_I2C_BUS, + rc = tpm_vendor_init(&chip, get_tpm_i2c_bus(), CONFIG_DRIVER_TPM_I2C_ADDR); if (rc < 0) chip.is_open = 0; @@ -51,7 +51,7 @@ int tis_init(void) { - return tpm_vendor_probe(CONFIG_DRIVER_TPM_I2C_BUS, + return tpm_vendor_probe(get_tpm_i2c_bus(), CONFIG_DRIVER_TPM_I2C_ADDR); } diff --git a/src/drivers/i2c/tpm/tis_atmel.c b/src/drivers/i2c/tpm/tis_atmel.c index 3a87dec..612a0dc2 100644 --- a/src/drivers/i2c/tpm/tis_atmel.c +++ b/src/drivers/i2c/tpm/tis_atmel.c @@ -60,7 +60,7 @@ /* Send the command to the TPM */ stopwatch_init_msecs_expire(&sw, XMIT_TIMEOUT); while (1) { - status = i2c_write_raw(CONFIG_DRIVER_TPM_I2C_BUS, + status = i2c_write_raw(get_tpm_i2c_bus(), CONFIG_DRIVER_TPM_I2C_ADDR, (uint8_t *)sendbuf, sbuf_size); if ((status < 0) && (!stopwatch_expired(&sw))) @@ -77,7 +77,7 @@ header = (struct tpm_output_header *)recvbuf; stopwatch_init_msecs_expire(&sw, RECV_TIMEOUT); do { - status = i2c_read_raw(CONFIG_DRIVER_TPM_I2C_BUS, + status = i2c_read_raw(get_tpm_i2c_bus(), CONFIG_DRIVER_TPM_I2C_ADDR, recvbuf, hdr_bytes); if (status > 0) break; @@ -97,7 +97,7 @@ hexdump(recvbuf, hdr_bytes); /* Read the full TPM response */ - status = i2c_read_raw(CONFIG_DRIVER_TPM_I2C_BUS, + status = i2c_read_raw(get_tpm_i2c_bus(), CONFIG_DRIVER_TPM_I2C_ADDR, recvbuf, recv_bytes); if (status < 0) return status; diff --git a/src/drivers/i2c/tpm/tpm.h b/src/drivers/i2c/tpm/tpm.h index eb4fef1..91f1258 100644 --- a/src/drivers/i2c/tpm/tpm.h +++ b/src/drivers/i2c/tpm/tpm.h @@ -63,4 +63,9 @@ void tpm_vendor_cleanup(struct tpm_chip *chip); +int __weak get_tpm_i2c_bus(void) +{ + return CONFIG_DRIVER_TPM_I2C_BUS; +} + #endif /* __DRIVERS_TPM_SLB9635_I2C_TPM_H__ */ diff --git a/src/security/tpm/tis.h b/src/security/tpm/tis.h index 5b2c001..0c712ef 100644 --- a/src/security/tpm/tis.h +++ b/src/security/tpm/tis.h @@ -84,4 +84,9 @@ */ int tis_plat_irq_status(void); +/* + * Provide override by the variants + */ +int get_tpm_i2c_bus(void); + #endif /* TIS_H_ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/59768 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I658468ed3880de0a6b947c212fa8737956928c57 Gerrit-Change-Number: 59768 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: helpers: Add fls support
by Yu-Ping Wu (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Julius Werner, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59738 ) Change subject: helpers: Add fls support ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I will abandon this patch and use __ffs instead. Would you mind re-purposing this patch by changing fls(ctrlr->voltages) - 1 to __ffs(ctrlr->voltages) in commonlib/storage/sdhci.c? -- To view, visit https://review.coreboot.org/c/coreboot/+/59738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32 Gerrit-Change-Number: 59738 Gerrit-PatchSet: 1 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Dec 2021 03:59:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Update camera NVM parameters
by ShawnX Tu (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Selma Bensaid, Paul Menzel, Bernardo Perez Priego, Andy Yeh, kiran2.kumar(a)intel.com. ShawnX Tu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58374 ) Change subject: mb/google/brya: Update camera NVM parameters ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58374/comment/a9759f9b_f8307669 PS2, Line 13: should be ocrrect. > Adding verification contact to code review. It verified by below commands to dump the nvm data on brya device. # cat /sys/bus/i2c/devices/i2c-PRP0001:02/eeprom > ./brya_imx208_eeprom.bin # hexdump -C ./brya_imx208_eeprom.bin > brya_imx208_eeprom_dump.log You should see the result be same as module nvm file by vendor provided or meet the Intel nvm calibration format. (e.g. first 4 bytes be 0x01, 0x03, 0x01, 0x00) More detail see the Jira ticket - https://jira.devtools.intel.com/browse/SYSCROS-67048. Commit Message: https://review.coreboot.org/c/coreboot/+/58374/comment/5ee9ca4e_4a3efe69 PS5, Line 13: Test=Boot board, camera nvm parameters should be as expected. > # cat /sys/bus/i2c/devices/i2c-PRP0001:01/eeprom > ./ov8856_eeprom_test.bin […] Correct the commands to dump the nvm data on brya device. # cat /sys/bus/i2c/devices/i2c-PRP0001:02/eeprom > ./brya_imx208_eeprom.bin # hexdump -C ./brya_imx208_eeprom.bin > brya_imx208_eeprom_dump.log -- To view, visit https://review.coreboot.org/c/coreboot/+/58374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2366ba4c8bb70d8cc82e64ca585b118a96260c0 Gerrit-Change-Number: 58374 Gerrit-PatchSet: 5 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: kiran2.kumar(a)intel.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Attention: kiran2.kumar(a)intel.com Gerrit-Comment-Date: Wed, 01 Dec 2021 03:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Comment-In-Reply-To: ShawnX Tu <shawnx.tu(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Update camera NVM parameters
by ShawnX Tu (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Selma Bensaid, Paul Menzel, Bernardo Perez Priego, Andy Yeh, kiran2.kumar(a)intel.com. ShawnX Tu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58374 ) Change subject: mb/google/brya: Update camera NVM parameters ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58374/comment/454996d6_bf8810cf PS5, Line 9: Change HID name from INT3499 to PRP0001 along with size and : address width. > Why? Refer to eeprom discussion thread (https://partnerissuetracker.corp.google.com/issues/170924309) it defined the NVM nodes naming & udev rules with Google. https://review.coreboot.org/c/coreboot/+/58374/comment/49807d68_0968a500 PS5, Line 13: Test=Boot board, camera nvm parameters should be as expected. > Checked how? # cat /sys/bus/i2c/devices/i2c-PRP0001:01/eeprom > ./ov8856_eeprom_test.bin # hexdump -C ov8856_eeprom_test.bin > ov8856_eeprom_dump.log You should see the result be same as module nvm file by vendor provided or meet the Intel nvm calibration format. (e.g. first 4 bytes be 0x01, 0x03, 0x01, 0x00) -- To view, visit https://review.coreboot.org/c/coreboot/+/58374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2366ba4c8bb70d8cc82e64ca585b118a96260c0 Gerrit-Change-Number: 58374 Gerrit-PatchSet: 5 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: kiran2.kumar(a)intel.com Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Attention: kiran2.kumar(a)intel.com Gerrit-Comment-Date: Wed, 01 Dec 2021 03:19:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C
by build bot (Jenkins) (Code Review) Dec. 1, 2021

Dec. 1, 2021

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59737 ) Change subject: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/brya/variants/primus/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134708): https://review.coreboot.org/c/coreboot/+/59737/comment/38761817_e825dbc6 PS5, Line 51: }else { space required after that close brace '}' -- To view, visit https://review.coreboot.org/c/coreboot/+/59737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief1b156b866a9aaa2919f0e209b6439c7019e939 Gerrit-Change-Number: 59737 Gerrit-PatchSet: 5 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 02:51:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C
by build bot (Jenkins) (Code Review) Dec. 1, 2021

Dec. 1, 2021

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59737 ) Change subject: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/brya/variants/primus/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134707): https://review.coreboot.org/c/coreboot/+/59737/comment/e08e79d4_e85137ab PS4, Line 52: else{ else should follow close brace '}' -- To view, visit https://review.coreboot.org/c/coreboot/+/59737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief1b156b866a9aaa2919f0e209b6439c7019e939 Gerrit-Change-Number: 59737 Gerrit-PatchSet: 4 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 02:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] src/drivers/intel/fsp2_0: Update GUID for FSP_NON_VOLATILE_STOR...
by build bot (Jenkins) (Code Review) Dec. 1, 2021

Dec. 1, 2021

Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59638 ) Change subject: [WIP] src/drivers/intel/fsp2_0: Update GUID for FSP_NON_VOLATILE_STORAGE_HOB2 HOB introduced in FSP 2.3 ...................................................................... Patch Set 13: (2 comments) File src/drivers/intel/fsp2_0/hand_off_block.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134706): https://review.coreboot.org/c/coreboot/+/59638/comment/2b9358d6_0a02853d PS13, Line 318: hob_ptr = (struct fsp_nvs_hob2_data_region_header *)fsp_find_extension_hob_by_guid \ line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134706): https://review.coreboot.org/c/coreboot/+/59638/comment/aaf1f575_5947f3e9 PS13, Line 318: hob_ptr = (struct fsp_nvs_hob2_data_region_header *)fsp_find_extension_hob_by_guid \ Avoid unnecessary line continuations -- To view, visit https://review.coreboot.org/c/coreboot/+/59638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27647e9ac1a4902256b3f1c34b60e1f0b787a06e Gerrit-Change-Number: 59638 Gerrit-PatchSet: 13 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 02:38:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C
by build bot (Jenkins) (Code Review) Dec. 1, 2021

Dec. 1, 2021

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59737 ) Change subject: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C ...................................................................... Patch Set 3: (3 comments) File src/mainboard/google/brya/variants/primus/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134705): https://review.coreboot.org/c/coreboot/+/59737/comment/4d74a9b7_ec80cc90 PS3, Line 43: if (board_ver <2) { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134705): https://review.coreboot.org/c/coreboot/+/59737/comment/07ae468a_f3578883 PS3, Line 52: else { else should follow close brace '}' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134705): https://review.coreboot.org/c/coreboot/+/59737/comment/a9162207_2db25fbc PS3, Line 113: if (board_ver >1) { spaces required around that '>' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/59737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief1b156b866a9aaa2919f0e209b6439c7019e939 Gerrit-Change-Number: 59737 Gerrit-PatchSet: 3 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 02:37:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0