Attention is currently required from: Shelley Chen, Ravi kumar.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55378 )
Change subject: herobrine: Assert gpio for USB_HUB_LDO_EN
......................................................................
Patch Set 55: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/55378
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia94e046f9eb0d3ce593f3445e0203a7391c14de2
Gerrit-Change-Number: 55378
Gerrit-PatchSet: 55
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Sandeep Maheswaram <sanm(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 01 Dec 2021 00:12:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59491 )
Change subject: libpayload: Add CBMEM_IMD_ENTRY support to coreboot tables parser
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
Thanks! We can also start removing these from src/lib/coreboot_table.c:add_cbmem_pointers() now, so they actually stop getting generated (probably best to do that in a separate CL so it's easier to revert if needed). I believe ACPI_GNVS, ACPI_CNVS, WIFI_CALIBRATION, FMAP and TYPE_C_INFO were only ever put there for libpayload, so those should be fine to remove. The others are also used by the Linux kernel (CONSOLE, VPD) or util/cbmem (TIMESTAMP, CONSOLE, TCPA_LOG), so we'll probably need to keep those for backwards-compatibility for a while (although we should also update the cbmem utility to use lb_cbmem_entry instead, so that we can deprecate those eventually).
--
To view, visit https://review.coreboot.org/c/coreboot/+/59491
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bd02a98ba2631f34014bc0f8e7ebd5a5ddd2321
Gerrit-Change-Number: 59491
Gerrit-PatchSet: 2
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 00:00:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment