coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5524 discussions

Change in coreboot[master]: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C
by Malik Hsu (Code Review) 01 Dec '21

01 Dec '21

Attention is currently required from: Malik Hsu. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59737 to look at the new patch set (#2). Change subject: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C ...................................................................... mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C In next build phase, primus will exchange i2c port for touchscreen and cr50. BUG=b:207834727 TEST=build pass Signed-off-by: Malik_Hsu <malik_hsu(a)wistron.corp-partner.google.com> Change-Id: Ief1b156b866a9aaa2919f0e209b6439c7019e939 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/primus/gpio.c M src/mainboard/google/brya/variants/primus/overridetree.cb M src/mainboard/google/brya/variants/primus/variant.c 4 files changed, 161 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/59737/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/59737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief1b156b866a9aaa2919f0e209b6439c7019e939 Gerrit-Change-Number: 59737 Gerrit-PatchSet: 2 Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: libpayload: Implement new CBFS access API
by Julius Werner (Code Review) 01 Dec '21

01 Dec '21

Attention is currently required from: Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59497 ) Change subject: libpayload: Implement new CBFS access API ...................................................................... Patch Set 3: (20 comments) File payloads/libpayload/Makefile: https://review.coreboot.org/c/coreboot/+/59497/comment/bb7e86f3_31880508 PS3, Line 294: $$(subst $(absobj)/,$(obj)/, \ Should probably factor out the generic commonlib support changes into a separate patch. File payloads/libpayload/include/cbfs.h: https://review.coreboot.org/c/coreboot/+/59497/comment/7025f4f6_6f2dc8a7 PS3, Line 42: * --------------------------------------------------------------------------- Since this is a new file, let's also use this opportunity to switch to SPDX here and get rid of the copyrights (they belong to cbfs_legacy.h now). File payloads/libpayload/include/cbfs_core.h: https://review.coreboot.org/c/coreboot/+/59497/comment/113d1245_f9facf2c PS3, Line 48: #include <commonlib/bsd/cbfs_serialized.h> Here too (in the headers) I think it would be better to just keep the legacy code and the new code completely separate. (I guess if there are naming clashes you may need to include cbfs_serialized.h here in the old header and remove the duplicates, but at least this header shouldn't be needed for any of the new code to make it easier to eventually just delete it.) File payloads/libpayload/include/cbfs_glue.h: PS3: license https://review.coreboot.org/c/coreboot/+/59497/comment/170f5d1f_ff098f26 PS3, Line 32: static inline size_t cbfs_dev_offset(cbfs_dev_t dev) nit: not sure you really need this... the offset is only accessed by libpayload (or payload) which can depend on the internal details of this header. The read() and size() accessors are only abstracted so the commonlib/bsd code can call them. https://review.coreboot.org/c/coreboot/+/59497/comment/506fa10a_9de74ca9 PS3, Line 38: { This also needs to do range checking. I think if (offset + size < offset || offset + size > dev->size) return -CB_ERR_ARG; should be enough. File payloads/libpayload/libcbfs/Kconfig: https://review.coreboot.org/c/coreboot/+/59497/comment/18f092a8_d900c6eb PS3, Line 12: bool This needs a prompt text to be selectable. https://review.coreboot.org/c/coreboot/+/59497/comment/68d34b2e_f73fd409 PS3, Line 16: acrive typo Also, should not reference cbfs_boot_locate (see CB:59682). File payloads/libpayload/libcbfs/cbfs.c: https://review.coreboot.org/c/coreboot/+/59497/comment/2de8ab49_c7715a98 PS1, Line 131: cbfs_err_t cbfs_walk(cbfs_dev_t dev, > Ok, so I did it by changing the macro in the main Makefile. […] Try just adding these files to libcbfs-srcs directly and bypass the includemakefiles mechanism. In order to control where they're put in the build path, add a special case to the src-to-objs function that will map $(coreboottop)/commonlib/bsd (maybe useful to define an extra shorthand for that, e.g. $(commonlib_bsd)) to $(obj)/commonlib/bsd. It looks like src-to-obj was only partially copied from coreboot to libpayload and isn't actually used in create_cc_template, so you'll need to fix that too for this to work. File payloads/libpayload/libcbfs/cbfs.c: https://review.coreboot.org/c/coreboot/+/59497/comment/ce8fc90f_7d576b6d PS3, Line 27: * SUCH DAMAGE. Same here https://review.coreboot.org/c/coreboot/+/59497/comment/36899bc7_e7a02f51 PS3, Line 29: #define LIBPAYLOAD Can get rid of all this cruft too. This file should never be built outside of libpayload nowadays. https://review.coreboot.org/c/coreboot/+/59497/comment/7fb2660e_959ff3fe PS3, Line 60: void cbfs_boot_device_find_mcache(struct cbfs_boot_device *cbd, bool is_ro); Why are these functions not static? Then you don't need prototypes. https://review.coreboot.org/c/coreboot/+/59497/comment/5b759f4e_1b1c837b PS3, Line 91: cbfs_boot_device_find_mcache(&rw, false); I think rather than making find_mcache() a separate function, it's easier to just set rw.dev.mcache and mcache_size here directly? https://review.coreboot.org/c/coreboot/+/59497/comment/0b17bad2_700bd5fa PS3, Line 134: ERROR("Metadata hash mismatch for '%s'\n", name); This doesn't print the name in coreboot because it's not a problem with the particular file, it's a problem with the whole CBFS. It would maybe make sense to print the FMAP section name here, but that's a bit hard to get at this point. So just don't print anything (the user will see the offsets in earlier log messages and can figure it out from there if necessary). https://review.coreboot.org/c/coreboot/+/59497/comment/931f8fed_200fe60b PS3, Line 141: dev->size = be32toh(mdata->h.len); cbfs_dev_t is not supposed to be an region_device equivalent and you shouldn't use it like that here... it should represent a whole CBFS, not just a file. I would just make this function return the offset as an ssize_t, and the caller can easily read the size out of mdata itself if needed. https://review.coreboot.org/c/coreboot/+/59497/comment/b52c1c38_8e9d0514 PS3, Line 156: map nit: Just because it's not really a mapping here I'd call this different... maybe `scratch`? https://review.coreboot.org/c/coreboot/+/59497/comment/fe682b6a_74992e5c PS3, Line 168: #if CONFIG(LP_LZ4) You should be able to implement this as if (!CONFIG(LP_LZ4) return 0; like in coreboot. Prefer C if() over preprocessor #if where possible. https://review.coreboot.org/c/coreboot/+/59497/comment/36939de8_35c3dd45 PS3, Line 178: return 0; Since decompression works all the same for these algorithms, and there'd be more code duplicated here, maybe it would be cleaner to rearrange this function a bit: if (compression == CBFS_COMPRESS_NONE) { ...NONE case... return ...; } map = malloc(in_size); ...everything including libpayload_boot_device_read()... switch (compression) { case CBFS_COMPRESS_LZMA: if (!CONFIG(LP_LZMA) break; out_size = ulzman(...); break; ... } free(map); return out_size; https://review.coreboot.org/c/coreboot/+/59497/comment/ff4e7a69_cb51e3b3 PS3, Line 266: **********************************************************************************************/ I meant this too with moving to cbfs_legacy.c. Basically, move absolutely everything belonging to the old API to the side and start from scratch. File payloads/libpayload/libcbfs/cbfs_mcache.c: PS3: This, too, should be pulled in from commonlib. -- To view, visit https://review.coreboot.org/c/coreboot/+/59497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00da0658dbac0cddf92ad55611def947932d23c7 Gerrit-Change-Number: 59497 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Wed, 01 Dec 2021 02:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: helpers: Add fls support
by Jianjun Wang (Code Review) 01 Dec '21

01 Dec '21

Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Julius Werner. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59738 ) Change subject: helpers: Add fls support ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Isn't this basically just 32 - clz? We already have that (in <lib.h>). […] Thanks for the suggestion, I think it's more like __ffs() in lib.h, I will abandon this patch and use __ffs instead. -- To view, visit https://review.coreboot.org/c/coreboot/+/59738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib458abfec7e03b2979569a8440a6e69b0285ac32 Gerrit-Change-Number: 59738 Gerrit-PatchSet: 1 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 01:57:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/gimble: Swap TPM I2C with touchscreen I2C
by Mark Hsieh (Code Review) 01 Dec '21

01 Dec '21

Attention is currently required from: YH Lin, Marco Chen, Felix Held. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59580 ) Change subject: mb/google/brya/var/gimble: Swap TPM I2C with touchscreen I2C ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26d059a7ea5a3fdf00de260214c00d3bba9aa7f7 Gerrit-Change-Number: 59580 Gerrit-PatchSet: 9 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Marco Chen <marcochen(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 01 Dec 2021 01:47:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/gimble: Swap TPM I2C with touchscreen I2C
by Mark Hsieh (Code Review) 01 Dec '21

01 Dec '21

Attention is currently required from: YH Lin, Marco Chen, Felix Held. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59580 ) Change subject: mb/google/brya/var/gimble: Swap TPM I2C with touchscreen I2C ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/59580 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I26d059a7ea5a3fdf00de260214c00d3bba9aa7f7 Gerrit-Change-Number: 59580 Gerrit-PatchSet: 8 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Marco Chen <marcochen(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 01 Dec 2021 01:46:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: herobrine: Assert gpio for USB_HUB_LDO_EN
by 9elements QA (Code Review) 01 Dec '21

01 Dec '21

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55378 ) Change subject: herobrine: Assert gpio for USB_HUB_LDO_EN ...................................................................... Patch Set 56: Automatic boot test returned (PASS/FAIL/TOTAL): 2 / 1 / 3 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/82856 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/82855 FAIL: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/82854 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/55378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia94e046f9eb0d3ce593f3445e0203a7391c14de2 Gerrit-Change-Number: 55378 Gerrit-PatchSet: 56 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Sandeep Maheswaram <sanm(a)codeaurora.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 01:24:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP] src/drivers/intel/fsp2_0: Update GUID for FSP_NON_VOLATILE_STOR...
by build bot (Jenkins) (Code Review) 01 Dec '21

01 Dec '21

Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59638 ) Change subject: [WIP] src/drivers/intel/fsp2_0: Update GUID for FSP_NON_VOLATILE_STORAGE_HOB2 HOB introduced in FSP 2.3 ...................................................................... Patch Set 12: (1 comment) File src/drivers/intel/fsp2_0/hand_off_block.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134702): https://review.coreboot.org/c/coreboot/+/59638/comment/772bfa80_2cdca5a7 PS12, Line 320: *size = (struct fsp_nvs_hob2_data_region_header *) hob_ptr->nvs_data_length; line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/59638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27647e9ac1a4902256b3f1c34b60e1f0b787a06e Gerrit-Change-Number: 59638 Gerrit-PatchSet: 12 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 01:22:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Create taniks variant
by Joey Peng (Code Review) 01 Dec '21

01 Dec '21

Attention is currently required from: YH Lin, Paul Menzel. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59643 ) Change subject: mb/google/brya: Create taniks variant ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/59643/comment/db8e38f9_c1176d5e PS2, Line 12: (Auto-Generated by create_coreboot_variant.sh version 4.5.0). > Please put the dot/period inside the brackets. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/59643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I797051f93019ccf72f1007d9c0b98cfb071717b0 Gerrit-Change-Number: 59643 Gerrit-PatchSet: 3 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 00:54:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Create taniks variant
by Joey Peng (Code Review) 01 Dec '21

01 Dec '21

Attention is currently required from: YH Lin, Joey Peng. Hello build bot (Jenkins), YH Lin, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59643 to look at the new patch set (#3). Change subject: mb/google/brya: Create taniks variant ...................................................................... mb/google/brya: Create taniks variant Create the taniks variant of the brya0 reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0.) BUG=b:207402720 BRANCH=None TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_TANIKS Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Change-Id: I797051f93019ccf72f1007d9c0b98cfb071717b0 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/taniks/include/variant/ec.h A src/mainboard/google/brya/variants/taniks/include/variant/gpio.h A src/mainboard/google/brya/variants/taniks/memory/Makefile.inc A src/mainboard/google/brya/variants/taniks/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/taniks/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/taniks/overridetree.cb 8 files changed, 45 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/59643/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/59643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I797051f93019ccf72f1007d9c0b98cfb071717b0 Gerrit-Change-Number: 59643 Gerrit-PatchSet: 3 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: herobrine: Assert gpio for USB_HUB_LDO_EN
by Shelley Chen (Code Review) 01 Dec '21

01 Dec '21

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55378 ) Change subject: herobrine: Assert gpio for USB_HUB_LDO_EN ...................................................................... herobrine: Assert gpio for USB_HUB_LDO_EN Some herobrine variants have USB hub powered by discrete LDO that is controlled by USB_HUB_LDO_EN gpio. Assert the GPIO on boot. BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board. Signed-off-by: Sandeep Maheswaram <sanm(a)codeaurora.org> Change-Id: Ia94e046f9eb0d3ce593f3445e0203a7391c14de2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/55378 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/herobrine/board.h M src/mainboard/google/herobrine/mainboard.c 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved diff --git a/src/mainboard/google/herobrine/board.h b/src/mainboard/google/herobrine/board.h index 0e4a760..4278c11 100644 --- a/src/mainboard/google/herobrine/board.h +++ b/src/mainboard/google/herobrine/board.h @@ -9,6 +9,13 @@ #define GPIO_SD_CD_L GPIO(91) +#if CONFIG(BOARD_GOOGLE_SENOR) || CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) +#define USB_HUB_LDO_EN GPIO(157) +#else +/* For Herobrine board and all variants */ +#define USB_HUB_LDO_EN GPIO(24) +#endif + #define QCOM_SC7280_SKU1 0x0 #define QCOM_SC7280_SKU2 0x1 #define QCOM_SC7280_SKU3 0x2 diff --git a/src/mainboard/google/herobrine/mainboard.c b/src/mainboard/google/herobrine/mainboard.c index e64fb15..a2e0786 100644 --- a/src/mainboard/google/herobrine/mainboard.c +++ b/src/mainboard/google/herobrine/mainboard.c @@ -24,6 +24,9 @@ static void setup_usb(void) { + /* Assert EN_PP3300_HUB for those board variants that use it. */ + gpio_output(USB_HUB_LDO_EN, 1); + setup_usb_host0(&usb0_board_data); } -- To view, visit https://review.coreboot.org/c/coreboot/+/55378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia94e046f9eb0d3ce593f3445e0203a7391c14de2 Gerrit-Change-Number: 55378 Gerrit-PatchSet: 56 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Sandeep Maheswaram <sanm(a)codeaurora.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021