Change in coreboot[master]: mb/google/brya: Update camera NVM parameters
Attention is currently required from: Selma Bensaid, Paul Menzel, Bernardo Perez Priego, Andy Yeh, kiran2.kumar@intel.com. ShawnX Tu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58374 ) Change subject: mb/google/brya: Update camera NVM parameters ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/58374/comment/454996d6_bf8810cf PS5, Line 9: Change HID name from INT3499 to PRP0001 along with size and : address width.
Why? Refer to eeprom discussion thread (https://partnerissuetracker.corp.google.com/issues/170924309), it defined the NVM nodes naming & udev rules with Google.
https://review.coreboot.org/c/coreboot/+/58374/comment/49807d68_0968a500 PS5, Line 13: Test=Boot board, camera nvm parameters should be as expected.
Checked how? # cat /sys/bus/i2c/devices/i2c-PRP0001:01/eeprom > ./ov8856_eeprom_test.bin # hexdump -C ov8856_eeprom_test.bin > ov8856_eeprom_dump.log
You should see the result be same as module nvm file by vendor provided or meet the Intel nvm calibration format. (e.g. first 4 bytes be 0x01, 0x03, 0x01, 0x00) -- To view, visit https://review.coreboot.org/c/coreboot/+/58374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib2366ba4c8bb70d8cc82e64ca585b118a96260c0 Gerrit-Change-Number: 58374 Gerrit-PatchSet: 5 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego@intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh@intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid@intel.com> Gerrit-Reviewer: ShawnX Tu <shawnx.tu@intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: kiran2.kumar@intel.com Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Selma Bensaid <selma.bensaid@intel.com> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego@intel.com> Gerrit-Attention: Andy Yeh <andy.yeh@intel.com> Gerrit-Attention: kiran2.kumar@intel.com Gerrit-Comment-Date: Wed, 01 Dec 2021 03:19:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org> Gerrit-MessageType: comment
participants (1)
-
ShawnX Tu (Code Review)