Change in coreboot[master]: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59737 ) Change subject: mb/google/brya/variants/primus: Swap TPM I2C with touchscreen I2C ...................................................................... Patch Set 3: (3 comments) File src/mainboard/google/brya/variants/primus/variant.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134705): https://review.coreboot.org/c/coreboot/+/59737/comment/4d74a9b7_ec80cc90 PS3, Line 43: if (board_ver <2) { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134705): https://review.coreboot.org/c/coreboot/+/59737/comment/07ae468a_f3578883 PS3, Line 52: else { else should follow close brace '}' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134705): https://review.coreboot.org/c/coreboot/+/59737/comment/a9162207_2db25fbc PS3, Line 113: if (board_ver >1) { spaces required around that '>' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/59737 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief1b156b866a9aaa2919f0e209b6439c7019e939 Gerrit-Change-Number: 59737 Gerrit-PatchSet: 3 Gerrit-Owner: Malik Hsu <malik_hsu@wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Casper Chang <casper_chang@wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Wed, 01 Dec 2021 02:37:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
build bot (Jenkins) (Code Review)