Change in coreboot[master]: mb/google/brya: Update camera NVM parameters

[ShawnX Tu (Code Review)]

Attention is currently required from: Selma Bensaid, Paul Menzel, Bernardo Perez Priego, Andy Yeh, [e-mail].
ShawnX Tu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58374 )

Change subject: mb/google/brya: Update camera NVM parameters
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/58374/comment/a9759f9b_f8307669 
PS2, Line 13: should be ocrrect.
> Adding verification contact to code review.
> It verified by below commands to dump the nvm data on brya device.

# cat /sys/bus/i2c/devices/i2c-PRP0001:02/eeprom > ./brya_imx208_eeprom.bin
# hexdump -C ./brya_imx208_eeprom.bin > brya_imx208_eeprom_dump.log

You should see the result be same as module nvm file by vendor provided or meet the Intel nvm calibration format. (e.g. first 4 bytes be 0x01, 0x03, 0x01, 0x00)

More detail see the Jira ticket - https://jira.devtools.intel.com/browse/SYSCROS-67048.


Commit Message:

https://review.coreboot.org/c/coreboot/+/58374/comment/5ee9ca4e_4a3efe69 
PS5, Line 13: Test=Boot board, camera nvm parameters should be as expected.
> # cat /sys/bus/i2c/devices/i2c-PRP0001:01/eeprom > ./ov8856_eeprom_test.bin […]
> Correct the commands to dump the nvm data on brya device.

# cat /sys/bus/i2c/devices/i2c-PRP0001:02/eeprom > ./brya_imx208_eeprom.bin
# hexdump -C ./brya_imx208_eeprom.bin > brya_imx208_eeprom_dump.log



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58374
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2366ba4c8bb70d8cc82e64ca585b118a96260c0
Gerrit-Change-Number: 58374
Gerrit-PatchSet: 5
Gerrit-Owner: Bernardo Perez Priego <[e-mail]>
Gerrit-Reviewer: Andy Yeh <[e-mail]>
Gerrit-Reviewer: Selma Bensaid <[e-mail]>
Gerrit-Reviewer: ShawnX Tu <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: [e-mail]
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Selma Bensaid <[e-mail]>
Gerrit-Attention: Paul Menzel <[e-mail]>
Gerrit-Attention: Bernardo Perez Priego <[e-mail]>
Gerrit-Attention: Andy Yeh <[e-mail]>
Gerrit-Attention: [e-mail]
Gerrit-Comment-Date: Wed, 01 Dec 2021 03:51:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak <[e-mail]>
Comment-In-Reply-To: Paul Menzel <[e-mail]>
Comment-In-Reply-To: Bernardo Perez Priego <[e-mail]>
Comment-In-Reply-To: ShawnX Tu <[e-mail]>
Gerrit-MessageType: comment