Attention is currently required from: Benjamin Doron, Angel Pons.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40625 )
Change subject: [WIP] skl: PEG for Optimus
......................................................................
Patch Set 15:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40625/comment/d0f5e877_56a55431
PS9, Line 7: PEG
> PEG usually refers to the PCIe root port that is directly attached to the CPU (PCI device 00:01.0). If this is actually for the PCIe root ports on the PCH, I would be against calling it "PEG" to avoid confusion.
What would you prefer? Note that this attempts to handle both situations, although I cannot test CPU PEG.
> Note that SKL-U, SKL-Y and friends (e.g. KBL) do not have the PEG PCI devices (00:01.0) at all.
>
> (FWIW, note that PEG can be bifurcated, in which case additional PCI functions 1 and 2 can be present for PEG)
Would a dGPU have function 2? I am aware that an HDA controller at function 1 is sometimes present.
--
To view, visit https://review.coreboot.org/c/coreboot/+/40625
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I107bd5f7c192b8ffc83de6d8f1ac314bb5dcbfbd
Gerrit-Change-Number: 40625
Gerrit-PatchSet: 15
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sun, 10 Jan 2021 17:40:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40625
to look at the new patch set (#15).
Change subject: [WIP] skl: PEG for Optimus
......................................................................
[WIP] skl: PEG for Optimus
Creates PEG ACPI device for Optimus.
Tested, nouveau driver works on an Acer Aspire VN7-572G (Skylake-U,
Maxwell mobile) and `DRI_PRIME=1 glxinfo` reports the dGPU as renderer.
Gaming is possible with the NVIDIA binary driver.
Change-Id: I107bd5f7c192b8ffc83de6d8f1ac314bb5dcbfbd
Signed-off-by: Benjamin Doron <benjamin.doron00(a)gmail.com>
---
A src/soc/intel/skylake/acpi/peg.asl
1 file changed, 254 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/40625/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/40625
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I107bd5f7c192b8ffc83de6d8f1ac314bb5dcbfbd
Gerrit-Change-Number: 40625
Gerrit-PatchSet: 15
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49283 )
Change subject: soc/intel/broadwell: Rename GPIO macros
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/purism/librem_bdw/gpio.c:
https://review.coreboot.org/c/coreboot/+/49283/comment/8cba3047_7d0d3dc9
PS1, Line 5: const struct gpio_config mainboard_gpio_config[] = {
Will clean up in a follow-up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49283
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32566ac4df7175bb4ba3e1f7216aa36de2b821a1
Gerrit-Change-Number: 49283
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sun, 10 Jan 2021 17:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49282 )
Change subject: soc/intel/denverton_ns: Drop redundant `DEFAULT_ACPI_BASE`
......................................................................
soc/intel/denverton_ns: Drop redundant `DEFAULT_ACPI_BASE`
It is only used in one place, and there's two other equivalent macros.
Change-Id: I7c8241e28f688abd2df8180559dd02ee441c7023
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/soc/intel/denverton_ns/include/soc/iomap.h
M src/soc/intel/denverton_ns/pmc.c
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/49282/1
diff --git a/src/soc/intel/denverton_ns/include/soc/iomap.h b/src/soc/intel/denverton_ns/include/soc/iomap.h
index fb5aafd..c252ca1 100644
--- a/src/soc/intel/denverton_ns/include/soc/iomap.h
+++ b/src/soc/intel/denverton_ns/include/soc/iomap.h
@@ -12,7 +12,6 @@
/* Southbridge internal device IO BARs (Set to match FSP settings) */
#define DEFAULT_PMBASE 0x1800
-#define DEFAULT_ACPI_BASE DEFAULT_PMBASE
#define ACPI_BASE_ADDRESS DEFAULT_PMBASE
#define DEFAULT_TCO_BASE 0x400
diff --git a/src/soc/intel/denverton_ns/pmc.c b/src/soc/intel/denverton_ns/pmc.c
index 8755825..258e6a4 100644
--- a/src/soc/intel/denverton_ns/pmc.c
+++ b/src/soc/intel/denverton_ns/pmc.c
@@ -16,7 +16,7 @@
/* While we read BAR dynamically in case it changed, let's
* initialize it with a same value
*/
-static u16 acpi_base = DEFAULT_ACPI_BASE;
+static u16 acpi_base = ACPI_BASE_ADDRESS;
static u32 pwrm_base = DEFAULT_PWRM_BASE;
static void pch_power_options(struct device *dev) { /* TODO */ }
--
To view, visit https://review.coreboot.org/c/coreboot/+/49282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c8241e28f688abd2df8180559dd02ee441c7023
Gerrit-Change-Number: 49282
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Lance Zhao.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49281 )
Change subject: [WIP] ChromeOS: Refactor SMBIOS type0 bios_version()
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/49281/comment/0a08a728_c7e77a3f
PS1, Line 418: if (CONFIG(CHROMEOS)) {
trailing statements should be on next line
--
To view, visit https://review.coreboot.org/c/coreboot/+/49281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9405afbea29b896488b4cdd6dd32c4db686fe48c
Gerrit-Change-Number: 49281
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao
Gerrit-Comment-Date: Sun, 10 Jan 2021 17:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment