Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44430
to look at the new patch set (#2).
Change subject: cse_lite: Move global reset after MRC writeback.
......................................................................
cse_lite: Move global reset after MRC writeback.
With CSE-lite enabled, we were going through the lengthy memory
training procedure twice on the initial power-on boot. This moves the
global reset performed to achieve the CSE-lite RO to RW reboot to a
later boot phase so that it happens after the memory training data has
been written to the MRC cache. Now, the 2nd (and subsequent) reboot
can utilize the memory training data established during the 1st boot.
This reduces the first boot time by about 20s on a 16GB system.
BUG=b:162021048
TEST=Booted on volteer, confirmed 20s faster boot time.
Change-Id: Ia42d72fdec41f9792ab8f04205b20a55758a4235
Signed-off-by: Caveh Jalali <caveh(a)chromium.org>
---
M src/soc/intel/common/block/cse/cse_lite.c
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/44430/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/44430
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia42d72fdec41f9792ab8f04205b20a55758a4235
Gerrit-Change-Number: 44430
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43604 )
Change subject: lib: Add ASan support to romstage on x86 arch
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/43604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67ebfb5e8d602e865b1f5c874860861ae4e54381
Gerrit-Change-Number: 43604
Gerrit-PatchSet: 10
Gerrit-Owner: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Thu, 13 Aug 2020 08:18:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard
......................................................................
Patch Set 36:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40581/36//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40581/36//COMMIT_MSG@36
PS36, Line 36: - Everything works as expected.
well, everything that has been tested ;) what about thunderbolt for example?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f83fab64e4cc9036698ca0fdd5edbb677d77eb9
Gerrit-Change-Number: 40581
Gerrit-PatchSet: 36
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Thu, 13 Aug 2020 07:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43071 )
Change subject: device/pci_rom: Fix rom_header structure
......................................................................
Patch Set 4:
> The latest PCI specification shows different values: http://fpga-faq.narod.ru/PCI_Rev_30.pdf
Acknowledged, thanks. I didn't realise that the PCI(e) specifications were publically available.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad02da554cb249ccec78dbb2ff57f72ec6b98584
Gerrit-Change-Number: 43071
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Thu, 13 Aug 2020 06:34:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43071 )
Change subject: device/pci_rom: Fix rom_header structure
......................................................................
Patch Set 4:
The latest PCI specification shows different values: http://fpga-faq.narod.ru/PCI_Rev_30.pdf
--
To view, visit https://review.coreboot.org/c/coreboot/+/43071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad02da554cb249ccec78dbb2ff57f72ec6b98584
Gerrit-Change-Number: 43071
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Thu, 13 Aug 2020 06:24:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43989 )
Change subject: mb/google/dedede/var/magalor: Generate SPD ID for supported parts
......................................................................
mb/google/dedede/var/magalor: Generate SPD ID for supported parts
Add supported memory parts in the mem_list_variant.txt and generate the
SPD ID for the parts. The memory part being added is:
MT53E512M32D2NP-046 WT:E
K4U6E3S4AA-MGCR
H9HCNNNBKMMLXR-NEE
MT53E1G32D2NP-046 WT:A
K4UBE3D4AA-MGCR
BUG=None
TEST=Build the magalor board.
Change-Id: I7bb19d6d4a66e66fed0564592c803c2af1045b0c
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
---
A src/mainboard/google/dedede/variants/magalor/memory/Makefile.inc
A src/mainboard/google/dedede/variants/magalor/memory/dram_id.generated.txt
A src/mainboard/google/dedede/variants/magalor/memory/mem_list_variant.txt
3 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/43989/1
diff --git a/src/mainboard/google/dedede/variants/magalor/memory/Makefile.inc b/src/mainboard/google/dedede/variants/magalor/memory/Makefile.inc
new file mode 100644
index 0000000..bab4f2a
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magalor/memory/Makefile.inc
@@ -0,0 +1,7 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+## This is an auto-generated file. Do not edit!!
+
+SPD_SOURCES =
+SPD_SOURCES += spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE
+SPD_SOURCES += spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A
+SPD_SOURCES += spd-3.hex # ID = 2(0b0010) Parts = K4UBE3D4AA-MGCR
diff --git a/src/mainboard/google/dedede/variants/magalor/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/magalor/memory/dram_id.generated.txt
new file mode 100644
index 0000000..100c322
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magalor/memory/dram_id.generated.txt
@@ -0,0 +1,6 @@
+DRAM Part Name ID to assign
+MT53E512M32D2NP-046 WT:E 0 (0000)
+K4U6E3S4AA-MGCR 0 (0000)
+H9HCNNNBKMMLXR-NEE 0 (0000)
+MT53E1G32D2NP-046 WT:A 1 (0001)
+K4UBE3D4AA-MGCR 2 (0010)
diff --git a/src/mainboard/google/dedede/variants/magalor/memory/mem_list_variant.txt b/src/mainboard/google/dedede/variants/magalor/memory/mem_list_variant.txt
new file mode 100644
index 0000000..f05a5af
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/magalor/memory/mem_list_variant.txt
@@ -0,0 +1,5 @@
+MT53E512M32D2NP-046 WT:E
+K4U6E3S4AA-MGCR
+H9HCNNNBKMMLXR-NEE
+MT53E1G32D2NP-046 WT:A
+K4UBE3D4AA-MGCR
--
To view, visit https://review.coreboot.org/c/coreboot/+/43989
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bb19d6d4a66e66fed0564592c803c2af1045b0c
Gerrit-Change-Number: 43989
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newchange