Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42148 )
Change subject: nb/intel/gm45/iommu.c: Fix regression
......................................................................
nb/intel/gm45/iommu.c: Fix regression
Commit 5ac723e (nb/intel: Fix 16-bit read/write PCI_COMMAND register)
uses `pci_read_config8` to read the PCI command register, which does not
correspond with what has been stated in the commit message. Moreover, it
potentially break things, as the upper byte of the PCI command register
is now being cleared.
So, restore the original behaviour of the code, using 16-bit accesses.
Change-Id: Id2c42ea8551a2fa2fa5c64e8fff8940d8304fbe0
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/northbridge/intel/gm45/iommu.c
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/42148/1
diff --git a/src/northbridge/intel/gm45/iommu.c b/src/northbridge/intel/gm45/iommu.c
index 10e0d02..439127d 100644
--- a/src/northbridge/intel/gm45/iommu.c
+++ b/src/northbridge/intel/gm45/iommu.c
@@ -43,9 +43,7 @@
memset(bar, 0, 2<<20);
/* and now disable again */
- u16 cmd = pci_read_config8(igd, PCI_COMMAND);
- cmd &= ~(PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY);
- pci_write_config16(igd, PCI_COMMAND, cmd);
+ pci_and_config16(igd, PCI_COMMAND, ~(PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY));
pci_write_config32(igd, PCI_BASE_ADDRESS_0, 0);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/42148
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2c42ea8551a2fa2fa5c64e8fff8940d8304fbe0
Gerrit-Change-Number: 42148
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40383 )
Change subject: soc/intel/xeon_sp/cpx: fix MADT ACPI table
......................................................................
Patch Set 21:
(2 comments)
> Patch Set 20:
>
> (2 comments)
https://review.coreboot.org/c/coreboot/+/40383/15//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40383/15//COMMIT_MSG@10
PS15, Line 10:
> Verified how?
Done
https://review.coreboot.org/c/coreboot/+/40383/20/src/soc/intel/xeon_sp/cpx…
File src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/40383/20/src/soc/intel/xeon_sp/cpx…
PS20, Line 75: #define VTD_DEV 5
> one tab too much
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/40383
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1bf6e39db545e227e9867aa8d24f7db1d820216
Gerrit-Change-Number: 40383
Gerrit-PatchSet: 21
Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 08 Jun 2020 23:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment