Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42203 )
Change subject: mb/google/volteer: Configure Type C1 Aux pins ......................................................................
mb/google/volteer: Configure Type C1 Aux pins
Configure Type C1 Aux pins as outputs: - GPP_E22 (C1_AUXP_DC): GPIO high - GPP_E23 (C1_AUXN_DC): GPIO low
BUG=b:146233756 TEST="emerge-volteer coreboot chromeos-bootimage", flash and verify Volteer boots to kernel and that GPP_E22 and GPP_E23 are no longer floating.
Change-Id: Ice1678630b53589ad22c4d22426f815a3203256f Signed-off-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/volteer/variants/volteer/gpio.c 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/42203/1
diff --git a/src/mainboard/google/volteer/variants/volteer/gpio.c b/src/mainboard/google/volteer/variants/volteer/gpio.c index 33167e3..5412526 100644 --- a/src/mainboard/google/volteer/variants/volteer/gpio.c +++ b/src/mainboard/google/volteer/variants/volteer/gpio.c @@ -116,6 +116,11 @@ PAD_CFG_GPI(GPP_E16, NONE, DEEP), /* E17 : THC0_SPI1_INT# ==> WWAN_PERST_L */ PAD_CFG_GPO(GPP_E17, 1, DEEP), + /* E22 : DDPA_CTRLCLK ==> USB_C1_AUXP_DC */ + PAD_CFG_GPO(GPP_E22, 1, DEEP), + /* E23 : DDPA_CTRLDATA ==> USB_C1_AUXN_DC */ + PAD_CFG_GPO(GPP_E23, 0, DEEP), +
/* F6 : CNV_PA_BLANKING ==> WWAN_WLAN_COEX3 */ PAD_CFG_NF(GPP_F6, NONE, DEEP, NF1),
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42203 )
Change subject: mb/google/volteer: Configure Type C1 Aux pins ......................................................................
Patch Set 1:
This change is ready for review.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42203 )
Change subject: mb/google/volteer: Configure Type C1 Aux pins ......................................................................
Patch Set 1: Code-Review+2
Nick Vaccaro has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42203 )
Change subject: mb/google/volteer: Configure Type C1 Aux pins ......................................................................
Abandoned
After discussing further with Eric, it has been determined that we do not need this.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42203 )
Change subject: mb/google/volteer: Configure Type C1 Aux pins ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42203/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/gpio.c:
https://review.coreboot.org/c/coreboot/+/42203/1/src/mainboard/google/voltee... PS1, Line 119: /* E22 : DDPA_CTRLCLK ==> USB_C1_AUXP_DC */ : PAD_CFG_GPO(GPP_E22, 1, DEEP), : /* E23 : DDPA_CTRLDATA ==> USB_C1_AUXN_DC */ : PAD_CFG_GPO(GPP_E23, 0, DEEP), oh I missed that this is also tied to TCP1, ya we probably don't want to enable it here.