Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42203 )
Change subject: mb/google/volteer: Configure Type C1 Aux pins
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42203/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer/gpio.c:
https://review.coreboot.org/c/coreboot/+/42203/1/src/mainboard/google/voltee...
PS1, Line 119: /* E22 : DDPA_CTRLCLK ==> USB_C1_AUXP_DC */
: PAD_CFG_GPO(GPP_E22, 1, DEEP),
: /* E23 : DDPA_CTRLDATA ==> USB_C1_AUXN_DC */
: PAD_CFG_GPO(GPP_E23, 0, DEEP),
oh I missed that this is also tied to TCP1, ya we probably don't want to enable it here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42203
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice1678630b53589ad22c4d22426f815a3203256f
Gerrit-Change-Number: 42203
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 08 Jun 2020 22:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment