coreboot-gerrit
Threads by month
- ----- 2025 -----
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
January 2020
- 1 participants
- 1869 discussions
Change in coreboot[master]: src: Use <types.h> when <stdint.h> and <stddef.h> are needes
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37364 )
Change subject: src: Use <types.h> when <stdint.h> and <stddef.h> are needes
......................................................................
src: Use <types.h> when <stdint.h> and <stddef.h> are needes
types.h is supposed to provide stdint.h and stddef.h headers.
Also, some unused <stdlib.h> removed
Change-Id: I1e0c2a4dfaa5b1cde0dd4a9e213be0b383e1017f
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/arm/armv7/exception.c
M src/arch/arm/eabi_compat.c
M src/arch/arm/include/armv4/arch/cache.h
M src/arch/arm/include/armv7/arch/cache.h
M src/arch/arm64/armv8/exception.c
M src/arch/arm64/armv8/mmu.c
M src/arch/arm64/include/armv8/arch/cache.h
M src/arch/riscv/misaligned.c
M src/arch/x86/include/arch/acpigen.h
M src/arch/x86/include/arch/ebda.h
M src/arch/x86/include/smm.h
M src/commonlib/storage/bouncebuf.h
M src/ec/google/chromeec/ec_lpc.c
M src/ec/google/chromeec/vstore.c
M src/ec/google/wilco/chip.c
M src/include/device/i2c_bus.h
M src/lib/bootmem.c
M src/lib/fit.c
M src/lib/imd_cbmem.c
M src/lib/rmodule.c
M src/soc/amd/stoneyridge/BiosCallOuts.c
M src/soc/cavium/cn81xx/spi.c
M src/soc/intel/common/block/fast_spi/fast_spi.c
M src/soc/intel/skylake/me.c
M src/soc/samsung/exynos5250/spi.c
M src/soc/samsung/exynos5420/spi.c
M src/soc/sifive/fu540/clock.c
27 files changed, 28 insertions(+), 49 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/37364/1
diff --git a/src/arch/arm/armv7/exception.c b/src/arch/arm/armv7/exception.c
index d6891b0..ea2b2b8 100644
--- a/src/arch/arm/armv7/exception.c
+++ b/src/arch/arm/armv7/exception.c
@@ -27,11 +27,10 @@
* SUCH DAMAGE.
*/
-#include <stdint.h>
-#include <types.h>
#include <arch/cache.h>
#include <arch/exception.h>
#include <console/console.h>
+#include <types.h>
uint8_t exception_stack[0x100] __attribute__((aligned(8)));
extern void *exception_stack_end;
diff --git a/src/arch/arm/eabi_compat.c b/src/arch/arm/eabi_compat.c
index 45f4651..8b80ee4 100644
--- a/src/arch/arm/eabi_compat.c
+++ b/src/arch/arm/eabi_compat.c
@@ -14,10 +14,9 @@
* Utility functions needed for (some) EABI conformant tool chains.
*/
-#include <stdint.h>
-#include <stddef.h>
#include <string.h>
#include <console/console.h>
+#include <types.h>
/* FIXME(dhendrix): prototypes added for assembler */
int raise(int signum) __attribute__((used));
diff --git a/src/arch/arm/include/armv4/arch/cache.h b/src/arch/arm/include/armv4/arch/cache.h
index ed3b96f..0fbc8a9 100644
--- a/src/arch/arm/include/armv4/arch/cache.h
+++ b/src/arch/arm/include/armv4/arch/cache.h
@@ -32,8 +32,7 @@
#ifndef ARM_CACHE_H
#define ARM_CACHE_H
-#include <stddef.h>
-#include <stdint.h>
+#include <types.h>
/*
* Cache maintenance API
diff --git a/src/arch/arm/include/armv7/arch/cache.h b/src/arch/arm/include/armv7/arch/cache.h
index b2b6a33..431a5bf 100644
--- a/src/arch/arm/include/armv7/arch/cache.h
+++ b/src/arch/arm/include/armv7/arch/cache.h
@@ -33,8 +33,7 @@
#ifndef ARM_CACHE_H
#define ARM_CACHE_H
-#include <stddef.h>
-#include <stdint.h>
+#include <types.h>
/* SCTLR bits */
#define SCTLR_M (1 << 0) /* MMU enable */
diff --git a/src/arch/arm64/armv8/exception.c b/src/arch/arm64/armv8/exception.c
index 579e104..79cc4ce 100644
--- a/src/arch/arm64/armv8/exception.c
+++ b/src/arch/arm64/armv8/exception.c
@@ -27,14 +27,13 @@
* SUCH DAMAGE.
*/
-#include <stdint.h>
-#include <types.h>
#include <arch/barrier.h>
#include <arch/cache.h>
#include <arch/exception.h>
#include <arch/transition.h>
#include <console/console.h>
#include <arch/lib_helpers.h>
+#include <types.h>
uint8_t exception_stack[0x200] __attribute__((aligned(16)));
diff --git a/src/arch/arm64/armv8/mmu.c b/src/arch/arm64/armv8/mmu.c
index 67dca48..37db34d 100644
--- a/src/arch/arm64/armv8/mmu.c
+++ b/src/arch/arm64/armv8/mmu.c
@@ -28,11 +28,9 @@
*/
#include <assert.h>
-#include <stdlib.h>
-#include <stdint.h>
#include <string.h>
#include <symbols.h>
-
+#include <types.h>
#include <console/console.h>
#include <arch/mmu.h>
#include <arch/lib_helpers.h>
diff --git a/src/arch/arm64/include/armv8/arch/cache.h b/src/arch/arm64/include/armv8/arch/cache.h
index 3de2e80..cd97140 100644
--- a/src/arch/arm64/include/armv8/arch/cache.h
+++ b/src/arch/arm64/include/armv8/arch/cache.h
@@ -55,10 +55,9 @@
#ifndef __ASSEMBLER__
-#include <stddef.h>
-#include <stdint.h>
#include <arch/barrier.h>
#include <arch/lib_helpers.h>
+#include <types.h>
/* dcache clean by virtual address to PoC */
void dcache_clean_by_mva(void const *addr, size_t len);
diff --git a/src/arch/riscv/misaligned.c b/src/arch/riscv/misaligned.c
index ebff2d6..7ae123f 100644
--- a/src/arch/riscv/misaligned.c
+++ b/src/arch/riscv/misaligned.c
@@ -13,11 +13,10 @@
* GNU General Public License for more details.
*/
-#include <stddef.h>
-#include <stdint.h>
#include <vm.h>
#include <arch/exception.h>
#include <commonlib/helpers.h>
+#include <types.h>
/* these functions are defined in src/arch/riscv/fp_asm.S */
#if defined(__riscv_flen)
diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h
index 6fd9f73..e8d68e7 100644
--- a/src/arch/x86/include/arch/acpigen.h
+++ b/src/arch/x86/include/arch/acpigen.h
@@ -14,11 +14,10 @@
#ifndef LIBACPI_H
#define LIBACPI_H
-#include <stdlib.h>
-#include <stdint.h>
#include <arch/acpi.h>
#include <arch/acpi_device.h>
#include <arch/acpi_pld.h>
+#include <types.h>
/* Values that can be returned for ACPI Device _STA method */
#define ACPI_STATUS_DEVICE_PRESENT (1 << 0)
diff --git a/src/arch/x86/include/arch/ebda.h b/src/arch/x86/include/arch/ebda.h
index 6ee3332..638d2ad 100644
--- a/src/arch/x86/include/arch/ebda.h
+++ b/src/arch/x86/include/arch/ebda.h
@@ -15,8 +15,7 @@
#ifndef __ARCH_EBDA_H
#define __ARCH_EBDA_H
-#include <stdint.h>
-#include <stddef.h>
+#include <types.h>
#define X86_BDA_SIZE 0x200
#define X86_BDA_BASE ((void *)0x400)
diff --git a/src/arch/x86/include/smm.h b/src/arch/x86/include/smm.h
index 320bac6..eec1a36 100644
--- a/src/arch/x86/include/smm.h
+++ b/src/arch/x86/include/smm.h
@@ -11,9 +11,8 @@
* GNU General Public License for more details.
*/
-#include <stddef.h>
-#include <stdint.h>
#include <cpu/x86/smm.h>
+#include <types.h>
/*
* calls into SMM with the given cmd and subcmd in eax, and arg in ebx
diff --git a/src/commonlib/storage/bouncebuf.h b/src/commonlib/storage/bouncebuf.h
index 3e702fa..d43df47 100644
--- a/src/commonlib/storage/bouncebuf.h
+++ b/src/commonlib/storage/bouncebuf.h
@@ -17,9 +17,7 @@
#ifndef __COMMONLIB_STORAGE_BOUNCEBUF_H__
#define __COMMONLIB_STORAGE_BOUNCEBUF_H__
-#include <stddef.h>
-#include <stdint.h>
-#include <stdlib.h>
+#include <types.h>
/*
* GEN_BB_READ -- Data are read from the buffer eg. by DMA hardware.
diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c
index 1d7e7ee..a2b10cd 100644
--- a/src/ec/google/chromeec/ec_lpc.c
+++ b/src/ec/google/chromeec/ec_lpc.c
@@ -19,8 +19,7 @@
#include <delay.h>
#include <device/pnp.h>
#include <ec/google/common/mec.h>
-#include <stdint.h>
-#include <stdlib.h>
+#include <types.h>
#include "chip.h"
#include "ec.h"
diff --git a/src/ec/google/chromeec/vstore.c b/src/ec/google/chromeec/vstore.c
index 28c2603..f5e01f0 100644
--- a/src/ec/google/chromeec/vstore.c
+++ b/src/ec/google/chromeec/vstore.c
@@ -13,9 +13,9 @@
* GNU General Public License for more details.
*/
-#include <stdint.h>
#include <string.h>
-#include <stdlib.h>
+#include <types.h>
+
#include "ec.h"
#include "ec_commands.h"
diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c
index 09211f8..478d00d 100644
--- a/src/ec/google/wilco/chip.c
+++ b/src/ec/google/wilco/chip.c
@@ -21,8 +21,7 @@
#include <device/pnp.h>
#include <ec/acpi/ec.h>
#include <pc80/keyboard.h>
-#include <stdint.h>
-#include <stdlib.h>
+#include <types.h>
#include "commands.h"
#include "ec.h"
diff --git a/src/include/device/i2c_bus.h b/src/include/device/i2c_bus.h
index 5302d20..35c2c05 100644
--- a/src/include/device/i2c_bus.h
+++ b/src/include/device/i2c_bus.h
@@ -14,10 +14,9 @@
#ifndef _DEVICE_I2C_BUS_H_
#define _DEVICE_I2C_BUS_H_
-#include <stdlib.h>
-#include <stdint.h>
#include <device/i2c.h>
#include <device/device.h>
+#include <types.h>
/* I2C bus operation for ramstage drivers */
struct i2c_bus_operations {
diff --git a/src/lib/bootmem.c b/src/lib/bootmem.c
index 8ca3bbd..1a0abde 100644
--- a/src/lib/bootmem.c
+++ b/src/lib/bootmem.c
@@ -19,9 +19,9 @@
#include <bootmem.h>
#include <cbmem.h>
#include <device/resource.h>
-#include <stdlib.h>
#include <symbols.h>
#include <assert.h>
+#include <types.h>
static int initialized;
static int table_written;
diff --git a/src/lib/fit.c b/src/lib/fit.c
index 831e518..5858241 100644
--- a/src/lib/fit.c
+++ b/src/lib/fit.c
@@ -19,10 +19,9 @@
#include <console/console.h>
#include <ctype.h>
#include <endian.h>
-#include <stdint.h>
#include <bootmem.h>
-#include <stdlib.h>
#include <string.h>
+#include <types.h>
#include <program_loading.h>
#include <memrange.h>
#include <fit.h>
diff --git a/src/lib/imd_cbmem.c b/src/lib/imd_cbmem.c
index 6fd48d5..9cd4f37 100644
--- a/src/lib/imd_cbmem.c
+++ b/src/lib/imd_cbmem.c
@@ -21,7 +21,7 @@
#include <cbmem.h>
#include <imd.h>
#include <lib.h>
-#include <stdlib.h>
+#include <types.h>
/* The program loader passes on cbmem_top and the program entry point
has to fill in the _cbmem_top_ptr symbol based on the calling arguments. */
diff --git a/src/lib/rmodule.c b/src/lib/rmodule.c
index 56529d2..6b5874c 100644
--- a/src/lib/rmodule.c
+++ b/src/lib/rmodule.c
@@ -15,12 +15,11 @@
#include <assert.h>
#include <cbmem.h>
#include <cbfs.h>
-#include <stdint.h>
-#include <stdlib.h>
#include <string.h>
#include <console/console.h>
#include <program_loading.h>
#include <rmodule.h>
+#include <types.h>
/* Change this define to get more verbose debugging for module loading. */
#define PK_ADJ_LEVEL BIOS_NEVER
diff --git a/src/soc/amd/stoneyridge/BiosCallOuts.c b/src/soc/amd/stoneyridge/BiosCallOuts.c
index c55e734..69e1778 100644
--- a/src/soc/amd/stoneyridge/BiosCallOuts.c
+++ b/src/soc/amd/stoneyridge/BiosCallOuts.c
@@ -21,10 +21,10 @@
#include <console/console.h>
#include <soc/southbridge.h>
#include <soc/pci_devs.h>
-#include <stdlib.h>
#include <amdblocks/agesawrapper.h>
#include <amdblocks/dimm_spd.h>
#include <amdblocks/car.h>
+#include <types.h>
#include "chip.h"
diff --git a/src/soc/cavium/cn81xx/spi.c b/src/soc/cavium/cn81xx/spi.c
index 2ba25a2..7a89530 100644
--- a/src/soc/cavium/cn81xx/spi.c
+++ b/src/soc/cavium/cn81xx/spi.c
@@ -25,8 +25,8 @@
#include <soc/clock.h>
#include <spi-generic.h>
#include <spi_flash.h>
-#include <stdlib.h>
#include <timer.h>
+#include <types.h>
union cavium_spi_cfg {
u64 u;
diff --git a/src/soc/intel/common/block/fast_spi/fast_spi.c b/src/soc/intel/common/block/fast_spi/fast_spi.c
index 5c29add..1906fb3 100644
--- a/src/soc/intel/common/block/fast_spi/fast_spi.c
+++ b/src/soc/intel/common/block/fast_spi/fast_spi.c
@@ -25,7 +25,7 @@
#include <soc/pci_devs.h>
#include <spi_flash.h>
#include <spi-generic.h>
-#include <stdlib.h>
+#include <types.h>
/*
* Get the FAST_SPIBAR.
diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c
index f90a165..8e6484f 100644
--- a/src/soc/intel/skylake/me.c
+++ b/src/soc/intel/skylake/me.c
@@ -22,8 +22,7 @@
#include <soc/iomap.h>
#include <soc/me.h>
#include <soc/pci_devs.h>
-#include <stdint.h>
-#include <stdlib.h>
+#include <types.h>
/* HFSTS1[3:0] Current Working State Values */
diff --git a/src/soc/samsung/exynos5250/spi.c b/src/soc/samsung/exynos5250/spi.c
index e35f888..bdcec1f 100644
--- a/src/soc/samsung/exynos5250/spi.c
+++ b/src/soc/samsung/exynos5250/spi.c
@@ -21,8 +21,8 @@
#include <soc/clk.h>
#include <soc/gpio.h>
#include <soc/spi.h>
-#include <stdlib.h>
#include <symbols.h>
+#include <types.h>
#if defined(CONFIG_DEBUG_SPI) && CONFIG_DEBUG_SPI
# define DEBUG_SPI(x,...) printk(BIOS_DEBUG, "EXYNOS_SPI: " x)
diff --git a/src/soc/samsung/exynos5420/spi.c b/src/soc/samsung/exynos5420/spi.c
index 1903f6b..2f2ba5a 100644
--- a/src/soc/samsung/exynos5420/spi.c
+++ b/src/soc/samsung/exynos5420/spi.c
@@ -20,9 +20,9 @@
#include <soc/cpu.h>
#include <soc/spi.h>
#include <spi-generic.h>
-#include <stdlib.h>
#include <string.h>
#include <symbols.h>
+#include <types.h>
#define EXYNOS_SPI_MAX_TRANSFER_BYTES (65535)
diff --git a/src/soc/sifive/fu540/clock.c b/src/soc/sifive/fu540/clock.c
index 60a8a13..82491a6 100644
--- a/src/soc/sifive/fu540/clock.c
+++ b/src/soc/sifive/fu540/clock.c
@@ -17,8 +17,7 @@
#include <console/console.h>
#include <soc/clock.h>
#include <soc/addressmap.h>
-#include <stdlib.h>
-#include <stdint.h>
+#include <types.h>
// 33.33 Mhz after reset
#define FU540_BASE_FQY 33330
--
To view, visit https://review.coreboot.org/c/coreboot/+/37364
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e0c2a4dfaa5b1cde0dd4a9e213be0b383e1017f
Gerrit-Change-Number: 37364
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
1
2
Change in coreboot[master]: src: Add missing include <stddef.h>
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37365 )
Change subject: src: Add missing include <stddef.h>
......................................................................
src: Add missing include <stddef.h>
Also use <types.h> when <stdint.h> and <stddef.h> are needed.
Some uneeded include <stdlib.h> removes.
Change-Id: I619ae22679d86a4d0b565a3717f0fb9aa487eb8b
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/arm64/fit_payload.c
M src/arch/x86/acpi_device.c
M src/arch/x86/include/arch/early_variables.h
M src/commonlib/mem_pool.c
M src/commonlib/region.c
M src/lib/coreboot_table.c
M src/security/tpm/tspi/tspi.c
M src/security/tpm/tss/tcg-2.0/tss_marshaling.c
M src/soc/amd/stoneyridge/northbridge.c
M src/soc/intel/skylake/pmutil.c
M src/soc/qualcomm/ipq40xx/spi.c
11 files changed, 15 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/37365/1
diff --git a/src/arch/arm64/fit_payload.c b/src/arch/arm64/fit_payload.c
index 4ade1c7..c9023a4 100644
--- a/src/arch/arm64/fit_payload.c
+++ b/src/arch/arm64/fit_payload.c
@@ -14,8 +14,8 @@
#include <console/console.h>
#include <bootmem.h>
-#include <stdlib.h>
#include <program_loading.h>
+#include <stddef.h>
#include <string.h>
#include <commonlib/compression.h>
#include <commonlib/cbfs_serialized.h>
diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c
index d367108..f0b3127 100644
--- a/src/arch/x86/acpi_device.c
+++ b/src/arch/x86/acpi_device.c
@@ -20,6 +20,8 @@
#if CONFIG(GENERIC_GPIO_LIB)
#include <gpio.h>
#endif
+#include <stddef.h>
+#include <stdlib.h>
#define ACPI_DP_UUID "daffd814-6eba-4d8c-8a91-bc9bbf4aa301"
#define ACPI_DP_CHILD_UUID "dbb8e3e6-5886-4ba6-8795-1319f52a966b"
diff --git a/src/arch/x86/include/arch/early_variables.h b/src/arch/x86/include/arch/early_variables.h
index 7393cc9..6025dd2 100644
--- a/src/arch/x86/include/arch/early_variables.h
+++ b/src/arch/x86/include/arch/early_variables.h
@@ -16,7 +16,7 @@
#include <arch/symbols.h>
#include <commonlib/helpers.h>
-#include <stdlib.h>
+#include <stddef.h>
#if ENV_ROMSTAGE && CONFIG(CAR_GLOBAL_MIGRATION)
diff --git a/src/commonlib/mem_pool.c b/src/commonlib/mem_pool.c
index 0aa821b..3040661 100644
--- a/src/commonlib/mem_pool.c
+++ b/src/commonlib/mem_pool.c
@@ -13,6 +13,8 @@
#include <commonlib/helpers.h>
#include <commonlib/mem_pool.h>
+#include <stddef.h>
+#include <stdlib.h>
void *mem_pool_alloc(struct mem_pool *mp, size_t sz)
{
diff --git a/src/commonlib/region.c b/src/commonlib/region.c
index 4a7e285..106357a 100644
--- a/src/commonlib/region.c
+++ b/src/commonlib/region.c
@@ -13,6 +13,8 @@
#include <commonlib/helpers.h>
#include <commonlib/region.h>
+#include <stddef.h>
+#include <stdlib.h>
#include <string.h>
int region_is_subregion(const struct region *p, const struct region *c)
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index 7245a63..edd5c47 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -27,11 +27,11 @@
#include <boardid.h>
#include <device/device.h>
#include <fmap.h>
-#include <stdlib.h>
#include <cbfs.h>
#include <cbmem.h>
#include <bootmem.h>
#include <bootsplash.h>
+#include <stddef.h>
#include <spi_flash.h>
#include <security/vboot/misc.h>
#include <security/vboot/vbnv_layout.h>
diff --git a/src/security/tpm/tspi/tspi.c b/src/security/tpm/tspi/tspi.c
index 966b8b7..0ae1d84 100644
--- a/src/security/tpm/tspi/tspi.c
+++ b/src/security/tpm/tspi/tspi.c
@@ -19,12 +19,12 @@
#include <console/console.h>
#include <security/tpm/tspi.h>
#include <security/tpm/tss.h>
-#include <stdlib.h>
#if CONFIG(VBOOT)
#include <vb2_api.h>
#include <vb2_sha.h>
#include <assert.h>
#endif
+#include <stddef.h>
#if CONFIG(TPM1)
static uint32_t tpm1_invoke_state_machine(void)
diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c
index 720e7c4..9b4a42b 100644
--- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c
+++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c
@@ -7,8 +7,9 @@
#include <commonlib/iobuf.h>
#include <console/console.h>
-#include <stdlib.h>
+#include <stddef.h>
#include <string.h>
+#include <types.h>
#include "tss_marshaling.h"
#include <security/tpm/tss/vendor/cr50/cr50.h>
diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c
index 044a1b0..b988926 100644
--- a/src/soc/amd/stoneyridge/northbridge.c
+++ b/src/soc/amd/stoneyridge/northbridge.c
@@ -35,8 +35,8 @@
#include <soc/southbridge.h>
#include <soc/pci_devs.h>
#include <soc/iomap.h>
+#include <stddef.h>
#include <stdint.h>
-#include <stdlib.h>
#include <string.h>
#include <arch/bert_storage.h>
diff --git a/src/soc/intel/skylake/pmutil.c b/src/soc/intel/skylake/pmutil.c
index eb36e48..89582f9 100644
--- a/src/soc/intel/skylake/pmutil.c
+++ b/src/soc/intel/skylake/pmutil.c
@@ -29,7 +29,6 @@
#include <intelblocks/pmclib.h>
#include <intelblocks/lpc_lib.h>
#include <intelblocks/tco.h>
-#include <stdlib.h>
#include <soc/gpe.h>
#include <soc/gpio.h>
#include <soc/iomap.h>
@@ -38,6 +37,7 @@
#include <soc/pmc.h>
#include <soc/smbus.h>
#include <security/vboot/vbnv.h>
+#include <stddef.h>
#include "chip.h"
diff --git a/src/soc/qualcomm/ipq40xx/spi.c b/src/soc/qualcomm/ipq40xx/spi.c
index b68e1cb..72a5b9d 100644
--- a/src/soc/qualcomm/ipq40xx/spi.c
+++ b/src/soc/qualcomm/ipq40xx/spi.c
@@ -33,7 +33,7 @@
#include <gpio.h>
#include <soc/iomap.h>
#include <soc/spi.h>
-#include <stdlib.h>
+#include <stddef.h>
static const struct blsp_spi spi_reg[] = {
/* BLSP0 registers for SPI interface */
--
To view, visit https://review.coreboot.org/c/coreboot/+/37365
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I619ae22679d86a4d0b565a3717f0fb9aa487eb8b
Gerrit-Change-Number: 37365
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
1
4
Change in coreboot[master]: [test] Don't compile vboot when it is not set
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37801 )
Change subject: [test] Don't compile vboot when it is not set
......................................................................
[test] Don't compile vboot when it is not set
Change-Id: I9adbc227ac6f91caf194a5212a4503dbaa0e36ad
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/arch/x86/postcar_loader.c
M src/cpu/intel/car/romstage.c
M src/device/pci_device.c
M src/drivers/pc80/rtc/mc146818rtc.c
M src/lib/bootmode.c
M src/lib/cbfs.c
M src/lib/coreboot_table.c
M src/lib/prog_loaders.c
M src/southbridge/intel/common/pmbase.c
M src/southbridge/intel/common/rtc.c
10 files changed, 50 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/37801/1
diff --git a/src/arch/x86/postcar_loader.c b/src/arch/x86/postcar_loader.c
index b53cbf8..f60673e 100644
--- a/src/arch/x86/postcar_loader.c
+++ b/src/arch/x86/postcar_loader.c
@@ -23,7 +23,9 @@
#include <romstage_handoff.h>
#include <stage_cache.h>
#include <timestamp.h>
+#if CONFIG(VBOOT)
#include <security/vboot/vboot_common.h>
+#endif
static inline void stack_push(struct postcar_frame *pcf, uint32_t val)
{
@@ -171,9 +173,9 @@
.cbmem_id = CBMEM_ID_AFTER_CAR,
.prog = prog,
};
-
+#if CONFIG(VBOOT)
vboot_run_logic();
-
+#endif
if (prog_locate(prog))
die_with_post_code(POST_INVALID_ROM,
"Failed to locate after CAR program.\n");
diff --git a/src/cpu/intel/car/romstage.c b/src/cpu/intel/car/romstage.c
index bd6a5a9..bd894d3 100644
--- a/src/cpu/intel/car/romstage.c
+++ b/src/cpu/intel/car/romstage.c
@@ -21,7 +21,9 @@
#include <commonlib/helpers.h>
#include <program_loading.h>
#include <timestamp.h>
+#if CONFIG(VBOOT)
#include <security/vboot/vboot_common.h>
+#endif
/* If we do not have a constrained _car_stack region size, use the
following as a guideline for acceptable stack usage. */
@@ -51,10 +53,10 @@
for (i = 0; i < num_guards; i++)
stack_base[i] = stack_guard;
-
+#if CONFIG(VBOOT)
if (CONFIG(VBOOT_EARLY_EC_SYNC))
vboot_sync_ec();
-
+#endif
mainboard_romstage_entry();
/* Check the stack. */
diff --git a/src/device/pci_device.c b/src/device/pci_device.c
index 36b7c82..99bc539 100644
--- a/src/device/pci_device.c
+++ b/src/device/pci_device.c
@@ -32,7 +32,9 @@
#include <device/pciexp.h>
#include <device/hypertransport.h>
#include <pc80/i8259.h>
+#if CONFIG(VBOOT)
#include <security/vboot/vbnv.h>
+#endif
#include <timestamp.h>
#include <types.h>
@@ -683,11 +685,12 @@
{
static int should_run = -1;
+#if CONFIG(VBOOT)
if (CONFIG(VENDORCODE_ELTAN_VBOOT))
if (rom != NULL)
if (!verified_boot_should_run_oprom(rom))
return 0;
-
+#endif
if (should_run >= 0)
return should_run;
diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c
index d3efdec..6622e0b 100644
--- a/src/drivers/pc80/rtc/mc146818rtc.c
+++ b/src/drivers/pc80/rtc/mc146818rtc.c
@@ -21,8 +21,10 @@
#include <rtc.h>
#include <string.h>
#include <cbfs.h>
+#if CONFIG(VBOOT)
#include <security/vboot/vbnv.h>
#include <security/vboot/vbnv_layout.h>
+#endif
#include <types.h>
/* There's no way around this include guard. option_table.h is autogenerated */
@@ -164,6 +166,7 @@
return clear_cmos;
}
+#if CONFIG(VBOOT)
static void cmos_init_vbnv(bool invalid)
{
uint8_t vbnv[VBOOT_VBNV_BLOCK_SIZE];
@@ -178,15 +181,18 @@
if (__cmos_init(invalid))
save_vbnv_cmos(vbnv);
}
+#endif
void cmos_init(bool invalid)
{
if (ENV_SMM)
return;
+#if CONFIG(VBOOT)
if (CONFIG(VBOOT_VBNV_CMOS))
cmos_init_vbnv(invalid);
else
+#endif
__cmos_init(invalid);
}
diff --git a/src/lib/bootmode.c b/src/lib/bootmode.c
index 06f6d05..102ba39 100644
--- a/src/lib/bootmode.c
+++ b/src/lib/bootmode.c
@@ -15,8 +15,10 @@
#include <assert.h>
#include <bootmode.h>
+#if CONFIG(VBOOT)
#include <security/vboot/misc.h>
#include <vb2_api.h>
+#endif
static int gfx_init_done = -1;
@@ -35,13 +37,13 @@
int display_init_required(void)
{
/* For vboot, always honor VB2_CONTEXT_DISPLAY_INIT. */
- if (CONFIG(VBOOT)) {
+#if CONFIG(VBOOT)
/* Must always select MUST_REQUEST_DISPLAY when using this
function. */
if (!CONFIG(VBOOT_MUST_REQUEST_DISPLAY))
dead_code();
return vboot_get_context()->flags & VB2_CONTEXT_DISPLAY_INIT;
- }
+#endif
/* By default always initialize display. */
return 1;
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c
index 636ff70..85ff17d 100644
--- a/src/lib/cbfs.c
+++ b/src/lib/cbfs.c
@@ -26,7 +26,9 @@
#include <symbols.h>
#include <timestamp.h>
#include <fmap.h>
+#if CONFIG(VBOOT)
#include <security/vboot/vboot_crtm.h>
+#endif
#define ERROR(x...) printk(BIOS_ERR, "CBFS: " x)
#define LOG(x...) printk(BIOS_INFO, "CBFS: " x)
@@ -44,7 +46,7 @@
return -1;
int ret = cbfs_locate(fh, &rdev, name, type);
-
+#if CONFIG(VBOOT)
if (CONFIG(VBOOT_ENABLE_CBFS_FALLBACK) && ret) {
/*
@@ -63,7 +65,7 @@
if (!ret)
if (vboot_measure_cbfs_hook(fh, name))
return -1;
-
+#endif
return ret;
}
@@ -299,7 +301,9 @@
.locate = cbfs_default_region_device,
};
+#if CONFIG(VBOOT)
extern const struct cbfs_locator vboot_locator;
+#endif
static const struct cbfs_locator *locators[] = {
#if CONFIG(VBOOT)
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index e42cb3b..96783be 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -33,8 +33,10 @@
#include <bootmem.h>
#include <bootsplash.h>
#include <spi_flash.h>
+#if CONFIG(VBOOT)
#include <security/vboot/misc.h>
#include <security/vboot/vbnv_layout.h>
+#endif
#if CONFIG(USE_OPTION_TABLE)
#include <option_table.h>
#endif
@@ -204,6 +206,7 @@
}
}
+#if CONFIG(VBOOT)
static void lb_vbnv(struct lb_header *header)
{
#if CONFIG(PC80_SYSTEM)
@@ -216,6 +219,7 @@
vbnv->range_size = VBOOT_VBNV_BLOCK_SIZE;
#endif
}
+#endif /* CONFIG_VBOOT */
#endif /* CONFIG_CHROMEOS */
__weak uint32_t board_id(void) { return UNDEFINED_STRAPPING_ID; }
@@ -332,7 +336,9 @@
{CBMEM_ID_WIFI_CALIBRATION, LB_TAG_WIFI_CALIBRATION},
{CBMEM_ID_TCPA_LOG, LB_TAG_TCPA_LOG},
{CBMEM_ID_FMAP, LB_TAG_FMAP},
+#if CONFIG(VBOOT)
{CBMEM_ID_VBOOT_WORKBUF, LB_TAG_VBOOT_WORKBUF},
+#endif
};
int i;
@@ -537,10 +543,11 @@
#if CONFIG(CHROMEOS)
/* Record our GPIO settings (ChromeOS specific) */
lb_gpios(head);
-
+#if CONFIG(VBOOT
/* pass along VBNV offsets in CMOS */
lb_vbnv(head);
#endif
+#endif
/* Add strapping IDs if available */
lb_board_id(head);
diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c
index 5787496..46a4c38 100644
--- a/src/lib/prog_loaders.c
+++ b/src/lib/prog_loaders.c
@@ -30,8 +30,9 @@
#include <symbols.h>
#include <timestamp.h>
#include <fit_payload.h>
+#if CONFIG(VBOOT)
#include <security/vboot/vboot_common.h>
-
+#endif
/* Only can represent up to 1 byte less than size_t. */
const struct mem_region_device addrspace_32bit =
MEM_REGION_DEV_RO_INIT(0, ~0UL);
@@ -58,8 +59,9 @@
struct prog romstage =
PROG_INIT(PROG_ROMSTAGE, CONFIG_CBFS_PREFIX "/romstage");
+#if CONFIG(VBOOT)
vboot_run_logic();
-
+#endif
if (prog_locate(&romstage))
goto fail;
@@ -138,8 +140,9 @@
!CONFIG(NO_STAGE_CACHE))
run_ramstage_from_resume(&ramstage);
+#if CONFIG(VBOOT)
vboot_run_logic();
-
+#endif
if (prog_locate(&ramstage))
goto fail;
diff --git a/src/southbridge/intel/common/pmbase.c b/src/southbridge/intel/common/pmbase.c
index ff0410a..5705852 100644
--- a/src/southbridge/intel/common/pmbase.c
+++ b/src/southbridge/intel/common/pmbase.c
@@ -20,7 +20,9 @@
#include <device/device.h>
#include <device/pci.h>
#include <assert.h>
+#if CONFIG(VBOOT)
#include <security/vboot/vboot_common.h>
+#endif
#include "pmbase.h"
#include "pmutil.h"
@@ -95,6 +97,7 @@
return inb(lpc_get_pmbase() + addr);
}
+#if CVONFIG(VBOOT)
int vboot_platform_is_resuming(void)
{
u16 reg16 = read_pmbase16(PM1_STS);
@@ -104,3 +107,4 @@
return acpi_sleep_from_pm1(reg16) == ACPI_S3;
}
+#endif
diff --git a/src/southbridge/intel/common/rtc.c b/src/southbridge/intel/common/rtc.c
index 3ee12aa..a1dcdde 100644
--- a/src/southbridge/intel/common/rtc.c
+++ b/src/southbridge/intel/common/rtc.c
@@ -17,7 +17,9 @@
#include <console/console.h>
#include <device/pci_def.h>
#include <device/pci_ops.h>
+#if CONFIG(VBOOT)
#include <security/vboot/vbnv.h>
+#endif
#include <pc80/mc146818rtc.h>
#include <elog.h>
#include "pmutil.h"
@@ -52,7 +54,9 @@
cmos_init(rtc_failed);
}
+#if CONFIG(VBOOT)
int vbnv_cmos_failed(void)
{
return rtc_failure();
}
+#endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/37801
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9adbc227ac6f91caf194a5212a4503dbaa0e36ad
Gerrit-Change-Number: 37801
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
2
6
Change in coreboot[master]: sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36227 )
Change subject: sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments
......................................................................
sb/amd/cimx/{sb800,sb900}: Remove some superfluous comments
Change-Id: Ied64879d294670d452845ff47d417d595b72864a
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/southbridge/amd/cimx/sb800/late.c
M src/southbridge/amd/cimx/sb800/smbus.c
M src/southbridge/amd/cimx/sb900/late.c
M src/southbridge/amd/cimx/sb900/lpc.c
M src/southbridge/amd/cimx/sb900/smbus.c
5 files changed, 9 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/36227/1
diff --git a/src/southbridge/amd/cimx/sb800/late.c b/src/southbridge/amd/cimx/sb800/late.c
index 4233a6f..67938c5 100644
--- a/src/southbridge/amd/cimx/sb800/late.c
+++ b/src/southbridge/amd/cimx/sb800/late.c
@@ -17,16 +17,16 @@
#include <device/mmio.h>
#include <device/device.h>
-#include <device/pci.h> /* device_operations */
+#include <device/pci.h>
#include <device/pci_ops.h>
#include <device/pci_ids.h>
#include <bootstate.h>
#include <arch/ioapic.h>
-#include <device/smbus.h> /* smbus_bus_operations */
+#include <device/smbus.h>
#include <pc80/mc146818rtc.h>
#include <pc80/i8254.h>
#include <pc80/i8259.h>
-#include <console/console.h> /* printk */
+#include <console/console.h>
#include <arch/acpi.h>
#include <device/pci_ehci.h>
#include "lpc.h" /* lpc_read_resources */
diff --git a/src/southbridge/amd/cimx/sb800/smbus.c b/src/southbridge/amd/cimx/sb800/smbus.c
index a4426ff..f54bcd3 100644
--- a/src/southbridge/amd/cimx/sb800/smbus.c
+++ b/src/southbridge/amd/cimx/sb800/smbus.c
@@ -13,10 +13,9 @@
* GNU General Public License for more details.
*/
-
#include <arch/io.h>
#include "smbus.h"
-#include <console/console.h> /* printk */
+#include <console/console.h>
static int smbus_wait_until_ready(u32 smbus_io_base)
{
diff --git a/src/southbridge/amd/cimx/sb900/late.c b/src/southbridge/amd/cimx/sb900/late.c
index 3a65e33..423b996 100644
--- a/src/southbridge/amd/cimx/sb900/late.c
+++ b/src/southbridge/amd/cimx/sb900/late.c
@@ -13,15 +13,14 @@
* GNU General Public License for more details.
*/
-
#include <device/device.h>
-#include <device/pci.h> /* device_operations */
+#include <device/pci.h>
#include <device/pci_ids.h>
-#include <device/smbus.h> /* smbus_bus_operations */
+#include <device/smbus.h>
#include <pc80/mc146818rtc.h>
#include <pc80/i8254.h>
#include <pc80/i8259.h>
-#include <console/console.h> /* printk */
+#include <console/console.h>
#include <device/pci_ehci.h>
#include <arch/acpi.h>
#include "lpc.h" /* lpc_read_resources */
diff --git a/src/southbridge/amd/cimx/sb900/lpc.c b/src/southbridge/amd/cimx/sb900/lpc.c
index 8e7c1cc..3f365bd 100644
--- a/src/southbridge/amd/cimx/sb900/lpc.c
+++ b/src/southbridge/amd/cimx/sb900/lpc.c
@@ -16,10 +16,9 @@
#include <device/pci.h>
#include <device/pci_ops.h>
#include "lpc.h"
-#include <console/console.h> /* printk */
+#include <console/console.h>
#include <arch/ioapic.h>
-
void lpc_read_resources(struct device *dev)
{
struct resource *res;
diff --git a/src/southbridge/amd/cimx/sb900/smbus.c b/src/southbridge/amd/cimx/sb900/smbus.c
index 389aa8e..cc76c64 100644
--- a/src/southbridge/amd/cimx/sb900/smbus.c
+++ b/src/southbridge/amd/cimx/sb900/smbus.c
@@ -13,10 +13,9 @@
* GNU General Public License for more details.
*/
-
#include <arch/io.h>
#include "smbus.h"
-#include <console/console.h> /* printk */
+#include <console/console.h>
static int smbus_wait_until_ready(u32 smbus_io_base)
{
--
To view, visit https://review.coreboot.org/c/coreboot/+/36227
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied64879d294670d452845ff47d417d595b72864a
Gerrit-Change-Number: 36227
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
2
6
Change in coreboot[master]: src/soc: Remove unuse '#include <device/pci.h>'
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37521 )
Change subject: src/soc: Remove unuse '#include <device/pci.h>'
......................................................................
src/soc: Remove unuse '#include <device/pci.h>'
Change-Id: I5bdbefba59866a89e5380ffcad4695b31071c8a7
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/soc/amd/picasso/acpi.c
M src/soc/amd/picasso/chip.c
M src/soc/amd/picasso/sata.c
M src/soc/amd/picasso/southbridge.c
M src/soc/amd/stoneyridge/acpi.c
M src/soc/amd/stoneyridge/chip.c
M src/soc/amd/stoneyridge/sata.c
M src/soc/amd/stoneyridge/southbridge.c
M src/soc/cavium/cn81xx/sdram.c
M src/soc/cavium/cn81xx/soc.c
M src/soc/cavium/common/ecam.c
M src/soc/intel/apollolake/bootblock/bootblock.c
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/cpu.c
M src/soc/intel/apollolake/lpc.c
M src/soc/intel/apollolake/pmc.c
M src/soc/intel/apollolake/pmutil.c
M src/soc/intel/apollolake/xdci.c
M src/soc/intel/baytrail/elog.c
M src/soc/intel/baytrail/gpio.c
M src/soc/intel/baytrail/pmutil.c
M src/soc/intel/baytrail/scc.c
M src/soc/intel/baytrail/smm.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/braswell/elog.c
M src/soc/intel/braswell/gpio.c
M src/soc/intel/braswell/pmutil.c
M src/soc/intel/braswell/scc.c
M src/soc/intel/braswell/smm.c
M src/soc/intel/broadwell/cpu.c
M src/soc/intel/broadwell/gpio.c
M src/soc/intel/broadwell/me_status.c
M src/soc/intel/broadwell/memmap.c
M src/soc/intel/broadwell/pch.c
M src/soc/intel/broadwell/pmutil.c
M src/soc/intel/broadwell/romstage/power_state.c
M src/soc/intel/broadwell/romstage/report_platform.c
M src/soc/intel/broadwell/smbus_common.c
M src/soc/intel/broadwell/smi.c
M src/soc/intel/broadwell/smmrelocate.c
M src/soc/intel/cannonlake/bootblock/report_platform.c
M src/soc/intel/cannonlake/chip.c
M src/soc/intel/cannonlake/cpu.c
M src/soc/intel/cannonlake/finalize.c
M src/soc/intel/cannonlake/fsp_params.c
M src/soc/intel/cannonlake/lpc.c
M src/soc/intel/cannonlake/me.c
M src/soc/intel/cannonlake/pmutil.c
M src/soc/intel/cannonlake/smmrelocate.c
M src/soc/intel/cannonlake/systemagent.c
M src/soc/intel/common/block/include/intelblocks/imc.h
M src/soc/intel/common/block/lpc/lpc_lib.c
M src/soc/intel/common/block/scs/early_mmc.c
M src/soc/intel/common/block/smbus/tco.c
M src/soc/intel/common/block/systemagent/systemagent_early.c
M src/soc/intel/denverton_ns/acpi.c
M src/soc/intel/denverton_ns/bootblock/bootblock.c
M src/soc/intel/denverton_ns/cpu.c
M src/soc/intel/denverton_ns/gpio_dnv.c
M src/soc/intel/denverton_ns/smm.c
M src/soc/intel/denverton_ns/soc_util.c
M src/soc/intel/icelake/bootblock/report_platform.c
M src/soc/intel/icelake/chip.c
M src/soc/intel/icelake/cpu.c
M src/soc/intel/icelake/espi.c
M src/soc/intel/icelake/finalize.c
M src/soc/intel/icelake/fsp_params.c
M src/soc/intel/icelake/pmutil.c
M src/soc/intel/icelake/smmrelocate.c
M src/soc/intel/icelake/systemagent.c
M src/soc/intel/quark/i2c.c
M src/soc/intel/quark/include/soc/pci_devs.h
M src/soc/intel/quark/include/soc/storage_test.h
M src/soc/intel/quark/romstage/report_platform.c
M src/soc/intel/skylake/bootblock/report_platform.c
M src/soc/intel/skylake/cpu.c
M src/soc/intel/skylake/finalize.c
M src/soc/intel/skylake/irq.c
M src/soc/intel/skylake/lpc.c
M src/soc/intel/skylake/me.c
M src/soc/intel/skylake/pmutil.c
M src/soc/intel/skylake/smmrelocate.c
M src/soc/intel/tigerlake/bootblock/report_platform.c
M src/soc/intel/tigerlake/chip.c
M src/soc/intel/tigerlake/cpu.c
M src/soc/intel/tigerlake/espi.c
M src/soc/intel/tigerlake/finalize.c
M src/soc/intel/tigerlake/pmutil.c
M src/soc/intel/tigerlake/smmrelocate.c
M src/soc/intel/tigerlake/systemagent.c
90 files changed, 0 insertions(+), 90 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/37521/1
diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c
index 7b70ec6..4534f6a 100644
--- a/src/soc/amd/picasso/acpi.c
+++ b/src/soc/amd/picasso/acpi.c
@@ -27,7 +27,6 @@
#include <cpu/x86/smm.h>
#include <cbmem.h>
#include <device/device.h>
-#include <device/pci.h>
#include <amdblocks/acpimmio.h>
#include <amdblocks/acpi.h>
#include <soc/acpi.h>
diff --git a/src/soc/amd/picasso/chip.c b/src/soc/amd/picasso/chip.c
index cf02030..6c05a56 100644
--- a/src/soc/amd/picasso/chip.c
+++ b/src/soc/amd/picasso/chip.c
@@ -16,7 +16,6 @@
#include <bootstate.h>
#include <cpu/amd/mtrr.h>
#include <device/device.h>
-#include <device/pci.h>
#include <drivers/i2c/designware/dw_i2c.h>
#include <romstage_handoff.h>
#include <soc/acpi.h>
diff --git a/src/soc/amd/picasso/sata.c b/src/soc/amd/picasso/sata.c
index d67f5b4..3d2571d 100644
--- a/src/soc/amd/picasso/sata.c
+++ b/src/soc/amd/picasso/sata.c
@@ -14,7 +14,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <device/pci_def.h>
#include <amdblocks/sata.h>
diff --git a/src/soc/amd/picasso/southbridge.c b/src/soc/amd/picasso/southbridge.c
index 0dff4bc..757656e 100644
--- a/src/soc/amd/picasso/southbridge.c
+++ b/src/soc/amd/picasso/southbridge.c
@@ -19,7 +19,6 @@
#include <cpu/x86/smm.h>
#include <cpu/x86/msr.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <cbmem.h>
#include <amdblocks/amd_pci_util.h>
diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c
index 13020ed..2cd4519 100644
--- a/src/soc/amd/stoneyridge/acpi.c
+++ b/src/soc/amd/stoneyridge/acpi.c
@@ -27,7 +27,6 @@
#include <cpu/x86/smm.h>
#include <cbmem.h>
#include <device/device.h>
-#include <device/pci.h>
#include <amdblocks/acpimmio.h>
#include <amdblocks/acpi.h>
#include <soc/acpi.h>
diff --git a/src/soc/amd/stoneyridge/chip.c b/src/soc/amd/stoneyridge/chip.c
index 7221f95..ca2f3c3 100644
--- a/src/soc/amd/stoneyridge/chip.c
+++ b/src/soc/amd/stoneyridge/chip.c
@@ -17,7 +17,6 @@
#include <console/console.h>
#include <cpu/amd/mtrr.h>
#include <device/device.h>
-#include <device/pci.h>
#include <drivers/i2c/designware/dw_i2c.h>
#include <romstage_handoff.h>
#include <soc/acpi.h>
diff --git a/src/soc/amd/stoneyridge/sata.c b/src/soc/amd/stoneyridge/sata.c
index d67f5b4..3d2571d 100644
--- a/src/soc/amd/stoneyridge/sata.c
+++ b/src/soc/amd/stoneyridge/sata.c
@@ -14,7 +14,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <device/pci_def.h>
#include <amdblocks/sata.h>
diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c
index 1b2afec..1c10339 100644
--- a/src/soc/amd/stoneyridge/southbridge.c
+++ b/src/soc/amd/stoneyridge/southbridge.c
@@ -18,7 +18,6 @@
#include <bootstate.h>
#include <cpu/x86/smm.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <cbmem.h>
#include <amdblocks/amd_pci_util.h>
diff --git a/src/soc/cavium/cn81xx/sdram.c b/src/soc/cavium/cn81xx/sdram.c
index 71d6b48..1142a8a 100644
--- a/src/soc/cavium/cn81xx/sdram.c
+++ b/src/soc/cavium/cn81xx/sdram.c
@@ -32,7 +32,6 @@
#include <soc/ecam.h>
#include <device/pci_ops.h>
#include <device/mmio.h>
-#include <device/pci.h>
size_t sdram_size_mb(void)
{
diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c
index 8abb328..64177b9 100644
--- a/src/soc/cavium/cn81xx/soc.c
+++ b/src/soc/cavium/cn81xx/soc.c
@@ -32,7 +32,6 @@
#include <soc/ecam0.h>
#include <console/uart.h>
#include <libbdk-hal/bdk-pcie.h>
-#include <device/pci.h>
#include <libbdk-hal/bdk-qlm.h>
#include <libbdk-hal/bdk-config.h>
#include <libbdk-arch/bdk-csrs-bgx.h>
diff --git a/src/soc/cavium/common/ecam.c b/src/soc/cavium/common/ecam.c
index 89c69db..a3fc94c 100644
--- a/src/soc/cavium/common/ecam.c
+++ b/src/soc/cavium/common/ecam.c
@@ -21,7 +21,6 @@
#include <device/pci_ops.h>
#include <device/pci_def.h>
-#include <device/pci.h>
#include <soc/addressmap.h>
#include <soc/ecam.h>
diff --git a/src/soc/intel/apollolake/bootblock/bootblock.c b/src/soc/intel/apollolake/bootblock/bootblock.c
index a07c462..8a51224 100644
--- a/src/soc/intel/apollolake/bootblock/bootblock.c
+++ b/src/soc/intel/apollolake/bootblock/bootblock.c
@@ -17,7 +17,6 @@
#include <bootblock_common.h>
#include <cpu/x86/pae.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <intelblocks/cpulib.h>
#include <intelblocks/fast_spi.h>
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 6c195bb..f41c123 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -25,7 +25,6 @@
#include <cpu/x86/msr.h>
#include <device/mmio.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <intelblocks/acpi.h>
#include <intelblocks/cfg.h>
diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c
index 0b9466c..1da53eb 100644
--- a/src/soc/intel/apollolake/cpu.c
+++ b/src/soc/intel/apollolake/cpu.c
@@ -33,7 +33,6 @@
#include <cpu/intel/em64t100_save_state.h>
#include <cpu/intel/smm_reloc.h>
#include <device/device.h>
-#include <device/pci.h>
#include <fsp/api.h>
#include <intelblocks/cpulib.h>
#include <intelblocks/fast_spi.h>
diff --git a/src/soc/intel/apollolake/lpc.c b/src/soc/intel/apollolake/lpc.c
index 636dd03..660157c 100644
--- a/src/soc/intel/apollolake/lpc.c
+++ b/src/soc/intel/apollolake/lpc.c
@@ -14,7 +14,6 @@
* GNU General Public License for more details.
*/
-#include <device/pci.h>
#include <intelblocks/lpc_lib.h>
#include <intelblocks/rtc.h>
#include <soc/gpio.h>
diff --git a/src/soc/intel/apollolake/pmc.c b/src/soc/intel/apollolake/pmc.c
index 286cd8a..1d59766 100644
--- a/src/soc/intel/apollolake/pmc.c
+++ b/src/soc/intel/apollolake/pmc.c
@@ -19,7 +19,6 @@
#include <console/console.h>
#include <device/mmio.h>
#include <device/device.h>
-#include <device/pci.h>
#include <intelblocks/pmc.h>
#include <intelblocks/pmclib.h>
#include <soc/iomap.h>
diff --git a/src/soc/intel/apollolake/pmutil.c b/src/soc/intel/apollolake/pmutil.c
index 559adad..715b922 100644
--- a/src/soc/intel/apollolake/pmutil.c
+++ b/src/soc/intel/apollolake/pmutil.c
@@ -24,7 +24,6 @@
#include <console/console.h>
#include <cpu/x86/msr.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <intelblocks/msr.h>
#include <intelblocks/pmclib.h>
diff --git a/src/soc/intel/apollolake/xdci.c b/src/soc/intel/apollolake/xdci.c
index 0a85f26..e918f15 100644
--- a/src/soc/intel/apollolake/xdci.c
+++ b/src/soc/intel/apollolake/xdci.c
@@ -16,7 +16,6 @@
#include <device/mmio.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <intelblocks/xdci.h>
#include <soc/pci_devs.h>
#include <timer.h>
diff --git a/src/soc/intel/baytrail/elog.c b/src/soc/intel/baytrail/elog.c
index d7a0460..18708a9 100644
--- a/src/soc/intel/baytrail/elog.c
+++ b/src/soc/intel/baytrail/elog.c
@@ -19,7 +19,6 @@
#include <console/console.h>
#include <cbmem.h>
#include <device/device.h>
-#include <device/pci.h>
#include <elog.h>
#include <soc/iomap.h>
#include <soc/pmc.h>
diff --git a/src/soc/intel/baytrail/gpio.c b/src/soc/intel/baytrail/gpio.c
index 3460a5f..fcc89c2 100644
--- a/src/soc/intel/baytrail/gpio.c
+++ b/src/soc/intel/baytrail/gpio.c
@@ -15,7 +15,6 @@
#include <arch/io.h>
#include <device/mmio.h>
-#include <device/pci.h>
#include <console/console.h>
#include <soc/gpio.h>
#include <soc/pmc.h>
diff --git a/src/soc/intel/baytrail/pmutil.c b/src/soc/intel/baytrail/pmutil.c
index 51174fc..b4b06f3 100644
--- a/src/soc/intel/baytrail/pmutil.c
+++ b/src/soc/intel/baytrail/pmutil.c
@@ -18,7 +18,6 @@
#include <arch/io.h>
#include <device/device.h>
#include <device/mmio.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <cbmem.h>
#include <console/console.h>
diff --git a/src/soc/intel/baytrail/scc.c b/src/soc/intel/baytrail/scc.c
index a6b4fe3..c56c042 100644
--- a/src/soc/intel/baytrail/scc.c
+++ b/src/soc/intel/baytrail/scc.c
@@ -17,7 +17,6 @@
#include <cbmem.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <reg_script.h>
#include <soc/iosf.h>
diff --git a/src/soc/intel/baytrail/smm.c b/src/soc/intel/baytrail/smm.c
index 9f10f70..0aa6f23 100644
--- a/src/soc/intel/baytrail/smm.c
+++ b/src/soc/intel/baytrail/smm.c
@@ -15,7 +15,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <console/console.h>
#include <arch/io.h>
#include <device/mmio.h>
diff --git a/src/soc/intel/braswell/acpi.c b/src/soc/intel/braswell/acpi.c
index f68b7ce..33720b4 100644
--- a/src/soc/intel/braswell/acpi.c
+++ b/src/soc/intel/braswell/acpi.c
@@ -26,7 +26,6 @@
#include <cpu/x86/msr.h>
#include <cpu/x86/smm.h>
#include <cpu/x86/tsc.h>
-#include <device/pci.h>
#include <ec/google/chromeec/ec.h>
#include <drivers/intel/gma/opregion.h>
#include <soc/acpi.h>
diff --git a/src/soc/intel/braswell/elog.c b/src/soc/intel/braswell/elog.c
index 6efcef1..7a82725 100644
--- a/src/soc/intel/braswell/elog.c
+++ b/src/soc/intel/braswell/elog.c
@@ -19,7 +19,6 @@
#include <cbmem.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <elog.h>
#include <soc/iomap.h>
#include <soc/pm.h>
diff --git a/src/soc/intel/braswell/gpio.c b/src/soc/intel/braswell/gpio.c
index 14f95e1..d22e04e 100644
--- a/src/soc/intel/braswell/gpio.c
+++ b/src/soc/intel/braswell/gpio.c
@@ -17,7 +17,6 @@
#include <console/console.h>
#include <arch/io.h>
#include <device/mmio.h>
-#include <device/pci.h>
#include <soc/gpio.h>
#include <soc/pm.h>
#include <soc/smm.h>
diff --git a/src/soc/intel/braswell/pmutil.c b/src/soc/intel/braswell/pmutil.c
index 18cb04d..11930d6 100644
--- a/src/soc/intel/braswell/pmutil.c
+++ b/src/soc/intel/braswell/pmutil.c
@@ -19,7 +19,6 @@
#include <assert.h>
#include <device/device.h>
#include <device/mmio.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <console/console.h>
#include <soc/iomap.h>
diff --git a/src/soc/intel/braswell/scc.c b/src/soc/intel/braswell/scc.c
index 5c874e1..08f4831 100644
--- a/src/soc/intel/braswell/scc.c
+++ b/src/soc/intel/braswell/scc.c
@@ -18,7 +18,6 @@
#include <cbmem.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <soc/iosf.h>
#include <soc/nvs.h>
#include <soc/ramstage.h>
diff --git a/src/soc/intel/braswell/smm.c b/src/soc/intel/braswell/smm.c
index c108a36..2f6610c 100644
--- a/src/soc/intel/braswell/smm.c
+++ b/src/soc/intel/braswell/smm.c
@@ -21,7 +21,6 @@
#include <cpu/x86/smm.h>
#include <cpu/intel/smm_reloc.h>
#include <device/device.h>
-#include <device/pci.h>
#include <soc/iomap.h>
#include <soc/pm.h>
#include <soc/smm.h>
diff --git a/src/soc/intel/broadwell/cpu.c b/src/soc/intel/broadwell/cpu.c
index 287b5b5..4863411 100644
--- a/src/soc/intel/broadwell/cpu.c
+++ b/src/soc/intel/broadwell/cpu.c
@@ -16,7 +16,6 @@
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <arch/cpu.h>
#include <cpu/cpu.h>
#include <cpu/x86/mtrr.h>
diff --git a/src/soc/intel/broadwell/gpio.c b/src/soc/intel/broadwell/gpio.c
index 81ad9d4..2831f85 100644
--- a/src/soc/intel/broadwell/gpio.c
+++ b/src/soc/intel/broadwell/gpio.c
@@ -16,7 +16,6 @@
#include <stdint.h>
#include <arch/io.h>
#include <device/device.h>
-#include <device/pci.h>
#include <soc/gpio.h>
#include <soc/iomap.h>
#include <soc/pm.h>
diff --git a/src/soc/intel/broadwell/me_status.c b/src/soc/intel/broadwell/me_status.c
index d89f108..d494d71 100644
--- a/src/soc/intel/broadwell/me_status.c
+++ b/src/soc/intel/broadwell/me_status.c
@@ -15,7 +15,6 @@
#include <device/pci_ops.h>
#include <console/console.h>
-#include <device/pci.h>
#include <string.h>
#include <soc/pci_devs.h>
#include <soc/me.h>
diff --git a/src/soc/intel/broadwell/memmap.c b/src/soc/intel/broadwell/memmap.c
index 48492d3..837347c 100644
--- a/src/soc/intel/broadwell/memmap.c
+++ b/src/soc/intel/broadwell/memmap.c
@@ -17,7 +17,6 @@
#include <cbmem.h>
#include <cpu/x86/smm.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <soc/pci_devs.h>
#include <soc/systemagent.h>
diff --git a/src/soc/intel/broadwell/pch.c b/src/soc/intel/broadwell/pch.c
index e6c2319..74536c9 100644
--- a/src/soc/intel/broadwell/pch.c
+++ b/src/soc/intel/broadwell/pch.c
@@ -17,7 +17,6 @@
#include <console/console.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <soc/iobp.h>
#include <soc/pch.h>
diff --git a/src/soc/intel/broadwell/pmutil.c b/src/soc/intel/broadwell/pmutil.c
index 00db615..5857cec 100644
--- a/src/soc/intel/broadwell/pmutil.c
+++ b/src/soc/intel/broadwell/pmutil.c
@@ -22,7 +22,6 @@
#include <arch/io.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <console/console.h>
#include <soc/iomap.h>
diff --git a/src/soc/intel/broadwell/romstage/power_state.c b/src/soc/intel/broadwell/romstage/power_state.c
index 1970c31..09ca8c0a 100644
--- a/src/soc/intel/broadwell/romstage/power_state.c
+++ b/src/soc/intel/broadwell/romstage/power_state.c
@@ -18,7 +18,6 @@
#include <cbmem.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <reg_script.h>
#include <stdint.h>
diff --git a/src/soc/intel/broadwell/romstage/report_platform.c b/src/soc/intel/broadwell/romstage/report_platform.c
index d60ed38..88be982 100644
--- a/src/soc/intel/broadwell/romstage/report_platform.c
+++ b/src/soc/intel/broadwell/romstage/report_platform.c
@@ -16,7 +16,6 @@
#include <arch/cpu.h>
#include <device/pci_ops.h>
#include <console/console.h>
-#include <device/pci.h>
#include <string.h>
#include <cpu/x86/msr.h>
#include <soc/cpu.h>
diff --git a/src/soc/intel/broadwell/smbus_common.c b/src/soc/intel/broadwell/smbus_common.c
index 99ed55b..b6270fc 100644
--- a/src/soc/intel/broadwell/smbus_common.c
+++ b/src/soc/intel/broadwell/smbus_common.c
@@ -20,7 +20,6 @@
#include <device/device.h>
#include <device/path.h>
#include <device/smbus_def.h>
-#include <device/pci.h>
#include <soc/ramstage.h>
#include <soc/smbus.h>
diff --git a/src/soc/intel/broadwell/smi.c b/src/soc/intel/broadwell/smi.c
index 2bdeecc..2342e37 100644
--- a/src/soc/intel/broadwell/smi.c
+++ b/src/soc/intel/broadwell/smi.c
@@ -15,7 +15,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <console/console.h>
#include <arch/io.h>
#include <cpu/x86/cache.h>
diff --git a/src/soc/intel/broadwell/smmrelocate.c b/src/soc/intel/broadwell/smmrelocate.c
index 7bf351a..c88b006 100644
--- a/src/soc/intel/broadwell/smmrelocate.c
+++ b/src/soc/intel/broadwell/smmrelocate.c
@@ -16,7 +16,6 @@
#include <types.h>
#include <string.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <cpu/x86/cache.h>
#include <cpu/x86/lapic.h>
diff --git a/src/soc/intel/cannonlake/bootblock/report_platform.c b/src/soc/intel/cannonlake/bootblock/report_platform.c
index 8d82385..64e396d 100644
--- a/src/soc/intel/cannonlake/bootblock/report_platform.c
+++ b/src/soc/intel/cannonlake/bootblock/report_platform.c
@@ -18,7 +18,6 @@
#include <device/pci_ops.h>
#include <console/console.h>
#include <cpu/x86/msr.h>
-#include <device/pci.h>
#include <device/pci_ids.h>
#include <intelblocks/mp_init.h>
#include <soc/bootblock.h>
diff --git a/src/soc/intel/cannonlake/chip.c b/src/soc/intel/cannonlake/chip.c
index 2bb1c92..129cf1c 100644
--- a/src/soc/intel/cannonlake/chip.c
+++ b/src/soc/intel/cannonlake/chip.c
@@ -14,7 +14,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <fsp/api.h>
#include <fsp/util.h>
#include <intelblocks/acpi.h>
diff --git a/src/soc/intel/cannonlake/cpu.c b/src/soc/intel/cannonlake/cpu.c
index f01b499..6ec1afe 100644
--- a/src/soc/intel/cannonlake/cpu.c
+++ b/src/soc/intel/cannonlake/cpu.c
@@ -15,7 +15,6 @@
#include <arch/cpu.h>
#include <console/console.h>
-#include <device/pci.h>
#include <cpu/x86/lapic.h>
#include <cpu/x86/mp.h>
#include <cpu/x86/msr.h>
diff --git a/src/soc/intel/cannonlake/finalize.c b/src/soc/intel/cannonlake/finalize.c
index 002e8ea..2f45d37 100644
--- a/src/soc/intel/cannonlake/finalize.c
+++ b/src/soc/intel/cannonlake/finalize.c
@@ -20,7 +20,6 @@
#include <console/console.h>
#include <console/post_codes.h>
#include <cpu/x86/smm.h>
-#include <device/pci.h>
#include <intelblocks/lpc_lib.h>
#include <intelblocks/pcr.h>
#include <intelblocks/tco.h>
diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c
index dfc7e22..d4c3831 100644
--- a/src/soc/intel/cannonlake/fsp_params.c
+++ b/src/soc/intel/cannonlake/fsp_params.c
@@ -15,7 +15,6 @@
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <fsp/api.h>
#include <fsp/util.h>
#include <intelblocks/lpss.h>
diff --git a/src/soc/intel/cannonlake/lpc.c b/src/soc/intel/cannonlake/lpc.c
index c4eb884..84f66b26 100644
--- a/src/soc/intel/cannonlake/lpc.c
+++ b/src/soc/intel/cannonlake/lpc.c
@@ -16,7 +16,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <pc80/isa-dma.h>
#include <pc80/i8259.h>
#include <arch/io.h>
diff --git a/src/soc/intel/cannonlake/me.c b/src/soc/intel/cannonlake/me.c
index 0414470..868b7c1 100644
--- a/src/soc/intel/cannonlake/me.c
+++ b/src/soc/intel/cannonlake/me.c
@@ -17,7 +17,6 @@
#include <bootstate.h>
#include <commonlib/helpers.h>
#include <console/console.h>
-#include <device/pci.h>
#include <intelblocks/cse.h>
#include <soc/me.h>
#include <soc/pci_devs.h>
diff --git a/src/soc/intel/cannonlake/pmutil.c b/src/soc/intel/cannonlake/pmutil.c
index aded9c0..e5cb8ed 100644
--- a/src/soc/intel/cannonlake/pmutil.c
+++ b/src/soc/intel/cannonlake/pmutil.c
@@ -24,7 +24,6 @@
#include <device/mmio.h>
#include <cbmem.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <console/console.h>
#include <intelblocks/pmclib.h>
diff --git a/src/soc/intel/cannonlake/smmrelocate.c b/src/soc/intel/cannonlake/smmrelocate.c
index e99a9a2..ff81fe1 100644
--- a/src/soc/intel/cannonlake/smmrelocate.c
+++ b/src/soc/intel/cannonlake/smmrelocate.c
@@ -17,7 +17,6 @@
#include <types.h>
#include <string.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <cpu/x86/cache.h>
#include <cpu/x86/lapic.h>
diff --git a/src/soc/intel/cannonlake/systemagent.c b/src/soc/intel/cannonlake/systemagent.c
index 3f01f14..e4d387b 100644
--- a/src/soc/intel/cannonlake/systemagent.c
+++ b/src/soc/intel/cannonlake/systemagent.c
@@ -17,7 +17,6 @@
#include <device/device.h>
#include <delay.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <intelblocks/systemagent.h>
#include <soc/cpu.h>
diff --git a/src/soc/intel/common/block/include/intelblocks/imc.h b/src/soc/intel/common/block/include/intelblocks/imc.h
index fc3c241..38564fb 100644
--- a/src/soc/intel/common/block/include/intelblocks/imc.h
+++ b/src/soc/intel/common/block/include/intelblocks/imc.h
@@ -13,7 +13,6 @@
* GNU General Public License for more details.
*/
-#include <device/pci.h>
#include <stdint.h>
#ifndef SOC_INTEL_COMMON_BLOCK_IMC_H
diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c
index bc89e4c..badda2b 100644
--- a/src/soc/intel/common/block/lpc/lpc_lib.c
+++ b/src/soc/intel/common/block/lpc/lpc_lib.c
@@ -19,7 +19,6 @@
#include <assert.h>
#include <console/console.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <intelblocks/lpc_lib.h>
#include <lib.h>
diff --git a/src/soc/intel/common/block/scs/early_mmc.c b/src/soc/intel/common/block/scs/early_mmc.c
index 8036450..3285f6e 100644
--- a/src/soc/intel/common/block/scs/early_mmc.c
+++ b/src/soc/intel/common/block/scs/early_mmc.c
@@ -20,7 +20,6 @@
#include <commonlib/sdhci.h>
#include <compiler.h>
#include <console/console.h>
-#include <device/pci.h>
#include <intelblocks/mmc.h>
#include <soc/iomap.h>
#include <soc/pci_devs.h>
diff --git a/src/soc/intel/common/block/smbus/tco.c b/src/soc/intel/common/block/smbus/tco.c
index 1a215eb..b0ec217 100644
--- a/src/soc/intel/common/block/smbus/tco.c
+++ b/src/soc/intel/common/block/smbus/tco.c
@@ -16,7 +16,6 @@
#include <arch/io.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <intelblocks/pcr.h>
#include <intelblocks/tco.h>
diff --git a/src/soc/intel/common/block/systemagent/systemagent_early.c b/src/soc/intel/common/block/systemagent/systemagent_early.c
index d6f129d..846cd90 100644
--- a/src/soc/intel/common/block/systemagent/systemagent_early.c
+++ b/src/soc/intel/common/block/systemagent/systemagent_early.c
@@ -18,7 +18,6 @@
#include <device/mmio.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <intelblocks/systemagent.h>
#include <soc/iomap.h>
#include <soc/pci_devs.h>
diff --git a/src/soc/intel/denverton_ns/acpi.c b/src/soc/intel/denverton_ns/acpi.c
index 163f76a..9552bb0 100644
--- a/src/soc/intel/denverton_ns/acpi.c
+++ b/src/soc/intel/denverton_ns/acpi.c
@@ -22,7 +22,6 @@
#include <arch/smp/mpspec.h>
#include <cpu/x86/smm.h>
#include <string.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <cbmem.h>
#include <console/console.h>
diff --git a/src/soc/intel/denverton_ns/bootblock/bootblock.c b/src/soc/intel/denverton_ns/bootblock/bootblock.c
index 47c76b5..6612cfd 100644
--- a/src/soc/intel/denverton_ns/bootblock/bootblock.c
+++ b/src/soc/intel/denverton_ns/bootblock/bootblock.c
@@ -16,7 +16,6 @@
#include <bootblock_common.h>
#include <cpu/x86/mtrr.h>
-#include <device/pci.h>
#include <FsptUpd.h>
#include <intelblocks/fast_spi.h>
#include <soc/bootblock.h>
diff --git a/src/soc/intel/denverton_ns/cpu.c b/src/soc/intel/denverton_ns/cpu.c
index dd6f00e..56784ad 100644
--- a/src/soc/intel/denverton_ns/cpu.c
+++ b/src/soc/intel/denverton_ns/cpu.c
@@ -26,7 +26,6 @@
#include <cpu/intel/em64t100_save_state.h>
#include <cpu/intel/turbo.h>
#include <device/device.h>
-#include <device/pci.h>
#include <intelblocks/cpulib.h>
#include <reg_script.h>
diff --git a/src/soc/intel/denverton_ns/gpio_dnv.c b/src/soc/intel/denverton_ns/gpio_dnv.c
index b083768..c79d282 100644
--- a/src/soc/intel/denverton_ns/gpio_dnv.c
+++ b/src/soc/intel/denverton_ns/gpio_dnv.c
@@ -19,7 +19,6 @@
#include <device/mmio.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <soc/iomap.h>
#include <soc/pcr.h>
diff --git a/src/soc/intel/denverton_ns/smm.c b/src/soc/intel/denverton_ns/smm.c
index d05e76b..7326ab1 100644
--- a/src/soc/intel/denverton_ns/smm.c
+++ b/src/soc/intel/denverton_ns/smm.c
@@ -17,7 +17,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <console/console.h>
#include <arch/io.h>
#include <cpu/x86/smm.h>
diff --git a/src/soc/intel/denverton_ns/soc_util.c b/src/soc/intel/denverton_ns/soc_util.c
index ef95f7e..648a27c 100644
--- a/src/soc/intel/denverton_ns/soc_util.c
+++ b/src/soc/intel/denverton_ns/soc_util.c
@@ -17,7 +17,6 @@
#include <stdint.h>
#include <device/mmio.h>
#include <device/pci_ops.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <device/device.h>
#include <string.h>
diff --git a/src/soc/intel/icelake/bootblock/report_platform.c b/src/soc/intel/icelake/bootblock/report_platform.c
index 660aab9..4202fd2 100644
--- a/src/soc/intel/icelake/bootblock/report_platform.c
+++ b/src/soc/intel/icelake/bootblock/report_platform.c
@@ -17,7 +17,6 @@
#include <device/pci_ops.h>
#include <console/console.h>
#include <cpu/x86/msr.h>
-#include <device/pci.h>
#include <device/pci_ids.h>
#include <intelblocks/mp_init.h>
#include <soc/bootblock.h>
diff --git a/src/soc/intel/icelake/chip.c b/src/soc/intel/icelake/chip.c
index 2bb908c..ca11be3 100644
--- a/src/soc/intel/icelake/chip.c
+++ b/src/soc/intel/icelake/chip.c
@@ -14,7 +14,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <fsp/api.h>
#include <fsp/util.h>
#include <intelblocks/acpi.h>
diff --git a/src/soc/intel/icelake/cpu.c b/src/soc/intel/icelake/cpu.c
index e058442..b7a8512 100644
--- a/src/soc/intel/icelake/cpu.c
+++ b/src/soc/intel/icelake/cpu.c
@@ -15,7 +15,6 @@
#include <arch/cpu.h>
#include <console/console.h>
-#include <device/pci.h>
#include <cpu/x86/lapic.h>
#include <cpu/x86/mp.h>
#include <cpu/x86/msr.h>
diff --git a/src/soc/intel/icelake/espi.c b/src/soc/intel/icelake/espi.c
index efde625..acf9583 100644
--- a/src/soc/intel/icelake/espi.c
+++ b/src/soc/intel/icelake/espi.c
@@ -14,7 +14,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <pc80/isa-dma.h>
#include <pc80/i8259.h>
#include <arch/io.h>
diff --git a/src/soc/intel/icelake/finalize.c b/src/soc/intel/icelake/finalize.c
index 6afa61e..0d14124 100644
--- a/src/soc/intel/icelake/finalize.c
+++ b/src/soc/intel/icelake/finalize.c
@@ -19,7 +19,6 @@
#include <console/console.h>
#include <console/post_codes.h>
#include <cpu/x86/smm.h>
-#include <device/pci.h>
#include <intelblocks/lpc_lib.h>
#include <intelblocks/pcr.h>
#include <intelblocks/tco.h>
diff --git a/src/soc/intel/icelake/fsp_params.c b/src/soc/intel/icelake/fsp_params.c
index 448b82c..a6a6117 100644
--- a/src/soc/intel/icelake/fsp_params.c
+++ b/src/soc/intel/icelake/fsp_params.c
@@ -15,7 +15,6 @@
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <fsp/api.h>
#include <fsp/util.h>
#include <intelblocks/lpss.h>
diff --git a/src/soc/intel/icelake/pmutil.c b/src/soc/intel/icelake/pmutil.c
index 7b6168b..ac7e3af 100644
--- a/src/soc/intel/icelake/pmutil.c
+++ b/src/soc/intel/icelake/pmutil.c
@@ -23,7 +23,6 @@
#include <device/mmio.h>
#include <cbmem.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <console/console.h>
#include <intelblocks/pmclib.h>
diff --git a/src/soc/intel/icelake/smmrelocate.c b/src/soc/intel/icelake/smmrelocate.c
index 0bedc9e6..8d53bb9 100644
--- a/src/soc/intel/icelake/smmrelocate.c
+++ b/src/soc/intel/icelake/smmrelocate.c
@@ -16,7 +16,6 @@
#include <types.h>
#include <string.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <cpu/x86/cache.h>
#include <cpu/x86/lapic.h>
diff --git a/src/soc/intel/icelake/systemagent.c b/src/soc/intel/icelake/systemagent.c
index 930e78e..36d38e7 100644
--- a/src/soc/intel/icelake/systemagent.c
+++ b/src/soc/intel/icelake/systemagent.c
@@ -14,7 +14,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <intelblocks/systemagent.h>
#include <soc/iomap.h>
#include <soc/systemagent.h>
diff --git a/src/soc/intel/quark/i2c.c b/src/soc/intel/quark/i2c.c
index 1d17a7c..65c23b2 100644
--- a/src/soc/intel/quark/i2c.c
+++ b/src/soc/intel/quark/i2c.c
@@ -19,7 +19,6 @@
#include <delay.h>
#include <device/device.h>
#include <device/i2c_simple.h>
-#include <device/pci.h>
#include <soc/i2c.h>
#include <soc/ramstage.h>
#include <soc/reg_access.h>
diff --git a/src/soc/intel/quark/include/soc/pci_devs.h b/src/soc/intel/quark/include/soc/pci_devs.h
index a24f28f..e16aff7 100644
--- a/src/soc/intel/quark/include/soc/pci_devs.h
+++ b/src/soc/intel/quark/include/soc/pci_devs.h
@@ -18,7 +18,6 @@
#ifndef _QUARK_PCI_DEVS_H_
#define _QUARK_PCI_DEVS_H_
-#include <device/pci.h>
#include <device/pci_def.h>
/* DEVICE 0 (Memory Controller Hub) */
diff --git a/src/soc/intel/quark/include/soc/storage_test.h b/src/soc/intel/quark/include/soc/storage_test.h
index 1c93f1c..a8bdd8b 100644
--- a/src/soc/intel/quark/include/soc/storage_test.h
+++ b/src/soc/intel/quark/include/soc/storage_test.h
@@ -18,7 +18,6 @@
#include <commonlib/sd_mmc_ctrlr.h>
#include <device/device.h>
-#include <device/pci.h>
#include <timer.h>
#ifdef __SIMPLE_DEVICE__
diff --git a/src/soc/intel/quark/romstage/report_platform.c b/src/soc/intel/quark/romstage/report_platform.c
index cbbf43f..3e2b069 100644
--- a/src/soc/intel/quark/romstage/report_platform.c
+++ b/src/soc/intel/quark/romstage/report_platform.c
@@ -16,7 +16,6 @@
#include <arch/cpu.h>
#include <console/console.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <device/pci_def.h>
#include <soc/cpu.h>
diff --git a/src/soc/intel/skylake/bootblock/report_platform.c b/src/soc/intel/skylake/bootblock/report_platform.c
index b0b416e..596c726 100644
--- a/src/soc/intel/skylake/bootblock/report_platform.c
+++ b/src/soc/intel/skylake/bootblock/report_platform.c
@@ -19,7 +19,6 @@
#include <console/console.h>
#include <cpu/x86/msr.h>
#include <cpu/x86/name.h>
-#include <device/pci.h>
#include <device/pci_ids.h>
#include <intelblocks/mp_init.h>
#include <soc/bootblock.h>
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index f5273f6..08210cb 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -19,7 +19,6 @@
#include <bootstate.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <cpu/x86/mtrr.h>
#include <cpu/x86/msr.h>
#include <cpu/x86/lapic.h>
diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c
index e5d32d7..1ccaad0 100644
--- a/src/soc/intel/skylake/finalize.c
+++ b/src/soc/intel/skylake/finalize.c
@@ -22,7 +22,6 @@
#include <console/post_codes.h>
#include <cpu/x86/mp.h>
#include <cpu/x86/smm.h>
-#include <device/pci.h>
#include <intelblocks/cpulib.h>
#include <intelblocks/lpc_lib.h>
#include <intelblocks/p2sb.h>
diff --git a/src/soc/intel/skylake/irq.c b/src/soc/intel/skylake/irq.c
index 6e6d655..4a1b283 100644
--- a/src/soc/intel/skylake/irq.c
+++ b/src/soc/intel/skylake/irq.c
@@ -14,7 +14,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <intelblocks/lpc_lib.h>
#include <intelblocks/itss.h>
diff --git a/src/soc/intel/skylake/lpc.c b/src/soc/intel/skylake/lpc.c
index 71ffb9a..7ff9eda 100644
--- a/src/soc/intel/skylake/lpc.c
+++ b/src/soc/intel/skylake/lpc.c
@@ -16,7 +16,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <pc80/isa-dma.h>
#include <pc80/i8259.h>
#include <arch/ioapic.h>
diff --git a/src/soc/intel/skylake/me.c b/src/soc/intel/skylake/me.c
index d53d91e..937f72b 100644
--- a/src/soc/intel/skylake/me.c
+++ b/src/soc/intel/skylake/me.c
@@ -17,7 +17,6 @@
#include <bootstate.h>
#include <commonlib/helpers.h>
#include <console/console.h>
-#include <device/pci.h>
#include <intelblocks/cse.h>
#include <soc/iomap.h>
#include <soc/me.h>
diff --git a/src/soc/intel/skylake/pmutil.c b/src/soc/intel/skylake/pmutil.c
index 2b2141b..dee0915 100644
--- a/src/soc/intel/skylake/pmutil.c
+++ b/src/soc/intel/skylake/pmutil.c
@@ -23,7 +23,6 @@
#include <device/mmio.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <console/console.h>
#include <intelblocks/pmclib.h>
diff --git a/src/soc/intel/skylake/smmrelocate.c b/src/soc/intel/skylake/smmrelocate.c
index 62fc7e4..ae90068 100644
--- a/src/soc/intel/skylake/smmrelocate.c
+++ b/src/soc/intel/skylake/smmrelocate.c
@@ -17,7 +17,6 @@
#include <types.h>
#include <string.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <cpu/x86/cache.h>
#include <cpu/x86/lapic.h>
diff --git a/src/soc/intel/tigerlake/bootblock/report_platform.c b/src/soc/intel/tigerlake/bootblock/report_platform.c
index 41061ee..98ca7be 100644
--- a/src/soc/intel/tigerlake/bootblock/report_platform.c
+++ b/src/soc/intel/tigerlake/bootblock/report_platform.c
@@ -23,7 +23,6 @@
#include <device/pci_ops.h>
#include <console/console.h>
#include <cpu/x86/msr.h>
-#include <device/pci.h>
#include <device/pci_ids.h>
#include <intelblocks/mp_init.h>
#include <soc/bootblock.h>
diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c
index 530893c..d323ca5 100644
--- a/src/soc/intel/tigerlake/chip.c
+++ b/src/soc/intel/tigerlake/chip.c
@@ -14,7 +14,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <fsp/api.h>
#include <fsp/util.h>
#include <intelblocks/acpi.h>
diff --git a/src/soc/intel/tigerlake/cpu.c b/src/soc/intel/tigerlake/cpu.c
index 5f4f081..c41807e 100644
--- a/src/soc/intel/tigerlake/cpu.c
+++ b/src/soc/intel/tigerlake/cpu.c
@@ -21,7 +21,6 @@
#include <arch/cpu.h>
#include <console/console.h>
-#include <device/pci.h>
#include <cpu/x86/lapic.h>
#include <cpu/x86/mp.h>
#include <cpu/x86/msr.h>
diff --git a/src/soc/intel/tigerlake/espi.c b/src/soc/intel/tigerlake/espi.c
index 932f760..d8aff23 100644
--- a/src/soc/intel/tigerlake/espi.c
+++ b/src/soc/intel/tigerlake/espi.c
@@ -20,7 +20,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <pc80/isa-dma.h>
#include <pc80/i8259.h>
#include <arch/io.h>
diff --git a/src/soc/intel/tigerlake/finalize.c b/src/soc/intel/tigerlake/finalize.c
index 2de58a9..191e002 100644
--- a/src/soc/intel/tigerlake/finalize.c
+++ b/src/soc/intel/tigerlake/finalize.c
@@ -25,7 +25,6 @@
#include <console/console.h>
#include <console/post_codes.h>
#include <cpu/x86/smm.h>
-#include <device/pci.h>
#include <intelblocks/lpc_lib.h>
#include <intelblocks/pcr.h>
#include <intelblocks/tco.h>
diff --git a/src/soc/intel/tigerlake/pmutil.c b/src/soc/intel/tigerlake/pmutil.c
index 74e32e4..2883e11 100644
--- a/src/soc/intel/tigerlake/pmutil.c
+++ b/src/soc/intel/tigerlake/pmutil.c
@@ -30,7 +30,6 @@
#include <device/mmio.h>
#include <cbmem.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <console/console.h>
#include <intelblocks/pmclib.h>
diff --git a/src/soc/intel/tigerlake/smmrelocate.c b/src/soc/intel/tigerlake/smmrelocate.c
index 9e21a23..cd28a3a 100644
--- a/src/soc/intel/tigerlake/smmrelocate.c
+++ b/src/soc/intel/tigerlake/smmrelocate.c
@@ -16,7 +16,6 @@
#include <types.h>
#include <string.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <cpu/x86/cache.h>
#include <cpu/x86/lapic.h>
diff --git a/src/soc/intel/tigerlake/systemagent.c b/src/soc/intel/tigerlake/systemagent.c
index 9c8f645..37e4abe 100644
--- a/src/soc/intel/tigerlake/systemagent.c
+++ b/src/soc/intel/tigerlake/systemagent.c
@@ -20,7 +20,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <intelblocks/systemagent.h>
#include <soc/iomap.h>
#include <soc/systemagent.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/37521
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bdbefba59866a89e5380ffcad4695b31071c8a7
Gerrit-Change-Number: 37521
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-MessageType: newchange
1
2
Change in coreboot[master]: src/{device,drivers}: Remove unused '#include <device/pci.h>'
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37523 )
Change subject: src/{device,drivers}: Remove unused '#include <device/pci.h>'
......................................................................
src/{device,drivers}: Remove unused '#include <device/pci.h>'
Change-Id: I2ecbb81250876545f8ceef91710303ff4cc6a852
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/device/device_const.c
M src/device/oprom/realmode/x86.c
M src/device/oprom/realmode/x86_interrupts.c
M src/device/oprom/yabel/device.c
M src/device/oprom/yabel/interrupt.c
M src/device/oprom/yabel/io.c
M src/device/pci_ops.c
M src/device/pci_rom.c
M src/device/root_device.c
M src/drivers/aspeed/common/aspeed_coreboot.h
M src/drivers/generic/gfx/gfx.c
M src/drivers/i2c/rtd2132/rtd2132.c
M src/drivers/intel/gma/intel_ddi.c
M src/drivers/intel/gma/opregion.c
M src/drivers/intel/gma/vbt.c
M src/drivers/xgi/common/xgi_coreboot.c
M src/drivers/xgi/common/xgi_coreboot.h
17 files changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/37523/1
diff --git a/src/device/device_const.c b/src/device/device_const.c
index c46f283..698648e 100644
--- a/src/device/device_const.c
+++ b/src/device/device_const.c
@@ -14,7 +14,6 @@
#include <console/console.h>
#include <device/device.h>
#include <device/path.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <device/resource.h>
diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c
index 8ba0241..095e427 100644
--- a/src/device/oprom/realmode/x86.c
+++ b/src/device/oprom/realmode/x86.c
@@ -17,7 +17,6 @@
#include <boot/coreboot_tables.h>
#include <console/console.h>
#include <delay.h>
-#include <device/pci.h>
#include <device/pci_ids.h>
#include <pc80/i8259.h>
#include <pc80/i8254.h>
diff --git a/src/device/oprom/realmode/x86_interrupts.c b/src/device/oprom/realmode/x86_interrupts.c
index c38da46..6ed547b 100644
--- a/src/device/oprom/realmode/x86_interrupts.c
+++ b/src/device/oprom/realmode/x86_interrupts.c
@@ -13,7 +13,6 @@
#include <arch/registers.h>
#include <console/console.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
/* we use x86emu's register file representation */
diff --git a/src/device/oprom/yabel/device.c b/src/device/oprom/yabel/device.c
index 4a50068..4814829 100644
--- a/src/device/oprom/yabel/device.c
+++ b/src/device/oprom/yabel/device.c
@@ -39,7 +39,6 @@
#include "debug.h"
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <device/resource.h>
diff --git a/src/device/oprom/yabel/interrupt.c b/src/device/oprom/yabel/interrupt.c
index 338156f..b9a708c 100644
--- a/src/device/oprom/yabel/interrupt.c
+++ b/src/device/oprom/yabel/interrupt.c
@@ -45,7 +45,6 @@
#include <x86emu/x86emu.h>
#include "../x86emu/prim_ops.h"
-#include <device/pci.h>
#include <device/pci_ops.h>
diff --git a/src/device/oprom/yabel/io.c b/src/device/oprom/yabel/io.c
index 051a601..ec54ab0 100644
--- a/src/device/oprom/yabel/io.c
+++ b/src/device/oprom/yabel/io.c
@@ -41,7 +41,6 @@
#include <device/oprom/include/io.h>
#include "io.h"
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <device/resource.h>
diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c
index 431160e..3e5a2ee 100644
--- a/src/device/pci_ops.c
+++ b/src/device/pci_ops.c
@@ -13,7 +13,6 @@
#include <stdint.h>
#include <console/console.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <device/pci_ops.h>
#include <device/pci_type.h>
diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index 3676f9c..25acc30 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -14,7 +14,6 @@
#include <console/console.h>
#include <commonlib/endian.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h>
#include <string.h>
diff --git a/src/device/root_device.c b/src/device/root_device.c
index 6801b41..a891050 100644
--- a/src/device/root_device.c
+++ b/src/device/root_device.c
@@ -13,7 +13,6 @@
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <reset.h>
const char mainboard_name[] = CONFIG_MAINBOARD_VENDOR " " CONFIG_MAINBOARD_PART_NUMBER;
diff --git a/src/drivers/aspeed/common/aspeed_coreboot.h b/src/drivers/aspeed/common/aspeed_coreboot.h
index d3b6981..088ea55 100644
--- a/src/drivers/aspeed/common/aspeed_coreboot.h
+++ b/src/drivers/aspeed/common/aspeed_coreboot.h
@@ -24,7 +24,6 @@
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
/* coreboot <--> kernel code interface */
diff --git a/src/drivers/generic/gfx/gfx.c b/src/drivers/generic/gfx/gfx.c
index 76d311c..0e1a111 100644
--- a/src/drivers/generic/gfx/gfx.c
+++ b/src/drivers/generic/gfx/gfx.c
@@ -16,7 +16,6 @@
#include <arch/acpigen.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ids.h>
#include <stdint.h>
#include <string.h>
diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c
index 22eeaa8..f70e6d3 100644
--- a/src/drivers/i2c/rtd2132/rtd2132.c
+++ b/src/drivers/i2c/rtd2132/rtd2132.c
@@ -15,7 +15,6 @@
#include <delay.h>
#include <device/device.h>
#include <device/smbus.h>
-#include <device/pci.h>
#include "chip.h"
/* Chip commands */
diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c
index d52b293..163a9ac 100644
--- a/src/drivers/intel/gma/intel_ddi.c
+++ b/src/drivers/intel/gma/intel_ddi.c
@@ -32,7 +32,6 @@
#include <console/console.h>
#include <arch/acpi.h>
#include <smbios.h>
-#include <device/pci.h>
#include <ec/google/chromeec/ec.h>
#include <cpu/x86/tsc.h>
#include <cpu/x86/cache.h>
diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c
index 56449d0..1f46a76 100644
--- a/src/drivers/intel/gma/opregion.c
+++ b/src/drivers/intel/gma/opregion.c
@@ -17,7 +17,6 @@
#include <string.h>
#include <cbfs.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h>
#include <console/console.h>
diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c
index 603044a..93c3cf9 100644
--- a/src/drivers/intel/gma/vbt.c
+++ b/src/drivers/intel/gma/vbt.c
@@ -15,7 +15,6 @@
#include <device/pci_ops.h>
#include <device/device.h>
#include <string.h>
-#include <device/pci.h>
#include <drivers/intel/gma/opregion.h>
#include "i915.h"
diff --git a/src/drivers/xgi/common/xgi_coreboot.c b/src/drivers/xgi/common/xgi_coreboot.c
index caeb59d..9cfc558 100644
--- a/src/drivers/xgi/common/xgi_coreboot.c
+++ b/src/drivers/xgi/common/xgi_coreboot.c
@@ -17,7 +17,6 @@
#include <vbe.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h>
#include <pc80/vga.h>
diff --git a/src/drivers/xgi/common/xgi_coreboot.h b/src/drivers/xgi/common/xgi_coreboot.h
index a850087..0d368ac 100644
--- a/src/drivers/xgi/common/xgi_coreboot.h
+++ b/src/drivers/xgi/common/xgi_coreboot.h
@@ -25,7 +25,6 @@
#include <device/mmio.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include "initdef.h"
--
To view, visit https://review.coreboot.org/c/coreboot/+/37523
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ecbb81250876545f8ceef91710303ff4cc6a852
Gerrit-Change-Number: 37523
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
1
3
Change in coreboot[master]: southbridge: Remove unused '#include <device/pci.h>'
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37519 )
Change subject: southbridge: Remove unused '#include <device/pci.h>'
......................................................................
southbridge: Remove unused '#include <device/pci.h>'
Change-Id: I8eb2eee5addcf7247422aae626b19077a0533280
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/southbridge/amd/agesa/hudson/hudson.c
M src/southbridge/amd/agesa/hudson/spi.c
M src/southbridge/amd/cimx/sb800/fan.c
M src/southbridge/amd/cimx/sb800/spi.c
M src/southbridge/amd/pi/hudson/hudson.c
M src/southbridge/intel/bd82x6x/elog.c
M src/southbridge/intel/bd82x6x/pch.c
M src/southbridge/intel/common/gpio.c
M src/southbridge/intel/common/pciehp.c
M src/southbridge/intel/common/pmbase.c
M src/southbridge/intel/common/rcba_pirq.c
M src/southbridge/intel/common/smi.c
M src/southbridge/intel/common/spi.c
M src/southbridge/intel/common/watchdog.c
M src/southbridge/intel/i82371eb/fadt.c
M src/southbridge/intel/i82801dx/i82801dx.c
M src/southbridge/intel/i82801dx/smi.c
M src/southbridge/intel/i82801gx/i82801gx.c
M src/southbridge/intel/i82801ix/i82801ix.c
M src/southbridge/intel/i82801ix/smi.c
M src/southbridge/intel/i82801jx/i82801jx.c
M src/southbridge/intel/ibexpeak/madt.c
M src/southbridge/intel/ibexpeak/pch.c
M src/southbridge/intel/lynxpoint/elog.c
M src/southbridge/intel/lynxpoint/lp_gpio.c
M src/southbridge/intel/lynxpoint/pch.c
M src/southbridge/intel/lynxpoint/pmutil.c
M src/southbridge/intel/lynxpoint/rcba.c
M src/southbridge/intel/lynxpoint/smi.c
29 files changed, 0 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/37519/1
diff --git a/src/southbridge/amd/agesa/hudson/hudson.c b/src/southbridge/amd/agesa/hudson/hudson.c
index d586d33..f8a1151 100644
--- a/src/southbridge/amd/agesa/hudson/hudson.c
+++ b/src/southbridge/amd/agesa/hudson/hudson.c
@@ -17,7 +17,6 @@
#include <console/console.h>
#include <device/mmio.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h>
diff --git a/src/southbridge/amd/agesa/hudson/spi.c b/src/southbridge/amd/agesa/hudson/spi.c
index 9656027..53644b5 100644
--- a/src/southbridge/amd/agesa/hudson/spi.c
+++ b/src/southbridge/amd/agesa/hudson/spi.c
@@ -18,7 +18,6 @@
#include <spi_flash.h>
#include <spi-generic.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <Proc/Fch/FchPlatform.h>
diff --git a/src/southbridge/amd/cimx/sb800/fan.c b/src/southbridge/amd/cimx/sb800/fan.c
index 42c13d7..c702e99 100644
--- a/src/southbridge/amd/cimx/sb800/fan.c
+++ b/src/southbridge/amd/cimx/sb800/fan.c
@@ -15,7 +15,6 @@
#include <amdblocks/acpimmio.h>
#include <device/device.h>
-#include <device/pci.h> /* device_operations */
#include <device/pci_ops.h>
#include "SBPLATFORM.h"
#include "sb_cimx.h"
diff --git a/src/southbridge/amd/cimx/sb800/spi.c b/src/southbridge/amd/cimx/sb800/spi.c
index fcb4fa1..2256221 100644
--- a/src/southbridge/amd/cimx/sb800/spi.c
+++ b/src/southbridge/amd/cimx/sb800/spi.c
@@ -18,7 +18,6 @@
#include <spi_flash.h>
#include <spi-generic.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <types.h>
diff --git a/src/southbridge/amd/pi/hudson/hudson.c b/src/southbridge/amd/pi/hudson/hudson.c
index 51c37a1..db153fd 100644
--- a/src/southbridge/amd/pi/hudson/hudson.c
+++ b/src/southbridge/amd/pi/hudson/hudson.c
@@ -19,7 +19,6 @@
#include <device/mmio.h>
#include <arch/acpi.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h>
diff --git a/src/southbridge/intel/bd82x6x/elog.c b/src/southbridge/intel/bd82x6x/elog.c
index e96c38d..65cab72 100644
--- a/src/southbridge/intel/bd82x6x/elog.c
+++ b/src/southbridge/intel/bd82x6x/elog.c
@@ -16,7 +16,6 @@
#include <arch/io.h>
#include <arch/acpi.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <stdint.h>
#include <elog.h>
diff --git a/src/southbridge/intel/bd82x6x/pch.c b/src/southbridge/intel/bd82x6x/pch.c
index 5c2b130..3e19d61 100644
--- a/src/southbridge/intel/bd82x6x/pch.c
+++ b/src/southbridge/intel/bd82x6x/pch.c
@@ -18,7 +18,6 @@
#include <console/console.h>
#include <delay.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <device/pci_ops.h>
#include <string.h>
diff --git a/src/southbridge/intel/common/gpio.c b/src/southbridge/intel/common/gpio.c
index 9731d75..19d33ae 100644
--- a/src/southbridge/intel/common/gpio.c
+++ b/src/southbridge/intel/common/gpio.c
@@ -17,7 +17,6 @@
#include <arch/io.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include "gpio.h"
diff --git a/src/southbridge/intel/common/pciehp.c b/src/southbridge/intel/common/pciehp.c
index 8ff41b3..588b565 100644
--- a/src/southbridge/intel/common/pciehp.c
+++ b/src/southbridge/intel/common/pciehp.c
@@ -18,7 +18,6 @@
#include <arch/acpi.h>
#include <arch/acpigen.h>
#include <device/device.h>
-#include <device/pci.h>
#include "pciehp.h"
diff --git a/src/southbridge/intel/common/pmbase.c b/src/southbridge/intel/common/pmbase.c
index ff0410a..5aea7d6 100644
--- a/src/southbridge/intel/common/pmbase.c
+++ b/src/southbridge/intel/common/pmbase.c
@@ -18,7 +18,6 @@
#include <arch/io.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <assert.h>
#include <security/vboot/vboot_common.h>
diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c
index 366fe08..f2ddeb0 100644
--- a/src/southbridge/intel/common/rcba_pirq.c
+++ b/src/southbridge/intel/common/rcba_pirq.c
@@ -15,7 +15,6 @@
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <southbridge/intel/common/acpi_pirq_gen.h>
#include <southbridge/intel/common/rcba_pirq.h>
#include <southbridge/intel/common/rcba.h>
diff --git a/src/southbridge/intel/common/smi.c b/src/southbridge/intel/common/smi.c
index 1348174..632b393 100644
--- a/src/southbridge/intel/common/smi.c
+++ b/src/southbridge/intel/common/smi.c
@@ -16,7 +16,6 @@
#include <device/device.h>
-#include <device/pci.h>
#include <console/console.h>
#include <arch/io.h>
#include <cpu/x86/cache.h>
diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c
index cf67817..837d640 100644
--- a/src/southbridge/intel/common/spi.c
+++ b/src/southbridge/intel/common/spi.c
@@ -28,7 +28,6 @@
#include <device/pci_ops.h>
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <spi_flash.h>
#include <spi-generic.h>
diff --git a/src/southbridge/intel/common/watchdog.c b/src/southbridge/intel/common/watchdog.c
index 2eaedab..cace9d5 100644
--- a/src/southbridge/intel/common/watchdog.c
+++ b/src/southbridge/intel/common/watchdog.c
@@ -17,7 +17,6 @@
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <device/pci_ops.h>
#include <southbridge/intel/common/pmbase.h>
diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c
index cbfb0af..2496d19 100644
--- a/src/southbridge/intel/i82371eb/fadt.c
+++ b/src/southbridge/intel/i82371eb/fadt.c
@@ -20,7 +20,6 @@
#include <string.h>
#include <arch/acpi.h>
#include <device/device.h>
-#include <device/pci.h>
#include <version.h>
#include "i82371eb.h"
diff --git a/src/southbridge/intel/i82801dx/i82801dx.c b/src/southbridge/intel/i82801dx/i82801dx.c
index 765bcb2..759e726 100644
--- a/src/southbridge/intel/i82801dx/i82801dx.c
+++ b/src/southbridge/intel/i82801dx/i82801dx.c
@@ -15,7 +15,6 @@
*/
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include "i82801dx.h"
diff --git a/src/southbridge/intel/i82801dx/smi.c b/src/southbridge/intel/i82801dx/smi.c
index dc53220..2209292 100644
--- a/src/southbridge/intel/i82801dx/smi.c
+++ b/src/southbridge/intel/i82801dx/smi.c
@@ -16,7 +16,6 @@
#include <device/device.h>
-#include <device/pci.h>
#include <console/console.h>
#include <arch/acpi.h>
#include <arch/io.h>
diff --git a/src/southbridge/intel/i82801gx/i82801gx.c b/src/southbridge/intel/i82801gx/i82801gx.c
index 6aab741..151a777 100644
--- a/src/southbridge/intel/i82801gx/i82801gx.c
+++ b/src/southbridge/intel/i82801gx/i82801gx.c
@@ -16,7 +16,6 @@
#include <console/console.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include "i82801gx.h"
#include "sata.h"
diff --git a/src/southbridge/intel/i82801ix/i82801ix.c b/src/southbridge/intel/i82801ix/i82801ix.c
index 753c336a..9686ff8 100644
--- a/src/southbridge/intel/i82801ix/i82801ix.c
+++ b/src/southbridge/intel/i82801ix/i82801ix.c
@@ -19,7 +19,6 @@
#include <arch/io.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <console/console.h>
#include "chip.h"
#include "i82801ix.h"
diff --git a/src/southbridge/intel/i82801ix/smi.c b/src/southbridge/intel/i82801ix/smi.c
index 5f73f41..5650c75 100644
--- a/src/southbridge/intel/i82801ix/smi.c
+++ b/src/southbridge/intel/i82801ix/smi.c
@@ -17,7 +17,6 @@
#include <device/device.h>
-#include <device/pci.h>
#include <console/console.h>
#include <arch/io.h>
#include <device/pci_ops.h>
diff --git a/src/southbridge/intel/i82801jx/i82801jx.c b/src/southbridge/intel/i82801jx/i82801jx.c
index ebd427f..3c6e293 100644
--- a/src/southbridge/intel/i82801jx/i82801jx.c
+++ b/src/southbridge/intel/i82801jx/i82801jx.c
@@ -19,7 +19,6 @@
#include <arch/io.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <console/console.h>
#include "chip.h"
#include "i82801jx.h"
diff --git a/src/southbridge/intel/ibexpeak/madt.c b/src/southbridge/intel/ibexpeak/madt.c
index 3676a47..15b9510 100644
--- a/src/southbridge/intel/ibexpeak/madt.c
+++ b/src/southbridge/intel/ibexpeak/madt.c
@@ -19,7 +19,6 @@
#include <arch/acpi.h>
#include <arch/smp/mpspec.h>
#include <device/device.h>
-#include <device/pci.h>
unsigned long acpi_fill_madt(unsigned long current)
{
diff --git a/src/southbridge/intel/ibexpeak/pch.c b/src/southbridge/intel/ibexpeak/pch.c
index 9148b44..f8bcc10 100644
--- a/src/southbridge/intel/ibexpeak/pch.c
+++ b/src/southbridge/intel/ibexpeak/pch.c
@@ -18,7 +18,6 @@
#include <console/console.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include "pch.h"
diff --git a/src/southbridge/intel/lynxpoint/elog.c b/src/southbridge/intel/lynxpoint/elog.c
index 6f12c70..15f9604 100644
--- a/src/southbridge/intel/lynxpoint/elog.c
+++ b/src/southbridge/intel/lynxpoint/elog.c
@@ -16,7 +16,6 @@
#include <arch/io.h>
#include <arch/acpi.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_ops.h>
#include <stdint.h>
#include <elog.h>
diff --git a/src/southbridge/intel/lynxpoint/lp_gpio.c b/src/southbridge/intel/lynxpoint/lp_gpio.c
index 1919d58..115229f 100644
--- a/src/southbridge/intel/lynxpoint/lp_gpio.c
+++ b/src/southbridge/intel/lynxpoint/lp_gpio.c
@@ -17,7 +17,6 @@
#include <arch/io.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include "pch.h"
#include "lp_gpio.h"
diff --git a/src/southbridge/intel/lynxpoint/pch.c b/src/southbridge/intel/lynxpoint/pch.c
index cb50c12..cdd2065 100644
--- a/src/southbridge/intel/lynxpoint/pch.c
+++ b/src/southbridge/intel/lynxpoint/pch.c
@@ -19,7 +19,6 @@
#include <delay.h>
#include <device/pci_ops.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include "pch.h"
diff --git a/src/southbridge/intel/lynxpoint/pmutil.c b/src/southbridge/intel/lynxpoint/pmutil.c
index cc49477..095fe64 100644
--- a/src/southbridge/intel/lynxpoint/pmutil.c
+++ b/src/southbridge/intel/lynxpoint/pmutil.c
@@ -21,7 +21,6 @@
#include <arch/io.h>
#include <device/device.h>
-#include <device/pci.h>
#include <device/pci_def.h>
#include <console/console.h>
#include <security/vboot/vbnv.h>
diff --git a/src/southbridge/intel/lynxpoint/rcba.c b/src/southbridge/intel/lynxpoint/rcba.c
index 57253cb..d843547 100644
--- a/src/southbridge/intel/lynxpoint/rcba.c
+++ b/src/southbridge/intel/lynxpoint/rcba.c
@@ -15,7 +15,6 @@
#include <device/pci_def.h>
#include <device/device.h>
-#include <device/pci.h>
#include "pch.h"
void pch_config_rcba(const struct rcba_config_instruction *rcba_config)
diff --git a/src/southbridge/intel/lynxpoint/smi.c b/src/southbridge/intel/lynxpoint/smi.c
index e5c390e..0d6a548 100644
--- a/src/southbridge/intel/lynxpoint/smi.c
+++ b/src/southbridge/intel/lynxpoint/smi.c
@@ -16,7 +16,6 @@
#include <bootstate.h>
#include <device/device.h>
-#include <device/pci.h>
#include <console/console.h>
#include <arch/io.h>
#include <cpu/intel/smm_reloc.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/37519
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8eb2eee5addcf7247422aae626b19077a0533280
Gerrit-Change-Number: 37519
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
1
3
Change in coreboot[master]: mb/(ich7): Use 'intel/common/acpi/platform.asl'
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36882 )
Change subject: mb/(ich7): Use 'intel/common/acpi/platform.asl'
......................................................................
mb/(ich7): Use 'intel/common/acpi/platform.asl'
Change-Id: I547801efeb91aa2cbe9b4336bf2f3f00b8a8c07c
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
D src/mainboard/apple/macbook21/acpi/platform.asl
M src/mainboard/apple/macbook21/dsdt.asl
D src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl
M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl
D src/mainboard/ibase/mb899/acpi/platform.asl
M src/mainboard/ibase/mb899/dsdt.asl
D src/mainboard/intel/d945gclf/acpi/platform.asl
M src/mainboard/intel/d945gclf/dsdt.asl
D src/mainboard/kontron/986lcd-m/acpi/platform.asl
M src/mainboard/kontron/986lcd-m/dsdt.asl
D src/mainboard/roda/rk886ex/acpi/platform.asl
M src/mainboard/roda/rk886ex/dsdt.asl
12 files changed, 0 insertions(+), 360 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/36882/1
diff --git a/src/mainboard/apple/macbook21/acpi/platform.asl b/src/mainboard/apple/macbook21/acpi/platform.asl
deleted file mode 100644
index 84807ec..0000000
--- a/src/mainboard/apple/macbook21/acpi/platform.asl
+++ /dev/null
@@ -1,70 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-/* The _WAK method is called on system wakeup */
-
-Method(_WAK,1)
-{
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (LEqual(Arg0, 3)) {
- // ..
- }
-
- // Are we going to S4?
- If (LEqual(Arg0, 4)) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
- Return(Package(){0,0})
-}
-
-/* System Bus */
-
-Scope(\_SB)
-{
- /* This method is placed on the top level, so we can make sure it's the
- * first executed _INI method.
- */
- Method(_INI, 0)
- {
- /* The DTS data in NVS is probably not up to date.
- * Update temperature values and make sure AP thermal
- * interrupts can happen
- */
-
- // TRAP(71) // TODO
-
- \GOS()
-
- /* And the OS workarounds start right after we know what we're
- * running: Windows XP SP1 needs to have C-State coordination
- * enabled in SMM.
- */
- If (LAnd(LEqual(OSYS, 2001), MPEN)) {
- // TRAP(61) // TODO
- }
-
- /* SMM power state and C4-on-C3 settings need to be updated */
- // TRAP(43) // TODO
- }
-}
diff --git a/src/mainboard/apple/macbook21/dsdt.asl b/src/mainboard/apple/macbook21/dsdt.asl
index 40af217..76457a4 100644
--- a/src/mainboard/apple/macbook21/dsdt.asl
+++ b/src/mainboard/apple/macbook21/dsdt.asl
@@ -28,9 +28,6 @@
0x20090419 // OEM revision
)
{
- // Some generic macros
- #include "acpi/platform.asl"
-
// global NVS and variables
#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
#include <southbridge/intel/common/acpi/platform.asl>
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl b/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl
deleted file mode 100644
index 21eb3df..0000000
--- a/src/mainboard/gigabyte/ga-945gcm-s2l/acpi/platform.asl
+++ /dev/null
@@ -1,48 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-/* The _PTS method (Prepare To Sleep) is called before the OS is
- * entering a sleep state. The sleep state number is passed in Arg0
- */
-
-Method(_PTS,1)
-{
- // Call a trap so SMI can prepare for Sleep as well.
- // TRAP(0x55)
-}
-
-/* The _WAK method is called on system wakeup */
-
-Method(_WAK,1)
-{
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (LEqual(Arg0, 3)) {
- // ..
- }
-
- // Are we going to S4?
- If (LEqual(Arg0, 4)) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
- Return(Package(){0,0})
-}
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl b/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl
index afc5386..3b594be 100644
--- a/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl
+++ b/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl
@@ -23,9 +23,6 @@
0x20090419 // OEM revision
)
{
- // Some generic macros
- #include "acpi/platform.asl"
-
// global NVS and variables
#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
#include <southbridge/intel/common/acpi/platform.asl>
diff --git a/src/mainboard/ibase/mb899/acpi/platform.asl b/src/mainboard/ibase/mb899/acpi/platform.asl
deleted file mode 100644
index 9866110..0000000
--- a/src/mainboard/ibase/mb899/acpi/platform.asl
+++ /dev/null
@@ -1,48 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-/* The _PTS method (Prepare To Sleep) is called before the OS is
- * entering a sleep state. The sleep state number is passed in Arg0
- */
-
-Method(_PTS,1)
-{
- // Call a trap so SMI can prepare for Sleep as well.
- // TRAP(0x55)
-}
-
-/* The _WAK method is called on system wakeup */
-
-Method(_WAK,1)
-{
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (LEqual(Arg0, 3)) {
- // ..
- }
-
- // Are we going to S4?
- If (LEqual(Arg0, 4)) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
- Return(Package(){0,0})
-}
diff --git a/src/mainboard/ibase/mb899/dsdt.asl b/src/mainboard/ibase/mb899/dsdt.asl
index 31b67a7..e142624 100644
--- a/src/mainboard/ibase/mb899/dsdt.asl
+++ b/src/mainboard/ibase/mb899/dsdt.asl
@@ -23,9 +23,6 @@
0x20090419 // OEM revision
)
{
- // Some generic macros
- #include "acpi/platform.asl"
-
// global NVS and variables
#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
diff --git a/src/mainboard/intel/d945gclf/acpi/platform.asl b/src/mainboard/intel/d945gclf/acpi/platform.asl
deleted file mode 100644
index 21eb3df..0000000
--- a/src/mainboard/intel/d945gclf/acpi/platform.asl
+++ /dev/null
@@ -1,48 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-/* The _PTS method (Prepare To Sleep) is called before the OS is
- * entering a sleep state. The sleep state number is passed in Arg0
- */
-
-Method(_PTS,1)
-{
- // Call a trap so SMI can prepare for Sleep as well.
- // TRAP(0x55)
-}
-
-/* The _WAK method is called on system wakeup */
-
-Method(_WAK,1)
-{
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (LEqual(Arg0, 3)) {
- // ..
- }
-
- // Are we going to S4?
- If (LEqual(Arg0, 4)) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
- Return(Package(){0,0})
-}
diff --git a/src/mainboard/intel/d945gclf/dsdt.asl b/src/mainboard/intel/d945gclf/dsdt.asl
index afc5386..3b594be 100644
--- a/src/mainboard/intel/d945gclf/dsdt.asl
+++ b/src/mainboard/intel/d945gclf/dsdt.asl
@@ -23,9 +23,6 @@
0x20090419 // OEM revision
)
{
- // Some generic macros
- #include "acpi/platform.asl"
-
// global NVS and variables
#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
#include <southbridge/intel/common/acpi/platform.asl>
diff --git a/src/mainboard/kontron/986lcd-m/acpi/platform.asl b/src/mainboard/kontron/986lcd-m/acpi/platform.asl
deleted file mode 100644
index 9866110..0000000
--- a/src/mainboard/kontron/986lcd-m/acpi/platform.asl
+++ /dev/null
@@ -1,48 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-/* The _PTS method (Prepare To Sleep) is called before the OS is
- * entering a sleep state. The sleep state number is passed in Arg0
- */
-
-Method(_PTS,1)
-{
- // Call a trap so SMI can prepare for Sleep as well.
- // TRAP(0x55)
-}
-
-/* The _WAK method is called on system wakeup */
-
-Method(_WAK,1)
-{
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (LEqual(Arg0, 3)) {
- // ..
- }
-
- // Are we going to S4?
- If (LEqual(Arg0, 4)) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
- Return(Package(){0,0})
-}
diff --git a/src/mainboard/kontron/986lcd-m/dsdt.asl b/src/mainboard/kontron/986lcd-m/dsdt.asl
index d4ffd7b..c3d1910 100644
--- a/src/mainboard/kontron/986lcd-m/dsdt.asl
+++ b/src/mainboard/kontron/986lcd-m/dsdt.asl
@@ -23,9 +23,6 @@
0x20090419 // OEM revision
)
{
- // Some generic macros
- #include "acpi/platform.asl"
-
// global NVS and variables
#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
#include <southbridge/intel/common/acpi/platform.asl>
diff --git a/src/mainboard/roda/rk886ex/acpi/platform.asl b/src/mainboard/roda/rk886ex/acpi/platform.asl
deleted file mode 100644
index ebd22af..0000000
--- a/src/mainboard/roda/rk886ex/acpi/platform.asl
+++ /dev/null
@@ -1,80 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2007-2009 coresystems GmbH
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; version 2 of
- * the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-/* The _PTS method (Prepare To Sleep) is called before the OS is
- * entering a sleep state. The sleep state number is passed in Arg0
- */
-
-Method(_PTS,1)
-{
- // Call a trap so SMI can prepare for Sleep as well.
- // TRAP(0x55)
-}
-
-/* The _WAK method is called on system wakeup */
-
-Method(_WAK,1)
-{
- // CPU specific part
-
- // Notify PCI Express slots in case a card
- // was inserted while a sleep state was active.
-
- // Are we going to S3?
- If (LEqual(Arg0, 3)) {
- // ..
- }
-
- // Are we going to S4?
- If (LEqual(Arg0, 4)) {
- // ..
- }
-
- // TODO: Windows XP SP2 P-State restore
-
- Return(Package(){0,0})
-}
-
-/* System Bus */
-
-Scope(\_SB)
-{
- /* This method is placed on the top level, so we can make sure it's the
- * first executed _INI method.
- */
- Method(_INI, 0)
- {
- /* The DTS data in NVS is probably not up to date.
- * Update temperature values and make sure AP thermal
- * interrupts can happen
- */
-
- // TRAP(71) // TODO
-
- \GOS()
-
- /* And the OS workarounds start right after we know what we're
- * running: Windows XP SP1 needs to have C-State coordination
- * enabled in SMM.
- */
- If (LAnd(LEqual(OSYS, 2001), MPEN)) {
- // TRAP(61) // TODO
- }
-
- /* SMM power state and C4-on-C3 settings need to be updated */
- // TRAP(43) // TODO
- }
-}
diff --git a/src/mainboard/roda/rk886ex/dsdt.asl b/src/mainboard/roda/rk886ex/dsdt.asl
index f9a2abe..1132ad9 100644
--- a/src/mainboard/roda/rk886ex/dsdt.asl
+++ b/src/mainboard/roda/rk886ex/dsdt.asl
@@ -24,9 +24,6 @@
0x20090419 // OEM revision
)
{
- // Some generic macros
- #include "acpi/platform.asl"
-
// global NVS and variables
#include <southbridge/intel/i82801gx/acpi/globalnvs.asl>
#include <southbridge/intel/common/acpi/platform.asl>
--
To view, visit https://review.coreboot.org/c/coreboot/+/36882
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I547801efeb91aa2cbe9b4336bf2f3f00b8a8c07c
Gerrit-Change-Number: 36882
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
2
3
Change in coreboot[master]: device/pci_rom: Add missing <device/pci_def.h>
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37846 )
Change subject: device/pci_rom: Add missing <device/pci_def.h>
......................................................................
device/pci_rom: Add missing <device/pci_def.h>
Change-Id: I3c49e6916f83e35afb846ff093827522e92fc980
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/device/pci_rom.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/37846/1
diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index a405dff..f7b978c 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -15,6 +15,7 @@
#include <commonlib/endian.h>
#include <device/device.h>
#include <device/pci.h>
+#include <device/pci_def.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h>
#include <device/pci_rom.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/37846
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c49e6916f83e35afb846ff093827522e92fc980
Gerrit-Change-Number: 37846
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
1
1
Change in coreboot[master]: mainboard: Add missing include <device/pci_def.h>
by HAOUAS Elyes (Code Review) Jan. 7, 2020
by HAOUAS Elyes (Code Review) Jan. 7, 2020
Jan. 7, 2020
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h>
......................................................................
mainboard: Add missing include <device/pci_def.h>
Change-Id: I6e062923f8b5501ab50b9af291b01241d17e122c
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M 3rdparty/vboot
M src/mainboard/amd/inagua/irq_tables.c
M src/mainboard/amd/parmer/irq_tables.c
M src/mainboard/amd/persimmon/irq_tables.c
M src/mainboard/amd/south_station/irq_tables.c
M src/mainboard/amd/thatcher/irq_tables.c
M src/mainboard/amd/union_station/irq_tables.c
M src/mainboard/biostar/a68n_5200/irq_tables.c
M src/mainboard/elmex/pcm205400/irq_tables.c
M src/mainboard/gizmosphere/gizmo2/irq_tables.c
M src/mainboard/lippert/frontrunner-af/irq_tables.c
M src/mainboard/lippert/toucan-af/irq_tables.c
12 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/37951/1
diff --git a/3rdparty/vboot b/3rdparty/vboot
index 2843aa6..b0cf750 160000
--- a/3rdparty/vboot
+++ b/3rdparty/vboot
@@ -1 +1 @@
-Subproject commit 2843aa62ba7bcaab2abccf16e3f1b8bd7e058fdb
+Subproject commit b0cf75021801d5fb38017f3b0852601b02f84dbf
diff --git a/src/mainboard/amd/inagua/irq_tables.c b/src/mainboard/amd/inagua/irq_tables.c
index a066864..1d1e81f 100644
--- a/src/mainboard/amd/inagua/irq_tables.c
+++ b/src/mainboard/amd/inagua/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/amd/parmer/irq_tables.c b/src/mainboard/amd/parmer/irq_tables.c
index 530c132..181908a 100644
--- a/src/mainboard/amd/parmer/irq_tables.c
+++ b/src/mainboard/amd/parmer/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/amd/persimmon/irq_tables.c b/src/mainboard/amd/persimmon/irq_tables.c
index a066864..1d1e81f 100644
--- a/src/mainboard/amd/persimmon/irq_tables.c
+++ b/src/mainboard/amd/persimmon/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/amd/south_station/irq_tables.c b/src/mainboard/amd/south_station/irq_tables.c
index a066864..1d1e81f 100644
--- a/src/mainboard/amd/south_station/irq_tables.c
+++ b/src/mainboard/amd/south_station/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/amd/thatcher/irq_tables.c b/src/mainboard/amd/thatcher/irq_tables.c
index 530c132..181908a 100644
--- a/src/mainboard/amd/thatcher/irq_tables.c
+++ b/src/mainboard/amd/thatcher/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/amd/union_station/irq_tables.c b/src/mainboard/amd/union_station/irq_tables.c
index a066864..1d1e81f 100644
--- a/src/mainboard/amd/union_station/irq_tables.c
+++ b/src/mainboard/amd/union_station/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/biostar/a68n_5200/irq_tables.c b/src/mainboard/biostar/a68n_5200/irq_tables.c
index 530c132..181908a 100644
--- a/src/mainboard/biostar/a68n_5200/irq_tables.c
+++ b/src/mainboard/biostar/a68n_5200/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/elmex/pcm205400/irq_tables.c b/src/mainboard/elmex/pcm205400/irq_tables.c
index 804f52d..d114996 100644
--- a/src/mainboard/elmex/pcm205400/irq_tables.c
+++ b/src/mainboard/elmex/pcm205400/irq_tables.c
@@ -15,6 +15,7 @@
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/gizmosphere/gizmo2/irq_tables.c b/src/mainboard/gizmosphere/gizmo2/irq_tables.c
index 530c132..181908a 100644
--- a/src/mainboard/gizmosphere/gizmo2/irq_tables.c
+++ b/src/mainboard/gizmosphere/gizmo2/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/lippert/frontrunner-af/irq_tables.c b/src/mainboard/lippert/frontrunner-af/irq_tables.c
index a066864..1d1e81f 100644
--- a/src/mainboard/lippert/frontrunner-af/irq_tables.c
+++ b/src/mainboard/lippert/frontrunner-af/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
diff --git a/src/mainboard/lippert/toucan-af/irq_tables.c b/src/mainboard/lippert/toucan-af/irq_tables.c
index a066864..1d1e81f 100644
--- a/src/mainboard/lippert/toucan-af/irq_tables.c
+++ b/src/mainboard/lippert/toucan-af/irq_tables.c
@@ -14,6 +14,7 @@
*/
#include <console/console.h>
+#include <device/pci_def.h>
#include <string.h>
#include <stdint.h>
#include <arch/pirq_routing.h>
--
To view, visit https://review.coreboot.org/c/coreboot/+/37951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e062923f8b5501ab50b9af291b01241d17e122c
Gerrit-Change-Number: 37951
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange
3
6