HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
mainboard: Add missing include <device/pci_def.h>
Change-Id: I6e062923f8b5501ab50b9af291b01241d17e122c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M 3rdparty/vboot M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/parmer/irq_tables.c M src/mainboard/amd/persimmon/irq_tables.c M src/mainboard/amd/south_station/irq_tables.c M src/mainboard/amd/thatcher/irq_tables.c M src/mainboard/amd/union_station/irq_tables.c M src/mainboard/biostar/a68n_5200/irq_tables.c M src/mainboard/elmex/pcm205400/irq_tables.c M src/mainboard/gizmosphere/gizmo2/irq_tables.c M src/mainboard/lippert/frontrunner-af/irq_tables.c M src/mainboard/lippert/toucan-af/irq_tables.c 12 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/37951/1
diff --git a/3rdparty/vboot b/3rdparty/vboot index 2843aa6..b0cf750 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 2843aa62ba7bcaab2abccf16e3f1b8bd7e058fdb +Subproject commit b0cf75021801d5fb38017f3b0852601b02f84dbf diff --git a/src/mainboard/amd/inagua/irq_tables.c b/src/mainboard/amd/inagua/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/inagua/irq_tables.c +++ b/src/mainboard/amd/inagua/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/parmer/irq_tables.c b/src/mainboard/amd/parmer/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/amd/parmer/irq_tables.c +++ b/src/mainboard/amd/parmer/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/persimmon/irq_tables.c b/src/mainboard/amd/persimmon/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/persimmon/irq_tables.c +++ b/src/mainboard/amd/persimmon/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/south_station/irq_tables.c b/src/mainboard/amd/south_station/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/south_station/irq_tables.c +++ b/src/mainboard/amd/south_station/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/thatcher/irq_tables.c b/src/mainboard/amd/thatcher/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/amd/thatcher/irq_tables.c +++ b/src/mainboard/amd/thatcher/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/amd/union_station/irq_tables.c b/src/mainboard/amd/union_station/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/amd/union_station/irq_tables.c +++ b/src/mainboard/amd/union_station/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/biostar/a68n_5200/irq_tables.c b/src/mainboard/biostar/a68n_5200/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/biostar/a68n_5200/irq_tables.c +++ b/src/mainboard/biostar/a68n_5200/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/elmex/pcm205400/irq_tables.c b/src/mainboard/elmex/pcm205400/irq_tables.c index 804f52d..d114996 100644 --- a/src/mainboard/elmex/pcm205400/irq_tables.c +++ b/src/mainboard/elmex/pcm205400/irq_tables.c @@ -15,6 +15,7 @@
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/gizmosphere/gizmo2/irq_tables.c b/src/mainboard/gizmosphere/gizmo2/irq_tables.c index 530c132..181908a 100644 --- a/src/mainboard/gizmosphere/gizmo2/irq_tables.c +++ b/src/mainboard/gizmosphere/gizmo2/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/lippert/frontrunner-af/irq_tables.c b/src/mainboard/lippert/frontrunner-af/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/lippert/frontrunner-af/irq_tables.c +++ b/src/mainboard/lippert/frontrunner-af/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h> diff --git a/src/mainboard/lippert/toucan-af/irq_tables.c b/src/mainboard/lippert/toucan-af/irq_tables.c index a066864..1d1e81f 100644 --- a/src/mainboard/lippert/toucan-af/irq_tables.c +++ b/src/mainboard/lippert/toucan-af/irq_tables.c @@ -14,6 +14,7 @@ */
#include <console/console.h> +#include <device/pci_def.h> #include <string.h> #include <stdint.h> #include <arch/pirq_routing.h>
HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
mainboard: Add missing include <device/pci_def.h>
Change-Id: I6e062923f8b5501ab50b9af291b01241d17e122c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/parmer/irq_tables.c M src/mainboard/amd/persimmon/irq_tables.c M src/mainboard/amd/south_station/irq_tables.c M src/mainboard/amd/thatcher/irq_tables.c M src/mainboard/amd/union_station/irq_tables.c M src/mainboard/biostar/a68n_5200/irq_tables.c M src/mainboard/elmex/pcm205400/irq_tables.c M src/mainboard/gizmosphere/gizmo2/irq_tables.c M src/mainboard/lippert/frontrunner-af/irq_tables.c M src/mainboard/lippert/toucan-af/irq_tables.c 11 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/37951/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
Patch Set 2:
(11 comments)
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/inagua/ir... File src/mainboard/amd/inagua/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/inagua/ir... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/parmer/ir... File src/mainboard/amd/parmer/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/parmer/ir... PS2, Line 64: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/persimmon... File src/mainboard/amd/persimmon/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/persimmon... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/south_sta... File src/mainboard/amd/south_station/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/south_sta... PS2, Line 65: pirq->rtr_devfn = PCI_DEVFN(0x14, 4); needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/thatcher/... File src/mainboard/amd/thatcher/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/thatcher/... PS2, Line 64: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/union_sta... File src/mainboard/amd/union_station/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/amd/union_sta... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/biostar/a68n_... File src/mainboard/biostar/a68n_5200/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/biostar/a68n_... PS2, Line 64: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/elmex/pcm2054... File src/mainboard/elmex/pcm205400/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/elmex/pcm2054... PS2, Line 67: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/gizmosphere/g... File src/mainboard/gizmosphere/gizmo2/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/gizmosphere/g... PS2, Line 64: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/lippert/front... File src/mainboard/lippert/frontrunner-af/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/lippert/front... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/lippert/touca... File src/mainboard/lippert/toucan-af/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/37951/2/src/mainboard/lippert/touca... PS2, Line 65: PCI_DEVFN needs <device/pci_def.h>
Mike Banon has uploaded a new patch set (#3) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
mainboard: Add missing include <device/pci_def.h>
Change-Id: I6e062923f8b5501ab50b9af291b01241d17e122c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/inagua/irq_tables.c M src/mainboard/amd/olivehill/irq_tables.c M src/mainboard/amd/parmer/irq_tables.c M src/mainboard/amd/persimmon/irq_tables.c M src/mainboard/amd/south_station/irq_tables.c M src/mainboard/amd/thatcher/irq_tables.c M src/mainboard/amd/union_station/irq_tables.c M src/mainboard/bap/ode_e20XX/irq_tables.c M src/mainboard/biostar/a68n_5200/irq_tables.c M src/mainboard/elmex/pcm205400/irq_tables.c M src/mainboard/gizmosphere/gizmo2/irq_tables.c M src/mainboard/hp/abm/irq_tables.c M src/mainboard/lippert/frontrunner-af/irq_tables.c M src/mainboard/lippert/toucan-af/irq_tables.c 14 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/37951/3
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
Patch Set 3: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
Patch Set 4: Code-Review-2
See CB:37842 comments, for now let's not add <pci_def.h> for PCI_SLOT() or PCI_DEVFN() et.al.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37951 )
Change subject: mainboard: Add missing include <device/pci_def.h> ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Mike Banon (Code Review)